Add support for assertions #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new `assertions` property for operations. When this property is present, Rally checks all assertions and raises an error if the check fails.
With this commit we disable assertions by default but allow to enable them via a command line flag.
danielmitterdorfer
added
enhancement
|
This has been caused by a transient failure: @elasticmachine test this please |
gingerwizard
approved these changes
Jan 26, 2021
|
|
||
| * ``raw-request`` | ||
| * ``sleep`` | ||
| * ``search`` |
danielmitterdorfer
added a commit
to danielmitterdorfer/rally
that referenced
this pull request
Feb 3, 2021
With this commit we add a new `meta data` section to each operation in the track reference documentation which documents which meta data are returned. This information can be used to add assertions for custom tracks. We also enhance a couple of existing runners so that they return a `dict` structure instead of a tuple because only `dicts` are supported for assertions. Relates elastic#1157
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 3, 2021
With this commit we add a new `meta data` section to each operation in the track reference documentation which documents which meta data are returned. This information can be used to add assertions for custom tracks. We also enhance a couple of existing runners so that they return a `dict` structure instead of a tuple because only `dicts` are supported for assertions. Relates #1157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new
assertionsproperty for operations. Whenthis property is present and assertions are enabled with
--enable-assertions,Rally checks all assertions and raises an error if the check fails.