Only consider race id when loading a race #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we drop the `environment` filter when searching a race by its it in the Elasticsearch race store and only consider the race id. The previous filter was a leftover from the times when we did not use a race id but only a race timestamp as the identifier of a race. In that case it was useful to also filter for the environment but as the race id is unique we can drop the additional filter. This is also consistent how the Elasticsearch metrics store works (see `EsMetricsStore#_query_by_name`). With this change it is possible to use the `compare` subcommand to compare races from differente environments as long as the results have been written to the same Elasticsearch metrics store. Note that we intentionally don't change the filter that lists races; it still considers the environment name in order to ensure we only show races that have been run in that environment.
danielmitterdorfer
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we drop the
environmentfilter when searching a raceby its id in the Elasticsearch race store and only consider the race id.
The previous filter was a leftover from the times when we did not use a
race id but only a race timestamp as the identifier of a race. In that
case it was useful to also filter for the environment but as the race id
is unique we can drop the additional filter. This is also consistent how
the Elasticsearch metrics store works (see
EsMetricsStore#_query_by_name). With this change it is possible to usethe
comparesubcommand to compare races from differente environmentsas long as the results have been written to the same Elasticsearch
metrics store. Note that we intentionally don't change the filter that
lists races; it still considers the environment name in order to ensure
we only show races that have been run in that environment.