Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error wrapper script on unclean local state #1115

Conversation

danielmitterdorfer
Copy link
Member

With this commit we exit the Rally wrapper script with an error if the
local working copy contains uncommitted files. This avoids skipping
automatic updates silently if uncommitted files are unintentionally
present. Users that still want to continue running can do so by
specifying --skip-update.

Closes #911

With this commit we exit the Rally wrapper script with an error if the
local working copy contains uncommitted files. This avoids skipping
automatic updates silently if uncommitted files are unintentionally
present. Users that still want to continue running can do so by
specifying `--skip-update`.

Closes elastic#911
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use labels Nov 18, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.3 milestone Nov 18, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Nov 18, 2020
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@danielmitterdorfer danielmitterdorfer merged commit acde0b9 into elastic:master Nov 19, 2020
@danielmitterdorfer danielmitterdorfer deleted the error-on-dirty-working-copy branch November 19, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make run.sh update emit an error when git update fails
2 participants