Ensure that request error meta-data is string #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we ensure that the `error-description` property that is added to request metadata on errors always contains a string. This avoids serialization issues later on when these objects are written to the metrics store.
danielmitterdorfer
added
bug
gingerwizard
reviewed
Oct 7, 2020
| if isinstance(e.error, bytes): | ||
| error_description = e.error.decode("utf-8") | ||
| else: | ||
| error_description = str(e.error) |
There was a problem hiding this comment.
Would it be soo bad to leave as None given thats the only other viable type? For safety this probably makes sense.
There was a problem hiding this comment.
As discussed elsewhere I'd rather be a bit more cautious here and always enforce conversion to a string.
gingerwizard
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we ensure that the
error-descriptionproperty that isadded to request metadata on errors always contains a string. This
avoids serialization issues later on when these objects are written to
the metrics store.