Fix parallel completed-by task identification #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that parses the track previously used the operation name to identify which task completes a parallel loop. This was fine if tasks were not explicitly because the task name defaults to the operation name. If a user explicitly creates a task name, this would fail. The fix is to use the task name instead, which still defaults to the operation name if not provided, which preserves compatibility. Closes elastic#1068
danielmitterdorfer
added
the
:Track Management
|
@elasticmachine test this please |
danielmitterdorfer
approved these changes
Oct 6, 2020
| @@ -1263,7 +1264,7 @@ def parse_task(self, task_spec, ops, challenge_name, default_warmup_iterations=N | |||
| default_value=default_time_period), | |||
| clients=self._r(task_spec, "clients", error_ctx=op.name, mandatory=False, default_value=1), | |||
| # this will work because op_name must always be set, i.e. it is never `None`. | |||
| completes_parent=(op.name == completed_by_name), | |||
There was a problem hiding this comment.
Nit: I think we can get rid of the comment in the line above as well as it is not applicable anymore IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that parses the track previously used the operation name to
identify which task completes a parallel loop. This was fine if tasks
were not explicitly because the task name defaults to the operation
name. If a user explicitly creates a task name, this would fail. The fix
is to use the task name instead, which still defaults to the operation
name if not provided, which preserves compatibility.
Closes #1068