Fail fast if leading / is missing from path in raw-request
#1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for mandatory leading `/` in path parameter of raw-request. Raise RallyException if it's missing. Closes elastic#1063
ebadyano
added
enhancement
dliappis
approved these changes
Sep 19, 2020
esrally/driver/runner.py
Outdated
| @@ -1425,8 +1425,13 @@ async def __call__(self, es, params): | |||
| request_params["ignore"] = params["ignore"] | |||
| request_params.update(params.get("request-params", {})) | |||
|
|
|||
| path = mandatory(params, "path", self) | |||
| if not path.startswith("/"): | |||
| self.logger.error("RawRequest failed. Path parameter: [%s] must begin with a '/'", path) | |||
There was a problem hiding this comment.
nit: missing full stop after '/' (you have it in the exception below).
|
@dliappis Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for mandatory leading
/in path parameter of raw-request. Raise RallyException if it's missing.Closes #1063