Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if total_transform_processing_times exist for compare reports #1055

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Check if total_transform_processing_times exist for compare reports #1055

merged 1 commit into from
Sep 2, 2020

Conversation

ebadyano
Copy link
Contributor

@ebadyano ebadyano commented Sep 2, 2020

When race didn't have total_transform_processing_times to report, esrally compare fails

Relates to #1022

@ebadyano
Check if total_transform_processing_times exist for compare reports
90c18fa 
When race didn't have total_transform_processing_times to report,
`esrally compare` fails

Relates to elastic#1022
@ebadyano ebadyano added bug Something's wrong enhancement Improves the status quo :Reporting Command line reporting labels Sep 2, 2020
@ebadyano ebadyano added this to the 2.0.2 milestone Sep 2, 2020
@ebadyano ebadyano requested a review from dliappis September 2, 2020 14:29
@ebadyano ebadyano self-assigned this Sep 2, 2020
dliappis
dliappis approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@ebadyano
Copy link
Contributor Author

ebadyano commented Sep 2, 2020

@dliappis Thank you for the review!

@ebadyano ebadyano merged commit 77d193c into elastic:master Sep 2, 2020
@ebadyano ebadyano deleted the fix-compare branch December 16, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@gingerwizard gingerwizard Awaiting requested review from gingerwizard

Assignees

@ebadyano ebadyano

Labels
bug Something's wrong enhancement Improves the status quo :Reporting Command line reporting
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ebadyano @dliappis