Improve support for benchmarks with many clients #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we emit some log messages only once per task (instead of once per simulated client). These messages were completely repetitive and also sent at almost the same time. As each log message is sent as an actor system message to thespian's logging actor, this causes a storm of messages to be sent which fills up its internal message queue and leads to dropped messages. We also increase the size of Rally's internal queue that stores measurement samples from 2^16 to 2^20 and make this setting configurable via Rally's configuration file. This allows Rally to buffer more measurement samples if a lot of clients are configured for a benchmark.
danielmitterdorfer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we emit some log messages only once per task (instead
of once per simulated client). These messages were completely repetitive
and also sent at almost the same time. As each log message is sent as an
actor system message to thespian's logging actor, this causes a storm of
messages to be sent which fills up its internal message queue and leads
to dropped messages.
We also increase the size of Rally's internal queue that stores
measurement samples from 2^16 to 2^20 and make this setting configurable
via Rally's configuration file. This allows Rally to buffer more
measurement samples if a lot of clients are configured for a benchmark.