Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on request errors #1035

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Warn on request errors #1035

merged 3 commits into from
Aug 4, 2020

Conversation

bartier
Copy link
Contributor

@bartier bartier commented Jul 28, 2020

This PR attempts to solve #910

  • It adds a new condition to allow "administrative" operations to be included in the command line report, as a result, users could be more aware of the errors.
  • Emit a warning when the error rate of an operation is greater than zero

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use labels Jul 28, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.1 milestone Jul 28, 2020
@danielmitterdorfer
Copy link
Member

@elasticmachine test this please

@hub-cap
Copy link
Contributor

hub-cap commented Jul 30, 2020

Hi, thanks for the PR @bartier . I will be testing and reviewing this next week. I just wanted to drop a comment here so you don't think I've forgotten about you!

@hub-cap
Copy link
Contributor

hub-cap commented Aug 3, 2020

@elasticmachine ok to test

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested this and it looks great. I was able to hammer a local instance to see it in action. I would like to see the error rate in the warning look like the error rate displayed in the table (the 86.46 vs 0.8646xxxxx). Other than that small change, I think this is worth merging!

|                                  100th percentile service time | index-append |   3527.01 |     ms |
|                                                     error rate | index-append |     86.46 |      % |

[WARNING] Error rate is 0.8646496815286624 for operation 'index-append'. Please check the logs.

@bartier
Copy link
Contributor Author

bartier commented Aug 4, 2020

@hub-cap Thanks! I submitted a code change to round the error rate in the warning message. Could you check again please?

@bartier bartier requested a review from hub-cap August 4, 2020 07:38
@dliappis dliappis modified the milestones: 2.0.1, 2.0.2 Aug 4, 2020
@hub-cap hub-cap changed the title Warn request errors Warn on request errors Aug 4, 2020
@hub-cap hub-cap merged commit 239af94 into elastic:master Aug 4, 2020
@hub-cap
Copy link
Contributor

hub-cap commented Aug 4, 2020

Thank you for another contribution @bartier !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants