-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on request errors #1035
Warn on request errors #1035
Conversation
@elasticmachine test this please |
Hi, thanks for the PR @bartier . I will be testing and reviewing this next week. I just wanted to drop a comment here so you don't think I've forgotten about you! |
@elasticmachine ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I tested this and it looks great. I was able to hammer a local instance to see it in action. I would like to see the error rate in the warning look like the error rate displayed in the table (the 86.46
vs 0.8646xxxxx
). Other than that small change, I think this is worth merging!
| 100th percentile service time | index-append | 3527.01 | ms |
| error rate | index-append | 86.46 | % |
[WARNING] Error rate is 0.8646496815286624 for operation 'index-append'. Please check the logs.
@hub-cap Thanks! I submitted a code change to round the error rate in the warning message. Could you check again please? |
Thank you for another contribution @bartier !! |
This PR attempts to solve #910