Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on request errors #910

Closed
danielmitterdorfer opened this issue Feb 19, 2020 · 2 comments
Closed

Warn on request errors #910

danielmitterdorfer opened this issue Feb 19, 2020 · 2 comments
Labels
enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution :Usability Makes Rally easier to use
Milestone

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Feb 19, 2020

By default Rally continues on request errors (--on-error=continue) but this might be easy to miss by users. In addition, some operations are treated as "administrative" (e.g. create-index) and are thus not included in the command line report by default. We should:

  1. Include any operations with an error rate greater than zero in the command line report regardless whether they should be included (see
    if task.operation.include_in_reporting:
    )
  2. Emit a warning when the error rate of an operation is greater than zero (in
    def add_warnings(self, warnings, values, op):
    )
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo help wanted We'd be happy about a community contribution :Usability Makes Rally easier to use good first issue Small, contained changes that are good for newcomers labels Feb 19, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.x milestone Feb 19, 2020
@bartier
Copy link
Contributor

bartier commented Jul 27, 2020

@danielmitterdorfer Hi! Can I work on this?

  1. I'd purpose something in the lines:
    if task.operation.include_in_reporting or error_rate > 0
    "Administrative" operations would be in the report if error happens (error_rate > 0)

  2. Add warnings at the end of the command line report:

def add_warnings(self, warnings, values, op):
    if values["error_rate"] > 0:
        warnings.append(f"Error rate is {values['error_rate']} for operation '{op}'. Please check the logs.")
   ...
   ...

@danielmitterdorfer
Copy link
Member Author

@bartier sure, thanks for working on it. :)

I thought about your idea to force-include failed tasks in the report as follows:

 if task.operation.include_in_reporting or error_rate > 0 

and I think that makes sense. Looking forward to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution :Usability Makes Rally easier to use
Projects
None yet
Development

No branches or pull requests

2 participants