Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated properties trial-id and trial-timestamp #777

Closed
danielmitterdorfer opened this issue Sep 27, 2019 · 0 comments · Fixed by #979
Closed

Remove deprecated properties trial-id and trial-timestamp #777

danielmitterdorfer opened this issue Sep 27, 2019 · 0 comments · Fixed by #979
Assignees
Labels
breaking Non-backwards compatible change enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers :Metrics How metrics are stored, calculated or aggregated
Milestone

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Sep 27, 2019

With #778 we deprecate trial-id and trial-timestamp (which are written to rally-* indices in the metrics store) with Rally 1.4.0 in favor of race-id and race-timestamp. There is a BWC layer that allows users to still continue to use these properties but we should clean this up (see TODO #777 comments in the code; in addition all mappings need to be cleaned up).

@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Sep 27, 2019
@danielmitterdorfer danielmitterdorfer added :Metrics How metrics are stored, calculated or aggregated breaking Non-backwards compatible change enhancement Improves the status quo labels Sep 27, 2019
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Sep 27, 2019
With this commit we expose the race id as command line parameter. As the
internal name "trial id" and the related name "trial timestamp" are
inconsistent with this terminology we rename them to "race id" and "race
timestamp" respectively and add a backwards-compatibility layer that
will be removed again in elastic#777.
danielmitterdorfer added a commit that referenced this issue Oct 1, 2019
With this commit we expose the race id as command line parameter. As the
internal name "trial id" and the related name "trial timestamp" are
inconsistent with this terminology we rename them to "race id" and "race
timestamp" respectively and add a backwards-compatibility layer that
will be removed again in #777.

Relates #778
novosibman pushed a commit to novosibman/rally that referenced this issue Oct 2, 2019
With this commit we expose the race id as command line parameter. As the
internal name "trial id" and the related name "trial timestamp" are
inconsistent with this terminology we rename them to "race id" and "race
timestamp" respectively and add a backwards-compatibility layer that
will be removed again in elastic#777.

Relates elastic#778
@danielmitterdorfer danielmitterdorfer added the good first issue Small, contained changes that are good for newcomers label Feb 19, 2020
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 30, 2020
With this commit we remove the properties `trial-id` and
`trial-timestamp` as they have been replaced by `race-id` and
`race-timestamp` in Rally 1.4.0 and were only present for backwards
compatibility.

Closes elastic#777
danielmitterdorfer added a commit that referenced this issue May 4, 2020
With this commit we remove the properties `trial-id` and
`trial-timestamp` as they have been replaced by `race-id` and
`race-timestamp` in Rally 1.4.0 and were only present for backwards
compatibility.

Closes #777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant