Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Elasticsearch 1.x #715

Closed
3 tasks done
danielmitterdorfer opened this issue Jun 17, 2019 · 0 comments · Fixed by #716
Closed
3 tasks done

Drop support for Elasticsearch 1.x #715

danielmitterdorfer opened this issue Jun 17, 2019 · 0 comments · Fixed by #716
Assignees
@danielmitterdorfer
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Track Management New operations, changes in the track format, track download changes and the like
Milestone
1.3.0

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Jun 17, 2019 •
edited
Loading

In order to reduce maintenance effort, we should stop supporting outdated versions of Elasticsearch. Elasticsearch 1.7 is end of life since January 2017 so we will drop support for it. We will take a couple of precautionary measures though:

  • We will give users a clear indication what Rally version supports which Elasticsearch versions (see Document which ES versions are supported by Rally #714)
  • While we will remove the respective branches also from rally-teams and rally-tracks, we will add a tag to effectively "freeze" the latest state. Rally will bring support to detect these tags and use them (see Check tags in track and team repos #713). This will allow users to switch to an older Rally version and still benchmark old Elasticsearch versions.

Additional tasks:

The latter two items have to be implemented by removing the branch 1 in the respective repos and adding a corresponding v1 tag. Contrary to Rally, these changes are live "immediately" and thus would affect users. Therefore, we should aim for a grace period and remove the branches late in the release cycle for Rally 1.3.0.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change labels Jun 17, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.3.0 milestone Jun 17, 2019
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Jun 17, 2019
@danielmitterdorfer
Drop support for Elasticsearch 1.x
e84ac47 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Closes elastic#715
@danielmitterdorfer danielmitterdorfer mentioned this issue Jun 17, 2019
Merged
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Jul 8, 2019
@danielmitterdorfer
Always exit on OOME
696a01e 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
@danielmitterdorfer danielmitterdorfer mentioned this issue Jul 8, 2019
Merged
danielmitterdorfer added a commit that referenced this issue Jul 11, 2019
@danielmitterdorfer
Drop support for Elasticsearch 1.x
2c46267 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates #715
Relates #716
danielmitterdorfer added a commit that referenced this issue Jul 11, 2019
@danielmitterdorfer
Always exit on OOME
72c2481 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in #716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates #715
Relates #723
ebadyano pushed a commit to ebadyano/rally that referenced this issue Jul 16, 2019
@danielmitterdorfer @ebadyano
Drop support for Elasticsearch 1.x
0f456d7 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
ebadyano pushed a commit to ebadyano/rally that referenced this issue Jul 16, 2019
@danielmitterdorfer @ebadyano
Always exit on OOME
28577c6 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @novosibman
Drop support for Elasticsearch 1.x
cee2e0c 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @novosibman
Always exit on OOME
d488ebf 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @ru-az
Drop support for Elasticsearch 1.x
da71e3d 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @ru-az
Always exit on OOME
a0b83dd 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @novosibman
Drop support for Elasticsearch 1.x
51ad1a0 
With this commit we remove support in Rally to benchmark Elasticsearch
1.x.

Relates elastic#715
Relates elastic#716
novosibman pushed a commit to novosibman/rally that referenced this issue Aug 12, 2019
@danielmitterdorfer @novosibman
Always exit on OOME
738953f 
With this commit we add the JVM flag `ExitOnOutOfMemoryError`
unconditionally when Elasticsearch is configured by Rally. Previously we
had to check whether the JVM in use supports this flag because we
supported Elasticsearch 1.x which can be run with Java 1.7. As the JVM flag
has only been introduced with Java 8, we had a check in place. Now that
we have dropped support for Elasticsearch 1.x (in elastic#716), we can safely
assume that the JVM supports this flag and unconditionally set it.

Relates elastic#715
Relates elastic#723
@danielmitterdorfer danielmitterdorfer mentioned this issue Nov 19, 2019
Closed
2 tasks
@danielmitterdorfer danielmitterdorfer self-assigned this Dec 3, 2019
@danielmitterdorfer danielmitterdorfer mentioned this issue Nov 4, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmitterdorfer danielmitterdorfer

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch breaking Non-backwards compatible change enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Drop support for Elasticsearch 1.x danielmitterdorfer/rally
1 participant
@danielmitterdorfer