Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow benchmarking with plugins #60

Closed
6 tasks done
danielmitterdorfer opened this issue Feb 5, 2016 · 0 comments
Closed
6 tasks done

Allow benchmarking with plugins #60

danielmitterdorfer opened this issue Feb 5, 2016 · 0 comments
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo highlight A substantial improvement that is worth mentioning separately in release notes
Milestone

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Feb 5, 2016

Currently we can only provision and benchmark a vanilla Elasticsearch instance but we should be able to benchmark also with specific plugins enabled to determine their performance impact.

For the initial implementation we will not support plugins built from sources and require that they are installed from a plugin repository.

Tasks

  • Enhance the team repository so it contains information about plugins
  • Have the provisioner use this information to install and configure plugins
  • Define and implement the concept of "install hooks" to run arbitrary Python code at defined points in time when installing a plugin (e.g. to configure certificates for x-pack security)
  • Allow to use multiple config bases to avoid bloat and duplication in configs (this allows to run e.g. --elasticsearch-plugins="x-pack:security+graph").
  • Allow to specify explicit download URLs for plugins (e.g. for snapshots). These should be overridable in rally.ini or on the command line
  • Add plugin-metadata to metrics records. Rally will detect installed plugins via the cluster stats API. This allows us to be agnostic of how the plugins got installed (Rally could also be invoked with the pipeline benchmark-only). We will lose some information (e.g. the plugin config that has been used) but if this is important to the user, they can use tags for that.
@danielmitterdorfer danielmitterdorfer changed the title Enable to benchmark with plugins Allow benchmarking with plugins Feb 5, 2016
@danielmitterdorfer danielmitterdorfer added this to the 0.2 milestone Apr 2, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.4.0, 0.3.0 Jun 6, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.0, 0.4.0 Jun 29, 2016
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Oct 12, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.1, 0.5.0, 0.5.2, 0.5.3 Dec 23, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.3, 0.5.4 Mar 3, 2017
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.6.3, 0.6.x Jul 21, 2017
@danielmitterdorfer danielmitterdorfer self-assigned this Jul 21, 2017
@danielmitterdorfer danielmitterdorfer added the highlight A substantial improvement that is worth mentioning separately in release notes label Jul 21, 2017
danielmitterdorfer added a commit that referenced this issue Jul 26, 2017
With this commit we add the ability to install Elasticsearch plugins to
Rally.

Relates #60
@danielmitterdorfer danielmitterdorfer removed their assignment Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo highlight A substantial improvement that is worth mentioning separately in release notes
Projects
None yet
Development

No branches or pull requests

1 participant