Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unique race id #431

Closed
danielmitterdorfer opened this issue Mar 8, 2018 · 0 comments
Closed

Add a unique race id #431

danielmitterdorfer opened this issue Mar 8, 2018 · 0 comments
Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated :misc Changes that don't affect users directly: linter fixes, test improvements, etc. :Reporting Command line reporting
Milestone
0.9.4

Comments

@danielmitterdorfer
Copy link
Member

Currently we use a combination of track, challenge, car and race timestamp to select documents in reporting. We can simplify the code (and also make it more robust) by generating a unique id per race and using that instead.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated :misc Changes that don't affect users directly: linter fixes, test improvements, etc. :Reporting Command line reporting labels Mar 8, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.9.4 milestone Mar 8, 2018
@danielmitterdorfer danielmitterdorfer mentioned this issue Mar 9, 2018
Closed
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Mar 9, 2018
@danielmitterdorfer
Add a unique race id
34e32f1 
With this commit we add a new property 'trial-id' in addition to
'trial-timestamp'. The main reason for this change is that we set the
same effective start date in some environments. If we run the same
combination of track/challenge/car but use track-params or team-params,
Rally will mix up results. If we use a unique id per race, this cannot
happen.

Closes elastic#431
@danielmitterdorfer danielmitterdorfer mentioned this issue Mar 9, 2018
Merged
danielmitterdorfer added a commit that referenced this issue Mar 9, 2018
@danielmitterdorfer
Add a unique race id
ca129a9 
With this commit we add a new property 'trial-id' in addition to
'trial-timestamp'. The main reason for this change is that we set the
same effective start date in some environments. If we run the same
combination of track/challenge/car but use track-params or team-params,
Rally will mix up results. If we use a unique id per race, this cannot
happen.

Closes #431
Relates #433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated :misc Changes that don't affect users directly: linter fixes, test improvements, etc. :Reporting Command line reporting
Projects
None yet
Milestone
0.9.4
Development

No branches or pull requests
1 participant
@danielmitterdorfer