Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esrally fails after initial config run if JDK9 is not installed #423

Closed
danielmitterdorfer opened this issue Mar 1, 2018 · 0 comments
Closed

esrally fails after initial config run if JDK9 is not installed #423

danielmitterdorfer opened this issue Mar 1, 2018 · 0 comments
Assignees
@tomcallahan
Labels
bug Something's wrong :Config Config file format changes, new properties, ...
Milestone
0.9.4

Comments

@danielmitterdorfer
Copy link
Member

Steps to reproduce:

  1. Run esrally configure on a system without JDK 9 (but with Gradle installed)
  2. Run esrally

This will fail with:

"No value for mandatory configuration: section=build, key=gradle.bin"
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Config Config file format changes, new properties, ... labels Mar 1, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.9.4 milestone Mar 1, 2018
tomcallahan added a commit to tomcallahan/rally that referenced this issue Mar 7, 2018
@tomcallahan
Fix misleading error message when gradle is present but jdk9 is not
e8893ba 
Currently when `esrally configure` is run, the gradle binary path is
persisted to rally.ini only if jdk9 is also installed.  However, when
`esrally` is run in benchmark_from_source mode (e.g., no args provided),
the gradle binary path in rally.ini is referenced before any jdk9 checks
take place -- leading to the following message:
`No value for mandatory configuration: section=build, key=gradle.bin`

This commit persists the gradle binary path to rally.ini in any case,
allowing existing logic around jdk9 to emit a sensible error.

Fixes elastic#423
@tomcallahan tomcallahan mentioned this issue Mar 7, 2018
Merged
@tomcallahan tomcallahan self-assigned this Mar 7, 2018
danielmitterdorfer pushed a commit that referenced this issue Mar 9, 2018
@tomcallahan @danielmitterdorfer
Fix misleading error message when gradle is present but jdk9 is not
512e2a0 
Currently when `esrally configure` is run, the gradle binary path is
persisted to rally.ini only if jdk9 is also installed.  However, when
`esrally` is run in benchmark_from_source mode (e.g., no args provided),
the gradle binary path in rally.ini is referenced before any jdk9 checks
take place -- leading to the following message:
`No value for mandatory configuration: section=build, key=gradle.bin`

This commit persists the gradle binary path to rally.ini in any case,
allowing existing logic around jdk9 to emit a sensible error.

Fixes #423
Relates #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomcallahan tomcallahan

Labels
bug Something's wrong :Config Config file format changes, new properties, ...
Projects
None yet
Milestone
0.9.4
Development

No branches or pull requests
2 participants
@danielmitterdorfer @tomcallahan