Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of iterations should be treated per client, not "global" #350

Closed
danielmitterdorfer opened this issue Nov 9, 2017 · 0 comments
Closed
Labels
breaking Non-backwards compatible change bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Milestone

Comments

@danielmitterdorfer
Copy link
Member

Consider the following task:

    {
      "operation": "my-query",
      "clients": 10,
      "iterations": 100
    }

Current behavior: Each client will execute iterations / clients (= 100 / 10) = 10 iterations. This can be sometimes puzzling and is also inconsistent to how we treat time-period. When a user specifies time-period, each client will run for that time period (and not a fraction of it).

New behavior: Each client will execute 100 iterations.

As this behavior may break some benchmarks (by running more iterations than expected) we should check whether there is an easy way to warn users of this new behavior (the warning will be removed after some grace period).

@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. breaking Non-backwards compatible change bug Something's wrong labels Nov 9, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.8.0 milestone Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change bug Something's wrong :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Development

No branches or pull requests

1 participant