Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide number of query hits as metrics metadata #295

Closed
mesfinmulugeta opened this issue Jul 3, 2017 · 2 comments
Closed

Provide number of query hits as metrics metadata #295

mesfinmulugeta opened this issue Jul 3, 2017 · 2 comments
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Metrics How metrics are stored, calculated or aggregated
Milestone

Comments

@mesfinmulugeta
Copy link

Currently Rally provides "number of hits" only when running scroll queries (where you provide values to the pages and result-per-page properties in the search benchmark). "Number of hits" isn't provided when running non-scroll queries. "Number of hits" is a very useful result that we can use to validate the result. To just give one example, when performing benchmarking using Rally, I ran into issues where the error rate was 0% in the benchmark result, but there was issue on my query benchmark. If I had the number of hits information in the result, I could have immediately identified that there was issue with my query.

See also https://discuss.elastic.co/t/number-of-hits-when-running-non-scroll-queries/91660

@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Metrics How metrics are stored, calculated or aggregated enhancement Improves the status quo labels Jul 3, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.6.1 milestone Jul 3, 2017
@cdahlqvist
Copy link
Contributor

It would be good if this could be enabled/disabled, e.g. in a similar way to how detailed stats are handled for bulk requests.

@danielmitterdorfer
Copy link
Member

Contrary to bulk requests determining the number of hits has practically zero overhead (I've benchmarked it). It's only reading a single number from a Python dict. Hence I'd just include it per default for the moment.

If we should gather more meta-data in the future, I totally agree that we should not enable it by default then and allow users to provide a flag in the track whether they want detailed statistics or not.

@danielmitterdorfer danielmitterdorfer changed the title Provide the option to get number of hits when running search benchmark Provide number of query hits as metrics metadata Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

No branches or pull requests

3 participants