Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rally checks for internet connection even when it's not needed #1506

Closed
j-bennet opened this issue May 31, 2022 · 0 comments · Fixed by #1517
Closed

Rally checks for internet connection even when it's not needed #1506

j-bennet opened this issue May 31, 2022 · 0 comments · Fixed by #1517
Assignees
Labels
enhancement Improves the status quo help wanted We'd be happy about a community contribution
Milestone

Comments

@j-bennet
Copy link
Contributor

j-bennet commented May 31, 2022

Rally version (get with esrally --version): 2.5.0.dev0

Description of the problem including expected versus actual behavior:

Rally unnecessarily checking Internet connection for commands such as:

  • list [races|other things]
  • compare --baseline x --contender y
  • generate [charts]
  • possibly others?

Steps to reproduce:

Simulate being offline by providing an invalid proxy URL. Invoke a command that should work offline:

http_proxy=http://invalid esrally list races

Observe a warning:

[WARNING] No Internet connection detected.

This check should only apply to commands that need internet connection.

@j-bennet j-bennet added the enhancement Improves the status quo label May 31, 2022
@pquentin pquentin added the help wanted We'd be happy about a community contribution label Jun 1, 2022
@pquentin pquentin added this to the Backlog milestone Jun 1, 2022
@j-bennet j-bennet self-assigned this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo help wanted We'd be happy about a community contribution
Projects
None yet
2 participants