Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support Elasticsearch 5 as metrics store #138

Closed
danielmitterdorfer opened this issue Aug 24, 2016 · 4 comments
Closed

Improve support Elasticsearch 5 as metrics store #138

danielmitterdorfer opened this issue Aug 24, 2016 · 4 comments
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Milestone

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Aug 24, 2016

While Rally's mapping for the metrics store currently works also with ES 5 due to backwards compatibility features (string / not_analyzed is automatically converted to keyword), we should natively support it as this feature in ES will likely be removed at some point.

@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Metrics How metrics are stored, calculated or aggregated labels Aug 24, 2016
@danielmitterdorfer danielmitterdorfer added this to the 0.4.1 milestone Aug 24, 2016
@jpountz
Copy link
Contributor

jpountz commented Aug 24, 2016

I'm curious which API break is responsible for the fact that it does not work with 5.0?

@danielmitterdorfer
Copy link
Member Author

@jpountz I worried about the use of string/ not_analyzed instead of keyword. I've just tried it with ES 5.0 alpha3 and it works due to a fallback that auto-converts these fields automatically to keyword. So I'll relabel it as an enhancement because this auto-conversion will be removed at some point in ES.

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo and removed bug Something's wrong labels Aug 24, 2016
@danielmitterdorfer danielmitterdorfer changed the title Support Elasticsearch 5 as metrics store Improve support Elasticsearch 5 as metrics store Aug 24, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: Backlog, 0.4.1 Aug 24, 2016
@jpountz
Copy link
Contributor

jpountz commented Aug 24, 2016

Thanks! The auto conversion should be removed in 6.0 indeed.

@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.1, Backlog Aug 24, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.4.5, 0.5.1 Nov 7, 2016
@danielmitterdorfer danielmitterdorfer modified the milestones: Backlog, 0.5.1 Jan 24, 2017
@danielmitterdorfer danielmitterdorfer added the breaking Non-backwards compatible change label May 5, 2017
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.5.4, Backlog May 5, 2017
@danielmitterdorfer
Copy link
Member Author

As we'll change the metrics store structure in #279 anyway and Elasticsearch 5.0 is now out for quite some time, we should target this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Development

No branches or pull requests

2 participants