Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use milliseconds instead of microseconds for relative time #1198

Closed
4 tasks done
dliappis opened this issue Feb 24, 2021 · 0 comments
Closed
4 tasks done

Use milliseconds instead of microseconds for relative time #1198

dliappis opened this issue Feb 24, 2021 · 0 comments
Assignees
@danielmitterdorfer
Labels
breaking Non-backwards compatible change enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :Metrics How metrics are stored, calculated or aggregated
Milestone
2.x

Comments

@dliappis
Copy link
Contributor

dliappis commented Feb 24, 2021 •
edited by danielmitterdorfer
Loading

When using an Elasticsearch metrics store, metrics stored in rally-metrics contain a relative-time key in every record (as this starts from 0 it's useful for comparisons).
The unit of this metric is μs (microseconds) and as such unnecessarily granular and trappy in visualizations and data analysis.

We should change this to ms (milliseconds).

As per #1221 the schedule is:
@dliappis dliappis added enhancement Improves the status quo :Metrics How metrics are stored, calculated or aggregated labels Feb 24, 2021
@dliappis dliappis added this to the 2.1.0 milestone Feb 24, 2021
@danielmitterdorfer danielmitterdorfer added the breaking Non-backwards compatible change label Feb 24, 2021
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Mar 26, 2021
@danielmitterdorfer
Store relative-time in milliseconds
b159d61 
Previously `relative-time` has denoted the relative time in microseconds
since the start of a task. This is inconvenient as all other times are
denoted in milliseconds. Therefore, we will migrate this field to be
denoted in milliseconds as well. In the first step we deprecate the
current field and introduce a new field `relative-time-ms` that is used
for the transition period.

Relates elastic#1198
This was referenced Mar 26, 2021
Merged
Merged
dliappis pushed a commit that referenced this issue Mar 29, 2021
@danielmitterdorfer
Store relative-time in milliseconds (#1221)
894eca4 
Previously `relative-time` has denoted the relative time in microseconds
since the start of a task. This is inconvenient as all other times are
denoted in milliseconds. Therefore, we will migrate this field to be
denoted in milliseconds as well. In the first step we deprecate the
current field and introduce a new field `relative-time-ms` that is used
for the transition period.

Relates #1198
@dliappis dliappis added the meta A high-level issue of a larger topic which requires more fine-grained issues / PRs label Mar 31, 2021
@ebadyano ebadyano modified the milestones: 2.1.0, 2.2.0 Mar 31, 2021
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 6, 2021
@danielmitterdorfer
Drop relative-time metric
5a57b83 
With this commit we drop the metric `relative-time` which contained a
timestamp in microseconds relative to the start of a task. It is
superseeded by the metric `relative-time-ms` which has been introduced
for a transition period between Rally 2.1.0 and Rally 2.3.0. With Rally
2.4.0 we will align all time-related metrics to be denoted in
milliseconds.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer mentioned this issue Apr 6, 2021
Merged
@danielmitterdorfer danielmitterdorfer modified the milestones: 2.2.0, 2.x Apr 6, 2021
danielmitterdorfer added a commit that referenced this issue Apr 12, 2021
@danielmitterdorfer
Drop relative-time metric (#1231)
e7a20e7 
With this commit we drop the metric `relative-time` which contained a
timestamp in microseconds relative to the start of a task. It is
superseeded by the metric `relative-time-ms` which has been introduced
for a transition period between Rally 2.1.0 and Rally 2.3.0. With Rally
2.4.0 we will align all time-related metrics to be denoted in
milliseconds.

Relates #1198
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue May 26, 2021
@danielmitterdorfer
Re-introduce relative-time property
c46c4b5 
With this commit we introduce the property `relative-time` for metrics
documents again. Contrary to Rally versions prior to 2.1.0, this
property contains the relative time since Rally started execution of a
task denoted in milliseconds, instead of microseconds. We also
deprecate the ancillary property `relative-time-ms` which will be
dropped in the next minor release in favor of `relative-time`.

Relates elastic#1198
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue May 28, 2021
@danielmitterdorfer
Re-introduce relative-time property
f2bac95 
With this commit we introduce the property `relative-time` for metrics
documents again. Contrary to Rally versions prior to 2.1.0, this
property contains the relative time since Rally started execution of a
task denoted in milliseconds, instead of microseconds. We also
deprecate the ancillary property `relative-time-ms` which will be
dropped in the next minor release in favor of `relative-time`.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer mentioned this issue May 28, 2021
Merged
danielmitterdorfer added a commit that referenced this issue Jun 7, 2021
@danielmitterdorfer
Re-introduce relative-time property (#1273)
dc66d00 
With this commit we introduce the property `relative-time` for metrics
documents again. Contrary to Rally versions prior to 2.1.0, this
property contains the relative time since Rally started execution of a
task denoted in milliseconds, instead of microseconds. We also
deprecate the ancillary property `relative-time-ms` which will be
dropped in the next minor release in favor of `relative-time`.

Relates #1198
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Jun 24, 2021
@danielmitterdorfer
Drop relative-time-ms metric
cb5140f 
With this commit we drop the metric `relative-time-ms` which we have
introduced for a transition period. This property is superseded by
`relative-time` which contains the same value.

Relates elastic#1198
@danielmitterdorfer danielmitterdorfer mentioned this issue Jun 24, 2021
Merged
pquentin pushed a commit to pquentin/rally that referenced this issue Jun 30, 2021
@danielmitterdorfer @pquentin
Drop relative-time-ms metric
6e4c9a2 
With this commit we drop the metric `relative-time-ms` which we have
introduced for a transition period. This property is superseded by
`relative-time` which contains the same value.

Relates elastic#1198
danielmitterdorfer added a commit that referenced this issue Jul 5, 2021
@danielmitterdorfer
Drop relative-time-ms metric (#1291)
b476261 
With this commit we drop the metric `relative-time-ms` which we have
introduced for a transition period. This property is superseded by
`relative-time` which contains the same value.

Relates #1198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmitterdorfer danielmitterdorfer

Labels
breaking Non-backwards compatible change enhancement Improves the status quo meta A high-level issue of a larger topic which requires more fine-grained issues / PRs :Metrics How metrics are stored, calculated or aggregated
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
3 participants
@danielmitterdorfer @dliappis @ebadyano