Adds field-caps non empty field task in the many-shards-quantitative challenge #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,5 +84,6 @@ | |||
| } | |||
| }, | |||
| {% include "tasks/field-caps.json" %} | |||
There was a problem hiding this comment.
You'll need a comma at the end of this line to maintain valid json
|
One more thing, you mention its a new feature - what release will this be available in? We will need to make sure it doesnt get backported to tags for track versions that don't support it |
|
@gareth-ellis it is in main now and will be available from 8.13 onwards. How do I avoid for it to be back-ported to tags before < 8.13? |
|
I'd misremembered, we backport changes that will work with older versions, if it won't work, then we don't need to worry. It's useful that the information is in the PR at least for future reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we added a new optional query parameter to the _field_caps API in order to
filter out fields with no values. The parameter is called
include_empty_fieldsanddefaults to true, and if set to false it will filter out from the field_caps response all the
fields that has no value in the index. With this PR we want to benchmark this change
by adding a new task to the many-shard-quantitative challenge.
relates to: elastic/elasticsearch#103651