Support DLM/ILM conditional for auditbeat templates #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Thanks! LGTM.
It would have been nice to turn this into a single composable template as in #406 to make future changes easier, such as using build_flavor to determine the correct settings automatically, but I suppose it's not possible given the lifecycle name differs in ILM.
inqueue
pushed a commit
to inqueue/rally-tracks
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#406 introduced DLM support for the
elastic/logstrack, but the auditbeat templates still have ILM policies defined, which will fail when ran against serverless Elasticsearch.