-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of the wikipedia dataset + creating the track. #429
Conversation
46eb748
to
e3550e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This is phenomenally good and well polished work.
I left a few comments, mainly documenting all the track parameters and the use of random.
Co-authored-by: Dimitrios Liappis <[email protected]>
Co-authored-by: Dimitrios Liappis <[email protected]>
- compile query cleaning regexp - make the number of search iterations configurable (higher by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
def params(self): | ||
result = { | ||
"body": {"query": {"query_string": {"query": next(self._queries_iterator), "default_field": self._params["search-fields"]}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a multi-match query to avoid the reserved keywords (and, or, ...)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do this in a follow-up. We still have few run to do and I would prefer to keep the same query for now to get comparable results.
The changes in this PR is related to creating wikipedia dataset and a rally track for the benchmarking stateful and serverless environments.