Add arch specific build commands #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
approved these changes
Sep 14, 2022
7.8 is when we introduced ARM support, though the actual Apple ARM support was released in 7.16. I think backporting to 7.17 is far enough, no need to cut a new branch. |
b-deam
added a commit
that referenced
this pull request
Sep 15, 2022
With the introduction of a specific build subcommand in Rally we require arch specific build commands and artifact paths.
b-deam
added a commit
to elastic/rally
that referenced
this pull request
Sep 28, 2022
Because TemplateRenderer.arch defaults to the arch of the system invoking the tests, when invoked on an aarch64 system, the various Car instances would throw exceptions 1 because they were missing the architecture specific build commands added in elastic/rally-teams#75 This commit fixes the existing tests to default to x86_64, and adds two new aarch64 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of a specific
buildsubcommand in Rally we require arch specific build commands and artifact paths.Relates elastic/rally#1576