Prepare release 3.2.0 #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Jun 18, 2024
| @@ -32,7 +32,7 @@ spec: | |||
| - dependencies | |||
| # JSON patches for newer versions should be placed on top | |||
| versions: | |||
| - before: 3.2.0 | |||
| - before: 3.1.3 | |||
There was a problem hiding this comment.
mrodm
commented
Jun 18, 2024
Comment on lines
29
to
30
| compliance_test 8.14.1-SNAPSHOT 3.2.0 | ||
| compliance_test 8.14.0 3.2.0 |
There was a problem hiding this comment.
Should we use other versions or add a new compliance test to keep 3.1.5 ?
There was a problem hiding this comment.
Currently , package log_synthetic_mode fails with these versions with the following error:
Error: can't install the package: could not zip-install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"illegal_argument_exception\n\tRoot causes:\n\t\tillegal_argument_exception: field [decision_id] of type [text] doesn't support synthetic source unless it is stored or has a sub-field of type [keyword] with doc values or stored and without a normalizer"}
1 task
mrodm
commented
Jun 18, 2024
| @@ -10,7 +10,7 @@ categories: | |||
| - custom | |||
| conditions: | |||
| kibana: | |||
| version: "^8.13.2" | |||
There was a problem hiding this comment.
Requires at least 8.15.0 stack version
mrodm
commented
Jun 18, 2024
Comment on lines
+7
to
+16
| if [[ "${CI:-"false"}" == "true" ]]; then | ||
| source .buildkite/scripts/install_deps.sh | ||
| add_bin_path | ||
|
|
||
| echo "--- Install Go :go:" | ||
| with_go | ||
| echo "--- Install Go :go:" | ||
| with_go | ||
|
|
||
| echo "--- Install docker-compose" | ||
| with_docker_compose | ||
| echo "--- Install docker-compose" | ||
| with_docker_compose | ||
| fi |
There was a problem hiding this comment.
Adding this, it can be used this same script locally to test
# some tests require to run from a fresh stack
elastic-package stack down -v
.buildkite/scripts/run-installer-compliance.sh 8.15.0-SNAPSHOT 3.2.0
mrodm
commented
Jun 18, 2024
Comment on lines
29
to
30
| ## Requires changes in elastic-package to be able to test log_synthetic_mode test package | ||
| # compliance_test 8.15.0-SNAPSHOT 3.2.0 |
There was a problem hiding this comment.
This could be enabled once a new elastic-package version is released with this change
elastic/elastic-package#1914
jsoriano
previously approved these changes
Jun 18, 2024
| @@ -32,7 +32,7 @@ spec: | |||
| - dependencies | |||
| # JSON patches for newer versions should be placed on top | |||
| versions: | |||
| - before: 3.2.0 | |||
| - before: 3.1.3 | |||
Comment on lines
29
to
30
| ## Requires changes in elastic-package to be able to test log_synthetic_mode test package | ||
| # compliance_test 8.15.0-SNAPSHOT 3.2.0 |
There was a problem hiding this comment.
Could we comment out or skip (not sure if there was something to skip) the feature giving problems? This way we could test the rest of cases with 8.15.
There was a problem hiding this comment.
I've tried to add support to skip scenarios using a new tag @skip in the required scenario.
The steps are shown as skipped but the scenario is shown as PASSED
6 scenarios (6 passed)
18 steps (15 passed, 3 skipped)
1m12.182607792s
--- PASS: TestSpecCompliance (72.20s)
--- PASS: TestSpecCompliance/Integration_package_can_be_installed (15.27s)
--- PASS: TestSpecCompliance/Input_package_can_be_installed (15.02s)
--- PASS: TestSpecCompliance/Package_uses_the_"counted_keyword"_type (14.01s)
--- PASS: TestSpecCompliance/Installer_leverages_runtime_parameter (14.01s)
--- PASS: TestSpecCompliance/Installer_leverages_subobjects_false (13.87s)
--- PASS: TestSpecCompliance/Installer_leverages_source_true (0.00s)
PASS
ok github.com/elastic/package-spec/compliance 72.914s
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Jun 19, 2024
| @@ -12,6 +12,8 @@ cat <<EOF | |||
| command: ".buildkite/scripts/run-installer-compliance.sh ${stack_version} ${spec_version}" | |||
| artifact_paths: | |||
| - compliance/report-*.xml | |||
| env: | |||
| ELASTIC_PACKAGE_CHECK_UPDATE_DISABLED: "true" | |||
| return ctx, godog.ErrSkip | ||
| } | ||
| return ctx, nil | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the changelog for the release 3.2.0
Updated compliance tests to start testing spec version 3.2.0 too. Required to add support to skip tests using a new tag
@skip.