Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Support stored scripts in Fleet packages #202

Open
Tracked by #370
ajosh0504 opened this issue Jul 30, 2021 · 7 comments
Open
Tracked by #370

[Discuss] Support stored scripts in Fleet packages #202

ajosh0504 opened this issue Jul 30, 2021 · 7 comments
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team

Comments

@ajosh0504
Copy link

ajosh0504 commented Jul 30, 2021

package-spec currently only supports inline scripts. Larger, more sophisticated scripts tend to be used as stored scripts instead of inline. Stored scripts are also known to reduce compilation time. This issue is to discuss if loading stored scripts should be supported in package-spec.

cc: @ruflin

@ajosh0504 ajosh0504 added the discuss Issue needs discussion label Jul 30, 2021
@ruflin
Copy link
Contributor

ruflin commented Aug 2, 2021

Is it correct to assume that a single stored script always belongs to a single ingest pipeline? Today we version ingest pipelines so I would assume we would also version the stored scripts attached to it. As the stored script is a reference in the ingest pipeline, it would mean on installation we have to adjust this reference. On upgrade, the stored script would have to be put in place first, the ingest pipeline as otherwise reference would not work yet.

@ruflin ruflin added the Team:Integrations Label for the Integrations team label Aug 2, 2021
@ajosh0504
Copy link
Author

I'm not sure the assumption that a stored script belongs to a single ingest pipeline is right? I have worked on cases where the same script is shared but multiple ingest pipelines.

@peteharverson
Copy link

Note that two integrations PRs currently being worked on to package up ML supervised models and anomaly detection jobs for security use cases - Problem Child (elastic/integrations#2115) and DGA (elastic/integrations#2352), are having to include large inline scripts as part of inference and ingest pipeline definitions. As suggested by @ajosh0504 , it would be nice if packages supported stored scripts, rather than having to include them as part of the pipelines.

@ruflin ruflin added the Team:Ecosystem Label for the Packages Ecosystem team label Jan 10, 2022
@ruflin
Copy link
Contributor

ruflin commented Jan 10, 2022

@mtojek @jsoriano Would be great to get your input / thoughts on this topic.

@ruflin ruflin removed the Team:Integrations Label for the Integrations team label Jan 10, 2022
@jsoriano
Copy link
Member

+1, I think it would make sense to allow to include stored scripts on packages. It would also make sense to allow using them on different pipelines, while these pipelines belong to the same package. We don't support at the moment inter-package dependencies.

@SourinPaul
Copy link

Just giving it a friendly 👍 bump.

This came up during our conversations today re: adding transform to spec

As mentioned above, we need the ability to support stored scripts for most transform-based packages.

@szeitlin
Copy link

Do we think this is going to get on the roadmap in 2023-?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

No branches or pull requests

6 participants