Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] Limited packages & multiple policy templates #155

Open
jen-huang opened this issue Mar 30, 2021 · 2 comments
Open

[discuss] Limited packages & multiple policy templates #155

jen-huang opened this issue Mar 30, 2021 · 2 comments
Labels
discuss Issue needs discussion

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Mar 30, 2021

Hi, last year we introduced a field, policy_templates.[0].multiple: boolean, that lets Kibana know whether a package can be configured for an agent policy more than once or not: elastic/package-registry#350

This flag is currently in effect for endpoint (that is, Endpoint package can only be added once to an agent policy) and, AFAIK, no others. Now that packages can have multiple policy_templates (#137), I'd like to discuss whether this flag still makes sense at the policy template level, or if we should consider moving it to the package level.

My preference is to move it to the package level, semantically that makes more sense to me with the original intention of this field, but I realize that this might change now with packages exporting multiple integrations. Do we foresee a use case where we will want to apply this restriction at the policy template/integration level?

@jen-huang jen-huang added the discuss Issue needs discussion label Mar 30, 2021
@ycombinator
Copy link
Contributor

@ruflin
Copy link
Contributor

ruflin commented Mar 31, 2021

Makes sense on the package level. If we later need it per integration, we can introduce it there too. At the moment my assumption is, if it is set on the package level, it applies to all templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants