-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPR returns almost no packages when kibana.version
of 9.0.0
is provided
#1226
Comments
After chatting with Mario, this is working as designed.
This has to be requested to all packages owners. @kpollich is this something you can take care of? It has to be done before 9.0 public release. |
Can we just open a PR making this change this for every package? Then package owners can tell us explicitly which packages should not have a ^9.0 constraint, if any? Potentially also there should be a lint rule that warns if you are not compatible with the latest stack version, since except for packages being actively deleted or deprecated that should always be the case. If I look at the Elastic Agent package for example it is missing an explicit opt in to 9.0. https://github.com/elastic/integrations/blob/8711ef8d8e85c7c9288cc8d8140c68b4d04cad6a/packages/elastic_agent/manifest.yml#L9-L10 |
You mean automatically create a PR that will add this constraint for all packages? |
I think this is potentially a bit of an overreach on our part, but also I think package maintainers will simply move too slowly unless we do this (see secrets). Coordinating config changes across all integration maintainers has historically been a slow and painful process. I'm +1 on creating a PR that bumps every package, except for those that are formally deprecated. For deprecated packages we should give the maintainers a chance to confirm whether the packages should continue to be installable in 9.0.
This would be a good enhancement and should be relatively easy to add. |
For next steps, I propose the following:
There is a small potential for packages to regress in 9.0 due to underlying breaking changes in Elasticsearch mappings/settings, Kibana dashboard behavior, etc, but I strongly doubt we'll have any cases of this. |
Not sure about this. Developers/teams cannot test the packages they own with a 9.0.0 stack. So they would not know if the package (as it is) it is supported there. First, it would be needed to prepare at least the CI pipelines of the integrations repository to at least be ready to test with that stack (maybe daily?). About not to update deprecated packages, AFAIK currently there is no way (in the spec) to mark a package as deprecated. So not really sure, which ones should be considered as deprecated (elastic/package-spec#227). |
Yes, let's make sure we have the ability to test packages against the 9.0 version of the stack both via
You're right - we don't support this today, e.g. elastic/package-spec#227 |
This won't be possible before the next unified release and once this is done anyone testing 9.0 won't have any package so it is probably worth sending out a communication about this caveat and the fact that we are working on a resolution. Thoughts? |
I think this is okay from the integration maintainer standpoint. What we need to be able to do is run |
Related to this item, what would be the elastic-agent docker image to be released in 9.0? Maybe this also requires changes in As it is now, elastic-package will try to run in the stack |
In 9.0 wolfi will became the default and ubuntu images will be removed so it will be rolled back to |
We have to be cautious with this. If we release GA packages with 9.x support now, and a breaking change that affects packages is merged in the stack before the feature freeze, we will have broken packages. So I recommend holding on that till the feature freeze or a close date. In the meantime we can use other approaches like disabling this constraint in kibana 9.0 snapshots. |
This makes sense to me. It sounds like we should simply remove the version gating from |
@jsoriano - I think we are in an okay spot with this now, but we will need to think more about long-term fixes for 9.0 here as discussed. I'm assigning this to you. Could you provide a summary of where we are today and what needs to be done next at this point? I think reaching out to package maintainers to start adding conditions for 9.0 to packages is next up, but not sure if we need to discuss further. |
We shouldn't add 9.0 conditions till we have more certainty on breaking changes in the stack that might affect packages. I would wait till some weeks before the FF to start adding conditions. I would think on a plan like the following one:
We could also think on continuing with the plan to remove kibana version constraints, and rely only on spec versions and capabilities, as we already do in serverless. This plan should take into account that we still have to support versions of the stack that don't know anything about spec constraints, but maybe we could handle their behaviour from the registry. If we go this way, then the plan becomes:
|
I think this issue can be closed as the issue was found and addressed. We have internal issues to keep track of the pending changes in adaptation for 9.0. Please reopen if something else is needed now. |
When the Kibana version if
9.0.0
, almost no packages are returned by EPR, e.g.https://epr.elastic.co/search?kibana.version=9.0.0
This request only returns the custom logs integration. Adding
&prerelease=true
makes more packages show up, but it's not much better.This is blocking Kibana's setup process for the 9.0.0 branch, and version constraints should be permitting 9.0.0 for the Kibana version and showing packages as normal.
Tasks
elastic-package
can be used to test integrations against the Elastic stack running on9.0.0
(blocked by Update version to 9.0.0 kibana#192040 and availability of 9.0 snapshots): Add initial support for Elastic Stack 9.x elastic-package#21029.0.0
stack version [CI] Add support for running tests with stack 9.0.0 integrations#11138kibana.version
constraint to include|| ^9.0.0
elastic-packages@
notifying package maintainers of the PR above. Set a TTL after which the PR will be merged and all bumped packages will become visible + installable in9.0.0
stacks.The text was updated successfully, but these errors were encountered: