Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bytes formatter, support bits formatting #14

Closed
wylieconlon opened this issue Jan 30, 2020 · 1 comment
Closed

Update bytes formatter, support bits formatting #14

wylieconlon opened this issue Jan 30, 2020 · 1 comment

Comments

@wylieconlon
Copy link

wylieconlon commented Jan 30, 2020 •
edited
Loading

I've just found these bug reports/feature requests for Kibana, and want to make sure we're tracking them here.

elastic/kibana#7892
elastic/kibana#7543

For bytes, the actionable thing is to display KiB and MiB, etc suffixes when using the b formatter, instead of KB and MB. This diverges from the choice that was made in the core numeral-js library here, where the author chose to make two changes (one breaking) instead of one change: adamwdraper#388

Proposal:

  • Fix the bug in the b formatter by replacing suffixes
  • Introduce another formatter for base-1000 bytes (KB, MB, etc) which has a different name than the numeral formatter. Proposal: bd for "bytes decimal"
  • Create a github-pages documentation website for our fork to distinguish the formatters.
@wylieconlon wylieconlon mentioned this issue Jan 30, 2020
Closed
@wylieconlon
Copy link
Author

PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wylieconlon