Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit LS' Java (collection) integration patches #12800

Closed
kares opened this issue Apr 7, 2021 · 0 comments
Closed

revisit LS' Java (collection) integration patches #12800

kares opened this issue Apr 7, 2021 · 0 comments

Comments

@kares
Copy link
Contributor

kares commented Apr 7, 2021

at this point LS likely relies on some of the patches such as being able to + on java.util.List instances (just like one can + Ruby arrays). however, some of the patches might be supported by JRuby natively.
(also JRuby 9.3 should introduce native support for inspect-ing Java types such as collections)

the patches should work with Ruby extended Java classes such as this one, atm coll#inspect fails:
TypeError: no implicit conversion of LogStash::Outputs::TestSink::Queue into Array
(from org/logstash/RubyJavaIntegration.java:218:in inspect'`)

HINT: JRuby 9.3 should provide inspect for all Java collection types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant