Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch license checking from _xpack to _license #11382

Closed
jsvd opened this issue Dec 3, 2019 · 3 comments
Closed

Switch license checking from _xpack to _license #11382

jsvd opened this issue Dec 3, 2019 · 3 comments

Comments

@jsvd
Copy link
Member

jsvd commented Dec 3, 2019

License checking should use the /_license endpoint instead of /_xpack, which is what we do now: https://github.com/elastic/logstash/blob/master/x-pack/lib/license_checker/license_reader.rb#L29

@kaisecheng
Copy link
Contributor

/_license cannot replace /_xpack because /_xpack provide extra information to tell if elasticsearch enable "security", "logstash", "monitoring".
Elasticsearch team has no plan to deprecate /_xpack, so Logstash is safe to keep it as is

@kaisecheng
Copy link
Contributor

reopen to get feedback from @jsvd

@kaisecheng kaisecheng reopened this Nov 16, 2020
@jsvd
Copy link
Member Author

jsvd commented Nov 24, 2020

The initial intent was to remove all mentions of xpack (other than file paths) as we move towards 8.0.

Since ES is keeping the xpack endpoint to provide information about which non-oss features exist/are enabled then this issue is not valid anymore.

We may need to reopen it in the past if:
a) the _xpack endpoint feature content is moved to a dedicated telemetry endpoint
b) the license data in the _xpack endpoint is removed and kept only in _license, causing is to have to execute two requests.

@jsvd jsvd closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants