Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] remove test warnings about improper HTML structure #79251

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Oct 2, 2020

Summary

Removes the warnings from the console when workspace_panel tests are running:
image

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.10.0 labels Oct 2, 2020
@mbondyra mbondyra requested a review from a team October 2, 2020 06:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in firefox and still works fine, LGTM.

Not sure about proper semantic page structure.

@mbondyra
Copy link
Contributor Author

mbondyra commented Oct 2, 2020

I'll ask @cchaos! Thanks @flash1293 :)

@mbondyra mbondyra requested a review from cchaos October 2, 2020 13:14
@mbondyra mbondyra force-pushed the fix_tests_warnings branch from 76e0bfb to 55f7806 Compare October 2, 2020 13:30
@cchaos
Copy link
Contributor

cchaos commented Oct 2, 2020

I'm not sure what the question for me is, but I don't see any semantic changes in this PR. I'm simply seeing a change from using <FormattedMessage> to i18n.translate(). The error message you are showing in the summary of the PR has to do with how EuiIcon renders in snapshots only (not the actual rendered DOM). EuiIcon is mocked to return a <div> in snapshots while they render as <svg> in the DOM.

This had tripped me up as well thinking EuiIcon was always rendering div's. I already have an issue for this open in EUI. elastic/eui#3758

@flash1293
Copy link
Contributor

Right, I misread the diff - should be fine

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 1010.4KB 1010.2KB -253.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit fccfad2 into elastic:master Oct 2, 2020
@mbondyra mbondyra deleted the fix_tests_warnings branch October 2, 2020 15:18
mbondyra added a commit to mbondyra/kibana that referenced this pull request Oct 2, 2020
)

* [Lens] remove test warnings about improper HTML structure
mbondyra added a commit that referenced this pull request Oct 2, 2020
…79306)

* [Lens] remove test warnings about improper HTML structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants