-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] remove test warnings about improper HTML structure #79251
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in firefox and still works fine, LGTM.
Not sure about proper semantic page structure.
I'll ask @cchaos! Thanks @flash1293 :) |
76e0bfb
to
55f7806
Compare
I'm not sure what the question for me is, but I don't see any semantic changes in this PR. I'm simply seeing a change from using This had tripped me up as well thinking EuiIcon was always rendering div's. I already have an issue for this open in EUI. elastic/eui#3758 |
Right, I misread the diff - should be fine |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
Summary
Removes the warnings from the console when workspace_panel tests are running: