From 52bbbfff655bbe5c23dfc2c4e45e19c67ee90c40 Mon Sep 17 00:00:00 2001 From: Stratoula Kalafateli Date: Tue, 7 Jul 2020 15:58:36 +0300 Subject: [PATCH 1/2] fixes the flakiness on hybrid visualization test --- test/functional/page_objects/visualize_page.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/functional/page_objects/visualize_page.ts b/test/functional/page_objects/visualize_page.ts index 49133d8b13836..24ac1471ed0e1 100644 --- a/test/functional/page_objects/visualize_page.ts +++ b/test/functional/page_objects/visualize_page.ts @@ -257,8 +257,10 @@ export function VisualizePageProvider({ getService, getPageObjects }: FtrProvide public async openSavedVisualization(vizName: string) { const dataTestSubj = `visListingTitleLink-${vizName.split(' ').join('-')}`; - await testSubjects.click(dataTestSubj); - await header.waitUntilLoadingHasFinished(); + await retry.try(async () => { + await testSubjects.click(dataTestSubj); + await header.waitUntilLoadingHasFinished(); + }); } public async waitForVisualizationSavedToastGone() { From 330935dcb333dcc175927aff8102617a1f7f7a37 Mon Sep 17 00:00:00 2001 From: Stratoula Kalafateli Date: Wed, 8 Jul 2020 09:58:45 +0300 Subject: [PATCH 2/2] increase timeout to 20 sec to find and click the hybrid visualization --- test/functional/page_objects/visualize_page.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/functional/page_objects/visualize_page.ts b/test/functional/page_objects/visualize_page.ts index 24ac1471ed0e1..a08598fc42d68 100644 --- a/test/functional/page_objects/visualize_page.ts +++ b/test/functional/page_objects/visualize_page.ts @@ -257,10 +257,8 @@ export function VisualizePageProvider({ getService, getPageObjects }: FtrProvide public async openSavedVisualization(vizName: string) { const dataTestSubj = `visListingTitleLink-${vizName.split(' ').join('-')}`; - await retry.try(async () => { - await testSubjects.click(dataTestSubj); - await header.waitUntilLoadingHasFinished(); - }); + await testSubjects.click(dataTestSubj, 20000); + await header.waitUntilLoadingHasFinished(); } public async waitForVisualizationSavedToastGone() {