').css({
+ let $parent = $('
').css({
position: 'fixed',
top: 0,
left: 0,
@@ -30,12 +30,12 @@ describe('FixedScroll directive', function () {
$parent.appendTo(document.body);
trash.push($parent);
- var $el = $('').css({
+ let $el = $('').css({
'overflow-x': 'auto',
'width': $parent.width()
}).appendTo($parent);
- var $content = $('
').css({
+ let $content = $('
').css({
width: $parent.width() * ratioX,
height: $parent.height() * ratioY
}).appendTo($el);
@@ -59,7 +59,7 @@ describe('FixedScroll directive', function () {
});
it('does nothing when not needed', function () {
- var els = compile(0.5, 1.5);
+ let els = compile(0.5, 1.5);
expect(els.$scroller).to.have.length(0);
els = compile(1.5, 0.5);
@@ -67,26 +67,26 @@ describe('FixedScroll directive', function () {
});
it('attaches a scroller below the element when the content is larger then the container', function () {
- var els = compile(1.5);
+ let els = compile(1.5);
expect(els.$scroller).to.have.length(1);
});
it('copies the width of the container', function () {
- var els = compile(1.5);
+ let els = compile(1.5);
expect(els.$scroller.width()).to.be(els.$container.width());
});
it('mimics the scrollWidth of the element', function () {
- var els = compile(1.5);
+ let els = compile(1.5);
expect(els.$scroller.prop('scrollWidth')).to.be(els.$container.prop('scrollWidth'));
});
describe('scroll event handling / tug of war prevention', function () {
it('listens when needed, unlistens when not needed', function () {
- var on = sinon.spy($.fn, 'on');
- var off = sinon.spy($.fn, 'off');
+ let on = sinon.spy($.fn, 'on');
+ let off = sinon.spy($.fn, 'off');
- var els = compile(1.5);
+ let els = compile(1.5);
expect(on.callCount).to.be(2);
checkThisVals('$.fn.on', on);
@@ -130,12 +130,12 @@ describe('FixedScroll directive', function () {
expect(spy.callCount).to.be(2);
// first call should read the scrollLeft from the $container
- var firstCall = spy.getCall(0);
+ let firstCall = spy.getCall(0);
expect(firstCall.thisValue.is($from)).to.be(true);
expect(firstCall.args).to.eql([]);
// second call should be setting the scrollLeft on the $scroller
- var secondCall = spy.getCall(1);
+ let secondCall = spy.getCall(1);
expect(secondCall.thisValue.is($to)).to.be(true);
expect(secondCall.args).to.eql([firstCall.returnValue]);
});
diff --git a/src/ui/public/directives/__tests__/input_focus.js b/src/ui/public/directives/__tests__/input_focus.js
index a252ddd971769..5d30dbb52f0aa 100644
--- a/src/ui/public/directives/__tests__/input_focus.js
+++ b/src/ui/public/directives/__tests__/input_focus.js
@@ -12,7 +12,7 @@ describe('Input focus directive', function () {
let $el;
let selectedEl;
let selectedText;
- var inputValue = 'Input Text Value';
+ let inputValue = 'Input Text Value';
beforeEach(ngMock.module('kibana'));
beforeEach(ngMock.inject(function (_$compile_, _$rootScope_, _$timeout_) {
diff --git a/src/ui/public/directives/__tests__/input_whole_number.js b/src/ui/public/directives/__tests__/input_whole_number.js
index 56c375c147c5d..0d97c28dfd767 100644
--- a/src/ui/public/directives/__tests__/input_whole_number.js
+++ b/src/ui/public/directives/__tests__/input_whole_number.js
@@ -6,7 +6,7 @@ import 'ui/directives/input_whole_number';
describe('Whole number input directive', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
beforeEach(ngMock.module('kibana'));
@@ -16,7 +16,7 @@ describe('Whole number input directive', function () {
}));
it('should allow whole numbers', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '123';
$rootScope.$digest();
@@ -32,7 +32,7 @@ describe('Whole number input directive', function () {
});
it('should disallow numbers with decimals', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '123.0';
$rootScope.$digest();
diff --git a/src/ui/public/directives/__tests__/json_input.js b/src/ui/public/directives/__tests__/json_input.js
index 12713fdaafa83..b82de486c974c 100644
--- a/src/ui/public/directives/__tests__/json_input.js
+++ b/src/ui/public/directives/__tests__/json_input.js
@@ -7,7 +7,7 @@ import 'ui/directives/json_input';
describe('JSON input validation', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
let element;
beforeEach(ngMock.module('kibana'));
@@ -28,8 +28,8 @@ describe('JSON input validation', function () {
});
it('should be able to not require keys', function () {
- var html = '';
- var element = $compile(html)($rootScope);
+ let html = '';
+ let element = $compile(html)($rootScope);
element.val('{}');
element.trigger('input');
diff --git a/src/ui/public/directives/__tests__/paginated_selectable_list.js b/src/ui/public/directives/__tests__/paginated_selectable_list.js
index 0e5d9fcad7ca2..eb18304b478ff 100644
--- a/src/ui/public/directives/__tests__/paginated_selectable_list.js
+++ b/src/ui/public/directives/__tests__/paginated_selectable_list.js
@@ -3,7 +3,7 @@ import expect from 'expect.js';
import ngMock from 'ng_mock';
import _ from 'lodash';
-var objectList = [
+let objectList = [
{ title: 'apple' },
{ title: 'orange' },
{ title: 'coconut' },
@@ -11,7 +11,7 @@ var objectList = [
{ title: 'grapes' }
];
-var stringList = [
+let stringList = [
'apple',
'orange',
'coconut',
@@ -19,18 +19,18 @@ var stringList = [
'grapes'
];
-var lists = [objectList, stringList, []];
+let lists = [objectList, stringList, []];
var $scope;
var $element;
var $isolatedScope;
lists.forEach(function (list) {
- var isArrayOfObjects = list.every((item) => {
+ let isArrayOfObjects = list.every((item) => {
return _.isPlainObject(item);
});
- var init = function (arr, willFail) {
+ let init = function (arr, willFail) {
// Load the application
ngMock.module('kibana');
@@ -83,8 +83,8 @@ lists.forEach(function (list) {
});
it('should initially sort an array of objects in ascending order', function () {
- var property = $isolatedScope.listProperty;
- var sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
+ let property = $isolatedScope.listProperty;
+ let sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
expect($isolatedScope.hits).to.be.an('array');
@@ -104,8 +104,8 @@ lists.forEach(function (list) {
});
it('should sort an array of objects in ascending order', function () {
- var property = $isolatedScope.listProperty;
- var sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
+ let property = $isolatedScope.listProperty;
+ let sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
$isolatedScope.isAscending = false;
$isolatedScope.sortHits(list);
@@ -122,8 +122,8 @@ lists.forEach(function (list) {
});
it('should sort an array of objects in descending order', function () {
- var property = $isolatedScope.listProperty;
- var reversedList = property ? _.sortBy(list, property).reverse() : _.sortBy(list).reverse();
+ let property = $isolatedScope.listProperty;
+ let reversedList = property ? _.sortBy(list, property).reverse() : _.sortBy(list).reverse();
$isolatedScope.isAscending = true;
$isolatedScope.sortHits(list);
@@ -146,8 +146,8 @@ lists.forEach(function (list) {
});
it('should return the result of the function its passed', function () {
- var property = $isolatedScope.listProperty;
- var sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
+ let property = $isolatedScope.listProperty;
+ let sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
$isolatedScope.hits.forEach(function (hit, index) {
if (property) {
@@ -165,8 +165,8 @@ lists.forEach(function (list) {
});
it('should return the result of the function its passed', function () {
- var property = $isolatedScope.listProperty;
- var sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
+ let property = $isolatedScope.listProperty;
+ let sortedList = property ? _.sortBy(list, property) : _.sortBy(list);
$isolatedScope.userOnSelect = function (val) { return val; };
diff --git a/src/ui/public/directives/__tests__/parse_query.js b/src/ui/public/directives/__tests__/parse_query.js
index 3e78f1e614ac7..6115bbdc20f35 100644
--- a/src/ui/public/directives/__tests__/parse_query.js
+++ b/src/ui/public/directives/__tests__/parse_query.js
@@ -14,14 +14,14 @@ let config;
let $elemScope;
let $elem;
-var cycleIndex = 0;
-var markup = '';
+let cycleIndex = 0;
+let markup = '';
let fromUser;
import toUser from 'ui/parse_query/lib/to_user';
import 'ui/parse_query';
import ParseQueryLibFromUserProvider from 'ui/parse_query/lib/from_user';
-var init = function () {
+let init = function () {
// Load the application
ngMock.module('kibana');
@@ -41,7 +41,7 @@ var init = function () {
});
};
-var compile = function () {
+let compile = function () {
$rootScope.mockModel = 'cycle' + cycleIndex++;
$rootScope.mockQueryInput = undefined;
diff --git a/src/ui/public/directives/__tests__/timepicker.js b/src/ui/public/directives/__tests__/timepicker.js
index 9d59f9d16675f..46208d5e80cd1 100644
--- a/src/ui/public/directives/__tests__/timepicker.js
+++ b/src/ui/public/directives/__tests__/timepicker.js
@@ -17,10 +17,10 @@ let $parentScope;
let $scope;
let $elem;
-var anchor = '2014-01-01T06:06:06.666Z';
+let anchor = '2014-01-01T06:06:06.666Z';
let clock;
-var init = function () {
+let init = function () {
// Load the application
ngMock.module('kibana');
@@ -34,7 +34,7 @@ var init = function () {
$parentScope = $rootScope;
// Add some parameters to it
- var timefilter = {
+ let timefilter = {
time : {
from: moment().subtract(15, 'minutes'),
to: moment(),
@@ -174,7 +174,7 @@ describe('timepicker directive', function () {
expect($elem.find('.kbn-timepicker-modes .active').text().trim()).to.be('quick');
// Each of the 3 modes
- var modes = ['absolute', 'relative', 'quick'];
+ let modes = ['absolute', 'relative', 'quick'];
_.each(modes, function (mode) {
$scope.setMode(mode);
$scope.$digest();
@@ -215,7 +215,7 @@ describe('timepicker directive', function () {
});
it('has a preview of the "from" input', function (done) {
- var preview = $elem.find('.kbn-timepicker-section span[ng-show="relative.preview"]');
+ let preview = $elem.find('.kbn-timepicker-section span[ng-show="relative.preview"]');
expect(preview.text()).to.be(moment().subtract(15, 'minutes').format($scope.format));
done();
});
@@ -226,7 +226,7 @@ describe('timepicker directive', function () {
});
it('has a submit handler', function (done) {
- var form = $elem.find('form[ng-submit="applyRelative()"]');
+ let form = $elem.find('form[ng-submit="applyRelative()"]');
expect(form.length).to.be(1);
done();
});
@@ -247,7 +247,7 @@ describe('timepicker directive', function () {
});
it('has a dropdown bound to relative.unit that contains all of the intervals', function (done) {
- var select = $elem.find('.kbn-timepicker-section select[ng-model="relative.unit"]');
+ let select = $elem.find('.kbn-timepicker-section select[ng-model="relative.unit"]');
expect(select.length).to.be(1);
expect(select.find('option').length).to.be(7);
@@ -259,7 +259,7 @@ describe('timepicker directive', function () {
});
it('has a checkbox that is checked when rounding is enabled', function (done) {
- var checkbox = $elem.find('.kbn-timepicker-section input[ng-model="relative.round"]');
+ let checkbox = $elem.find('.kbn-timepicker-section input[ng-model="relative.round"]');
expect(checkbox.length).to.be(1);
// Rounding is disabled by default
@@ -335,8 +335,8 @@ describe('timepicker directive', function () {
});
it('updates the input fields when the scope variables are changed', function (done) {
- var input = $elem.find('.kbn-timepicker-section input[ng-model="relative.count"]');
- var select = $elem.find('.kbn-timepicker-section select[ng-model="relative.unit"]');
+ let input = $elem.find('.kbn-timepicker-section input[ng-model="relative.count"]');
+ let select = $elem.find('.kbn-timepicker-section select[ng-model="relative.unit"]');
$scope.relative.count = 5;
$scope.$digest();
diff --git a/src/ui/public/directives/__tests__/truncate.js b/src/ui/public/directives/__tests__/truncate.js
index 695f6d912f64a..6fc4b54390494 100644
--- a/src/ui/public/directives/__tests__/truncate.js
+++ b/src/ui/public/directives/__tests__/truncate.js
@@ -11,7 +11,7 @@ let $scope;
let $elem;
-var init = function (text) {
+let init = function (text) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/directives/__tests__/typeahead.js b/src/ui/public/directives/__tests__/typeahead.js
index 4a5cf3798f3fe..53ae966325067 100644
--- a/src/ui/public/directives/__tests__/typeahead.js
+++ b/src/ui/public/directives/__tests__/typeahead.js
@@ -7,8 +7,8 @@ import 'plugins/kibana/discover/index';
// TODO: This should not be needed, timefilter is only included here, it should move
-var typeaheadHistoryCount = 10;
-var typeaheadName = 'unittest';
+let typeaheadHistoryCount = 10;
+let typeaheadName = 'unittest';
let $parentScope;
let $typeaheadScope;
let $elem;
@@ -16,13 +16,13 @@ let $typeaheadInputScope;
let typeaheadCtrl;
let PersistedLog;
-var markup = '
' +
+let markup = '
' +
'' +
'
';
-var typeaheadItems = ['abc', 'def', 'ghi'];
+let typeaheadItems = ['abc', 'def', 'ghi'];
-var init = function () {
+let init = function () {
// Load the application
ngMock.module('kibana');
@@ -64,7 +64,7 @@ var init = function () {
describe('typeahead directive', function () {
describe('typeahead requirements', function () {
describe('missing input', function () {
- var goodMarkup = markup;
+ let goodMarkup = markup;
before(function () {
markup = '' +
@@ -99,9 +99,9 @@ describe('typeahead directive', function () {
});
it('should not save empty entries', function () {
- var entries = typeaheadItems.slice(0);
+ let entries = typeaheadItems.slice(0);
entries.push('', 'jkl');
- for (var i = 0; i < entries.length; i++) {
+ for (let i = 0; i < entries.length; i++) {
$typeaheadScope.inputModel.$setViewValue(entries[i]);
typeaheadCtrl.persistEntry();
}
@@ -129,14 +129,14 @@ describe('typeahead directive', function () {
});
it('should order fitlered results', function () {
- var entries = ['ac/dc', 'anthrax', 'abba', 'phantogram', 'skrillex'];
- var allEntries = typeaheadItems.concat(entries);
- var startMatches = allEntries.filter(function (item) {
+ let entries = ['ac/dc', 'anthrax', 'abba', 'phantogram', 'skrillex'];
+ let allEntries = typeaheadItems.concat(entries);
+ let startMatches = allEntries.filter(function (item) {
return /^a/.test(item);
});
typeaheadCtrl.history.add.returns(allEntries);
- for (var i = 0; i < entries.length; i++) {
+ for (let i = 0; i < entries.length; i++) {
$typeaheadScope.inputModel.$setViewValue(entries[i]);
typeaheadCtrl.persistEntry();
}
@@ -144,7 +144,7 @@ describe('typeahead directive', function () {
typeaheadCtrl.filterItemsByQuery('a');
expect($typeaheadScope.filteredItems).to.contain('phantogram');
- var nonStarterIndex = $typeaheadScope.filteredItems.indexOf('phantogram');
+ let nonStarterIndex = $typeaheadScope.filteredItems.indexOf('phantogram');
startMatches.forEach(function (item) {
expect($typeaheadScope.filteredItems).to.contain(item);
diff --git a/src/ui/public/directives/__tests__/validate_cidr_mask.js b/src/ui/public/directives/__tests__/validate_cidr_mask.js
index d55b52cc64bed..702d983ab3b35 100644
--- a/src/ui/public/directives/__tests__/validate_cidr_mask.js
+++ b/src/ui/public/directives/__tests__/validate_cidr_mask.js
@@ -7,7 +7,7 @@ import 'ui/directives/validate_cidr_mask';
describe('Validate CIDR mask directive', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
beforeEach(ngMock.module('kibana'));
@@ -17,7 +17,7 @@ describe('Validate CIDR mask directive', function () {
}));
it('should allow empty input', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '';
$rootScope.$digest();
@@ -33,7 +33,7 @@ describe('Validate CIDR mask directive', function () {
});
it('should allow valid CIDR masks', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '0.0.0.0/1';
$rootScope.$digest();
@@ -53,7 +53,7 @@ describe('Validate CIDR mask directive', function () {
});
it('should disallow invalid CIDR masks', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = 'hello, world';
$rootScope.$digest();
diff --git a/src/ui/public/directives/__tests__/validate_date_math.js b/src/ui/public/directives/__tests__/validate_date_math.js
index 61d179356b981..02385b06a4940 100644
--- a/src/ui/public/directives/__tests__/validate_date_math.js
+++ b/src/ui/public/directives/__tests__/validate_date_math.js
@@ -7,7 +7,7 @@ import 'ui/directives/validate_date_math';
describe('Validate date math directive', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
beforeEach(ngMock.module('kibana'));
@@ -17,7 +17,7 @@ describe('Validate date math directive', function () {
}));
it('should allow valid date math', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = 'now';
$rootScope.$digest();
@@ -41,7 +41,7 @@ describe('Validate date math directive', function () {
});
it('should disallow invalid date math', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = 'hello, world';
$rootScope.$digest();
@@ -61,7 +61,7 @@ describe('Validate date math directive', function () {
});
it('should allow empty values', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '';
$rootScope.$digest();
diff --git a/src/ui/public/directives/__tests__/validate_index_name.js b/src/ui/public/directives/__tests__/validate_index_name.js
index 16bca26e45467..f792f65c8174a 100644
--- a/src/ui/public/directives/__tests__/validate_index_name.js
+++ b/src/ui/public/directives/__tests__/validate_index_name.js
@@ -8,7 +8,7 @@ import 'ui/directives/validate_index_name';
describe('Validate index name directive', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
beforeEach(ngMock.module('kibana'));
@@ -19,12 +19,12 @@ describe('Validate index name directive', function () {
function checkPattern(input) {
$rootScope.indexName = input;
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.$digest();
return element;
}
- var badPatterns = [
+ let badPatterns = [
null,
undefined,
'',
@@ -41,7 +41,7 @@ describe('Validate index name directive', function () {
'foo,bar',
];
- var goodPatterns = [
+ let goodPatterns = [
'...',
'foo',
'foo.bar',
@@ -53,7 +53,7 @@ describe('Validate index name directive', function () {
badPatterns.forEach(function (pattern) {
it('should not accept index pattern: ' + pattern, function () {
- var element = checkPattern(pattern);
+ let element = checkPattern(pattern);
expect(element.hasClass('ng-invalid')).to.be(true);
expect(element.hasClass('ng-valid')).to.not.be(true);
});
@@ -61,7 +61,7 @@ describe('Validate index name directive', function () {
goodPatterns.forEach(function (pattern) {
it('should accept index pattern: ' + pattern, function () {
- var element = checkPattern(pattern);
+ let element = checkPattern(pattern);
expect(element.hasClass('ng-invalid')).to.not.be(true);
expect(element.hasClass('ng-valid')).to.be(true);
});
diff --git a/src/ui/public/directives/__tests__/validate_ip.js b/src/ui/public/directives/__tests__/validate_ip.js
index bf5bb8669dd5b..9f5066f28f8cf 100644
--- a/src/ui/public/directives/__tests__/validate_ip.js
+++ b/src/ui/public/directives/__tests__/validate_ip.js
@@ -7,7 +7,7 @@ import 'ui/directives/validate_ip';
describe('Validate IP directive', function () {
let $compile;
let $rootScope;
- var html = '';
+ let html = '';
beforeEach(ngMock.module('kibana'));
@@ -17,7 +17,7 @@ describe('Validate IP directive', function () {
}));
it('should allow empty input', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '';
$rootScope.$digest();
@@ -33,7 +33,7 @@ describe('Validate IP directive', function () {
});
it('should allow valid IP addresses', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = '0.0.0.0';
$rootScope.$digest();
@@ -53,7 +53,7 @@ describe('Validate IP directive', function () {
});
it('should disallow invalid IP addresses', function () {
- var element = $compile(html)($rootScope);
+ let element = $compile(html)($rootScope);
$rootScope.value = 'hello, world';
$rootScope.$digest();
diff --git a/src/ui/public/directives/__tests__/validate_json.js b/src/ui/public/directives/__tests__/validate_json.js
index 99755a9897f74..cf2616dc4baf1 100644
--- a/src/ui/public/directives/__tests__/validate_json.js
+++ b/src/ui/public/directives/__tests__/validate_json.js
@@ -8,23 +8,23 @@ import 'ui/directives/validate_json';
let $parentScope;
let $elemScope;
let $elem;
-var mockScope = '';
+let mockScope = '';
-var input = {
+let input = {
valid: '{ "test": "json input" }',
invalid: 'strings are not json'
};
-var markup = {
+let markup = {
textarea: '',
input: ''
};
-var init = function (type) {
+let init = function (type) {
// Load the application
ngMock.module('kibana');
type = type || 'input';
- var elMarkup = markup[type];
+ let elMarkup = markup[type];
// Create the scope
ngMock.inject(function ($injector, $rootScope, $compile) {
@@ -39,7 +39,7 @@ var init = function (type) {
};
describe('validate-json directive', function () {
- var checkValid = function (inputVal, className) {
+ let checkValid = function (inputVal, className) {
$parentScope.mockModel = inputVal;
$elem.scope().$digest();
expect($elem.hasClass(className)).to.be(true);
diff --git a/src/ui/public/doc_table/__tests__/doc_table.js b/src/ui/public/doc_table/__tests__/doc_table.js
index 62b1bc365b5ec..b5dc9c3dcbbf6 100644
--- a/src/ui/public/doc_table/__tests__/doc_table.js
+++ b/src/ui/public/doc_table/__tests__/doc_table.js
@@ -23,7 +23,7 @@ let $timeout;
let searchSource;
-var init = function ($elem, props) {
+let init = function ($elem, props) {
ngMock.inject(function ($rootScope, $compile, _$timeout_) {
$timeout = _$timeout_;
$parentScope = $rootScope;
@@ -41,7 +41,7 @@ var init = function ($elem, props) {
});
};
-var destroy = function () {
+let destroy = function () {
$scope.$destroy();
$parentScope.$destroy();
};
diff --git a/src/ui/public/doc_table/__tests__/lib/get_sort.js b/src/ui/public/doc_table/__tests__/lib/get_sort.js
index 52ed51913cced..3fc141bad8336 100644
--- a/src/ui/public/doc_table/__tests__/lib/get_sort.js
+++ b/src/ui/public/doc_table/__tests__/lib/get_sort.js
@@ -1,5 +1,5 @@
import getSort from 'ui/doc_table/lib/get_sort';
-var defaultSort = {time: 'desc'};
+let defaultSort = {time: 'desc'};
import expect from 'expect.js';
import ngMock from 'ng_mock';
import FixturesStubbedLogstashIndexPatternProvider from 'fixtures/stubbed_logstash_index_pattern';
diff --git a/src/ui/public/doc_table/__tests__/lib/rows_headers.js b/src/ui/public/doc_table/__tests__/lib/rows_headers.js
index fa92ccbec6ad3..f68527482c15e 100644
--- a/src/ui/public/doc_table/__tests__/lib/rows_headers.js
+++ b/src/ui/public/doc_table/__tests__/lib/rows_headers.js
@@ -28,7 +28,7 @@ describe('Doc Table', function () {
}));
// Sets up the directive, take an element, and a list of properties to attach to the parent scope.
- var init = function ($elem, props) {
+ let init = function ($elem, props) {
ngMock.inject(function ($compile) {
_.assign($parentScope, props);
$compile($elem)($parentScope);
@@ -37,17 +37,17 @@ describe('Doc Table', function () {
});
};
- var destroy = function () {
+ let destroy = function () {
$scope.$destroy();
$parentScope.$destroy();
};
// For testing column removing/adding for the header and the rows
//
- var columnTests = function (elemType, parentElem) {
+ let columnTests = function (elemType, parentElem) {
it('should create a time column if the timefield is defined', function (done) {
- var childElems = parentElem.find(elemType);
+ let childElems = parentElem.find(elemType);
expect(childElems.length).to.be(2);
done();
});
@@ -79,7 +79,7 @@ describe('Doc Table', function () {
delete parentElem.scope().indexPattern.timeFieldName;
parentElem.scope().$digest();
- var childElems = parentElem.find(elemType);
+ let childElems = parentElem.find(elemType);
expect(childElems.length).to.be(1);
done();
});
@@ -89,7 +89,7 @@ describe('Doc Table', function () {
describe('kbnTableHeader', function () {
- var $elem = angular.element(
+ let $elem = angular.element(
''
);
@@ -120,7 +120,7 @@ describe('Doc Table', function () {
});
it('should sort asc by default, then by desc if already sorting', function (done) {
- var fields = ['bytes', '@timestamp'];
+ let fields = ['bytes', '@timestamp'];
// Should not be sorted at first
expect($scope.sorting).to.eql(undefined);
@@ -201,7 +201,7 @@ describe('Doc Table', function () {
});
describe('kbnTableRow', function () {
- var $elem = angular.element(
+ let $elem = angular.element(
'=', gt: '>', lte: '<=', lt: '<'}, function (operator, key) {
- var params = {};
+ let params = {};
params[key] = 5;
- var filter = fn(indexPattern.fields.byName['script number'], params, indexPattern);
+ let filter = fn(indexPattern.fields.byName['script number'], params, indexPattern);
expect(filter.script.script).to.be('(' + indexPattern.fields.byName['script number'].script + ')' + operator + key);
expect(filter.script.params[key]).to.be(5);
diff --git a/src/ui/public/filters/__tests__/field_type.js b/src/ui/public/filters/__tests__/field_type.js
index 1dd63bd1ab8f6..215a34be2c206 100644
--- a/src/ui/public/filters/__tests__/field_type.js
+++ b/src/ui/public/filters/__tests__/field_type.js
@@ -9,7 +9,7 @@ let filter;
let types;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
@@ -59,7 +59,7 @@ describe('fieldType array filter', function () {
});
it('should allow negation', function () {
- var resultNames = _.pluck(filter(types, '!string'), 'name');
+ let resultNames = _.pluck(filter(types, '!string'), 'name');
expect(resultNames).to.eql(['n1', 'n2', 'i1', 'd1']);
});
});
diff --git a/src/ui/public/filters/__tests__/label.js b/src/ui/public/filters/__tests__/label.js
index 4e02b009b504b..920f6fb90f0bd 100644
--- a/src/ui/public/filters/__tests__/label.js
+++ b/src/ui/public/filters/__tests__/label.js
@@ -9,7 +9,7 @@ import 'plugins/kibana/discover/index';
let filter;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/filters/__tests__/moment.js b/src/ui/public/filters/__tests__/moment.js
index 781a5d8362e1b..1d4a330251e5b 100644
--- a/src/ui/public/filters/__tests__/moment.js
+++ b/src/ui/public/filters/__tests__/moment.js
@@ -9,10 +9,10 @@ import 'ui/filters/moment';
let filter;
let config;
-var anchor = '2014-01-01T06:06:06.666';
+let anchor = '2014-01-01T06:06:06.666';
let clock;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/filters/__tests__/rison.js b/src/ui/public/filters/__tests__/rison.js
index 4ecfe30159979..2412d032da994 100644
--- a/src/ui/public/filters/__tests__/rison.js
+++ b/src/ui/public/filters/__tests__/rison.js
@@ -8,7 +8,7 @@ import 'plugins/kibana/discover/index';
let rison;
let risonDecode;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
@@ -20,13 +20,13 @@ var init = function (expandable) {
};
describe('rison filters', function () {
- var testObj = {
+ let testObj = {
time: {
from: 'now-15m',
to: 'now'
}
};
- var testRison = '(time:(from:now-15m,to:now))';
+ let testRison = '(time:(from:now-15m,to:now))';
beforeEach(function () {
init();
diff --git a/src/ui/public/filters/__tests__/short_dots.js b/src/ui/public/filters/__tests__/short_dots.js
index febc2a144639a..cacfab16b8676 100644
--- a/src/ui/public/filters/__tests__/short_dots.js
+++ b/src/ui/public/filters/__tests__/short_dots.js
@@ -10,7 +10,7 @@ let filter;
let config;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/filters/__tests__/start_from.js b/src/ui/public/filters/__tests__/start_from.js
index 32484c9094acf..3f03605c27f3d 100644
--- a/src/ui/public/filters/__tests__/start_from.js
+++ b/src/ui/public/filters/__tests__/start_from.js
@@ -6,7 +6,7 @@ import 'ui/filters/start_from';
let filter;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/filters/__tests__/uriescape.js b/src/ui/public/filters/__tests__/uriescape.js
index f186614186a19..8baa7469ccf5c 100644
--- a/src/ui/public/filters/__tests__/uriescape.js
+++ b/src/ui/public/filters/__tests__/uriescape.js
@@ -7,7 +7,7 @@ import 'plugins/kibana/discover/index';
let filter;
-var init = function (expandable) {
+let init = function (expandable) {
// Load the application
ngMock.module('kibana');
diff --git a/src/ui/public/highlight/__tests__/highlight.js b/src/ui/public/highlight/__tests__/highlight.js
index fcf65da5fa34d..050cd99d92c27 100644
--- a/src/ui/public/highlight/__tests__/highlight.js
+++ b/src/ui/public/highlight/__tests__/highlight.js
@@ -15,7 +15,7 @@ describe('Highlight', function () {
tags = highlightTags;
}));
- var text = '' +
+ let text = '' +
'Bacon ipsum dolor amet pork loin pork cow pig beef chuck ground round shankle sirloin landjaeger kevin ' +
'venison sausage ribeye tongue. Chicken bacon ball tip pork. Brisket pork capicola spare ribs pastrami rump ' +
'sirloin, t-bone ham shoulder jerky turducken bresaola. Chicken cow beef picanha. Picanha hamburger alcatra ' +
@@ -28,27 +28,27 @@ describe('Highlight', function () {
});
it('should highlight a single result', function () {
- var highlights = [
+ let highlights = [
tags.pre + 'hamburger' + tags.post + ' alcatra cupim. Salami capicola boudin pork belly shank picanha.'
];
- var result = filter(text, highlights);
+ let result = filter(text, highlights);
expect(result.indexOf('hamburger')).to.be.greaterThan(-1);
expect(result.split('hamburger').length).to.be(text.split('hamburger').length);
});
it('should highlight multiple results', function () {
- var highlights = [
+ let highlights = [
'kevin venison sausage ribeye tongue. ' + tags.pre + 'Chicken' + tags.post + ' bacon ball tip pork. Brisket ' +
'pork capicola spare ribs pastrami rump sirloin, t-bone ham shoulder jerky turducken bresaola. ' + tags.pre +
'Chicken' + tags.post + ' cow beef picanha. Picanha'
];
- var result = filter(text, highlights);
+ let result = filter(text, highlights);
expect(result.indexOf('Chicken')).to.be.greaterThan(-1);
expect(result.split('Chicken').length).to.be(text.split('Chicken').length);
});
it('should highlight multiple hits in a result', function () {
- var highlights = [
+ let highlights = [
'Bacon ipsum dolor amet ' + tags.pre + 'pork' + tags.post + ' loin ' +
'' + tags.pre + 'pork' + tags.post + ' cow pig beef chuck ground round shankle ' +
'sirloin landjaeger',
@@ -58,14 +58,14 @@ describe('Highlight', function () {
'hamburger alcatra cupim. Salami capicola boudin ' + tags.pre + 'pork' + tags.post + ' ' +
'belly shank picanha.'
];
- var result = filter(text, highlights);
+ let result = filter(text, highlights);
expect(result.indexOf('pork')).to.be.greaterThan(-1);
expect(result.split('pork').length).to.be(text.split('pork').length);
});
it('should accept an object and return a string containing its properties', function () {
- var obj = {foo: 1, bar: 2};
- var result = filter(obj, null);
+ let obj = {foo: 1, bar: 2};
+ let result = filter(obj, null);
expect(result.indexOf('' + obj)).to.be(-1);
expect(result.indexOf('foo')).to.be.greaterThan(-1);
expect(result.indexOf('bar')).to.be.greaterThan(-1);
diff --git a/src/ui/public/index_patterns/__tests__/_cast_mapping_type.js b/src/ui/public/index_patterns/__tests__/_cast_mapping_type.js
index 3d4b8f6bef9bf..60a4b93ba6d77 100644
--- a/src/ui/public/index_patterns/__tests__/_cast_mapping_type.js
+++ b/src/ui/public/index_patterns/__tests__/_cast_mapping_type.js
@@ -20,7 +20,7 @@ describe('type normalizer (castMappingType)', function () {
});
it('should cast numeric types to "number"', function () {
- var types = [
+ let types = [
'float',
'double',
'integer',
@@ -36,7 +36,7 @@ describe('type normalizer (castMappingType)', function () {
});
it('should treat non-numeric known types as what they are', function () {
- var types = [
+ let types = [
'date',
'boolean',
'ip',
@@ -53,7 +53,7 @@ describe('type normalizer (castMappingType)', function () {
});
it('should cast text and keyword types to "string"', function () {
- var types = [
+ let types = [
'keyword',
'text'
];
diff --git a/src/ui/public/index_patterns/__tests__/_field_format.js b/src/ui/public/index_patterns/__tests__/_field_format.js
index 710b0738ac963..fd8eb22e9dd97 100644
--- a/src/ui/public/index_patterns/__tests__/_field_format.js
+++ b/src/ui/public/index_patterns/__tests__/_field_format.js
@@ -24,14 +24,14 @@ describe('FieldFormat class', function () {
describe('params', function () {
it('accepts its params via the constructor', function () {
- var f = new TestFormat({ foo: 'bar' });
+ let f = new TestFormat({ foo: 'bar' });
expect(f.param('foo')).to.be('bar');
});
it('allows reading a clone of the params', function () {
- var params = { foo: 'bar' };
- var f = new TestFormat(params);
- var output = f.params();
+ let params = { foo: 'bar' };
+ let f = new TestFormat(params);
+ let output = f.params();
expect(output).to.eql(params);
expect(output).to.not.be(params);
});
@@ -39,29 +39,29 @@ describe('FieldFormat class', function () {
describe('type', function () {
it('links the constructor class to instances as the `type`', function () {
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.type).to.be(TestFormat);
});
});
describe('toJSON', function () {
it('serializes to a version a basic id and param pair', function () {
- var f = new TestFormat({ foo: 'bar' });
- var ser = JSON.parse(JSON.stringify(f));
+ let f = new TestFormat({ foo: 'bar' });
+ let ser = JSON.parse(JSON.stringify(f));
expect(ser).to.eql({ id: 'test-format', params: { foo: 'bar' } });
});
it('removes param values that match the defaults', function () {
TestFormat.paramDefaults = { foo: 'bar' };
- var f = new TestFormat({ foo: 'bar', baz: 'bar' });
- var ser = JSON.parse(JSON.stringify(f));
+ let f = new TestFormat({ foo: 'bar', baz: 'bar' });
+ let ser = JSON.parse(JSON.stringify(f));
expect(ser.params).to.eql({ baz: 'bar' });
});
it('removes the params entirely if they are empty', function () {
- var f = new TestFormat();
- var ser = JSON.parse(JSON.stringify(f));
+ let f = new TestFormat();
+ let ser = JSON.parse(JSON.stringify(f));
expect(ser).to.not.have.property('params');
});
});
@@ -69,7 +69,7 @@ describe('FieldFormat class', function () {
describe('converters', function () {
describe('#getConverterFor', function () {
it('returns a converter for a specific content type', function () {
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.getConverterFor('html')()).to.be.a('string');
expect(f.getConverterFor('text')()).to.be.a('string');
});
@@ -81,9 +81,9 @@ describe('FieldFormat class', function () {
return 'formatted';
};
- var f = new TestFormat();
- var text = f.getConverterFor('text');
- var html = f.getConverterFor('html');
+ let f = new TestFormat();
+ let text = f.getConverterFor('text');
+ let html = f.getConverterFor('html');
expect(text).to.not.be(html);
expect(text('formatted')).to.be('formatted');
expect(html('formatted')).to.be('formatted');
@@ -95,9 +95,9 @@ describe('FieldFormat class', function () {
html: _.constant('formatted html'),
};
- var f = new TestFormat();
- var text = f.getConverterFor('text');
- var html = f.getConverterFor('html');
+ let f = new TestFormat();
+ let text = f.getConverterFor('text');
+ let html = f.getConverterFor('html');
expect(text).to.not.be(html);
expect(text('formatted text')).to.be('formatted text');
expect(html('formatted html')).to.be('formatted html');
@@ -105,13 +105,13 @@ describe('FieldFormat class', function () {
it('does not escape the output of the text converter', function () {
TestFormat.prototype._convert = _.constant('');
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert('', 'text')).to.contain('<');
});
it('does escape the output of the text converter if used in an html context', function () {
TestFormat.prototype._convert = _.constant('');
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert('', 'html')).to.not.contain('<');
});
@@ -121,7 +121,7 @@ describe('FieldFormat class', function () {
html: _.constant('![]()
'),
};
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert('', 'text')).to.be('![]()
');
expect(f.convert('', 'html')).to.be('![]()
');
});
@@ -134,7 +134,7 @@ describe('FieldFormat class', function () {
html: _.constant('html'),
};
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert('val')).to.be('text');
});
@@ -144,12 +144,12 @@ describe('FieldFormat class', function () {
html: _.constant('html'),
};
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert('val', 'html')).to.be('html');
});
it('formats a value as " - " when no value is specified', function () {
- var f = new TestFormat();
+ let f = new TestFormat();
expect(f.convert()).to.be(' - ');
});
});
diff --git a/src/ui/public/index_patterns/__tests__/_index_pattern.js b/src/ui/public/index_patterns/__tests__/_index_pattern.js
index f11650ec7188f..ccce5e10f73f5 100644
--- a/src/ui/public/index_patterns/__tests__/_index_pattern.js
+++ b/src/ui/public/index_patterns/__tests__/_index_pattern.js
@@ -20,7 +20,7 @@ describe('index pattern', function () {
let DocSource;
let config;
let docSourceResponse;
- var indexPatternId = 'test-pattern';
+ let indexPatternId = 'test-pattern';
let indexPattern;
let calculateIndices;
let $rootScope;
@@ -77,7 +77,7 @@ describe('index pattern', function () {
// helper function to create index patterns
function create(id, payload) {
- var indexPattern = new IndexPattern(id);
+ let indexPattern = new IndexPattern(id);
DocSource.prototype.doIndex.returns(Promise.resolve(id));
payload = _.defaults(payload || {}, docSourceResponse(id));
setDocsourcePayload(payload);
@@ -129,16 +129,16 @@ describe('index pattern', function () {
describe('getScriptedFields', function () {
it('should return all scripted fields', function () {
- var scriptedNames = _(mockLogstashFields).where({ scripted: true }).pluck('name').value();
- var respNames = _.pluck(indexPattern.getScriptedFields(), 'name');
+ let scriptedNames = _(mockLogstashFields).where({ scripted: true }).pluck('name').value();
+ let respNames = _.pluck(indexPattern.getScriptedFields(), 'name');
expect(respNames).to.eql(scriptedNames);
});
});
describe('getNonScriptedFields', function () {
it('should return all non-scripted fields', function () {
- var notScriptedNames = _(mockLogstashFields).where({ scripted: false }).pluck('name').value();
- var respNames = _.pluck(indexPattern.getNonScriptedFields(), 'name');
+ let notScriptedNames = _(mockLogstashFields).where({ scripted: false }).pluck('name').value();
+ let respNames = _.pluck(indexPattern.getNonScriptedFields(), 'name');
expect(respNames).to.eql(notScriptedNames);
});
@@ -147,7 +147,7 @@ describe('index pattern', function () {
describe('refresh fields', function () {
// override the default indexPattern, with a truncated field list
require('test_utils/no_digest_promises').activateForSuite();
- var indexPatternId = 'test-pattern';
+ let indexPatternId = 'test-pattern';
let indexPattern;
let fieldLength;
let truncatedFields;
@@ -181,8 +181,8 @@ describe('index pattern', function () {
indexPattern.refreshFields(),
])
.then(function (data) {
- var expected = data[0]; // just the fields in the index
- var fields = indexPattern.getNonScriptedFields(); // get all but scripted fields
+ let expected = data[0]; // just the fields in the index
+ let fields = indexPattern.getNonScriptedFields(); // get all but scripted fields
expect(_.pluck(fields, 'name')).to.eql(_.pluck(expected, 'name'));
});
@@ -193,15 +193,15 @@ describe('index pattern', function () {
setDocsourcePayload(docSourceResponse(indexPatternId));
// add spy to indexPattern.getScriptedFields
- var scriptedFieldsSpy = sinon.spy(indexPattern, 'getScriptedFields');
+ let scriptedFieldsSpy = sinon.spy(indexPattern, 'getScriptedFields');
// refresh fields, which will fetch
return indexPattern.refreshFields().then(function () {
// called to append scripted fields to the response from mapper.getFieldsForIndexPattern
expect(scriptedFieldsSpy.callCount).to.equal(1);
- var scripted = _.where(mockLogstashFields, { scripted: true });
- var expected = _.filter(indexPattern.fields, { scripted: true });
+ let scripted = _.where(mockLogstashFields, { scripted: true });
+ let expected = _.filter(indexPattern.fields, { scripted: true });
expect(_.pluck(expected, 'name')).to.eql(_.pluck(scripted, 'name'));
});
});
@@ -210,11 +210,11 @@ describe('index pattern', function () {
describe('add and remove scripted fields', function () {
it('should append the scripted field', function () {
// keep a copy of the current scripted field count
- var saveSpy = sinon.spy(indexPattern, 'save');
- var oldCount = indexPattern.getScriptedFields().length;
+ let saveSpy = sinon.spy(indexPattern, 'save');
+ let oldCount = indexPattern.getScriptedFields().length;
// add a new scripted field
- var scriptedField = {
+ let scriptedField = {
name: 'new scripted field',
script: 'false',
type: 'boolean'
@@ -222,17 +222,17 @@ describe('index pattern', function () {
indexPattern.addScriptedField(scriptedField.name, scriptedField.script, scriptedField.type);
indexPattern._indexFields(); // normally triggered by docSource.onUpdate()
- var scriptedFields = indexPattern.getScriptedFields();
+ let scriptedFields = indexPattern.getScriptedFields();
expect(saveSpy.callCount).to.equal(1);
expect(scriptedFields).to.have.length(oldCount + 1);
expect(indexPattern.fields.byName[scriptedField.name].displayName).to.equal(scriptedField.name);
});
it('should remove scripted field, by name', function () {
- var saveSpy = sinon.spy(indexPattern, 'save');
- var scriptedFields = indexPattern.getScriptedFields();
- var oldCount = scriptedFields.length;
- var scriptedField = _.last(scriptedFields);
+ let saveSpy = sinon.spy(indexPattern, 'save');
+ let scriptedFields = indexPattern.getScriptedFields();
+ let oldCount = scriptedFields.length;
+ let scriptedField = _.last(scriptedFields);
indexPattern.removeScriptedField(scriptedField.name);
@@ -242,8 +242,8 @@ describe('index pattern', function () {
});
it('should not allow duplicate names', function () {
- var scriptedFields = indexPattern.getScriptedFields();
- var scriptedField = _.last(scriptedFields);
+ let scriptedFields = indexPattern.getScriptedFields();
+ let scriptedField = _.last(scriptedFields);
expect(function () {
indexPattern.addScriptedField(scriptedField.name, '\'new script\'', 'string');
}).to.throwError(function (e) {
@@ -254,9 +254,9 @@ describe('index pattern', function () {
describe('popularizeField', function () {
it('should increment the poplarity count by default', function () {
- var saveSpy = sinon.stub(indexPattern, 'save');
+ let saveSpy = sinon.stub(indexPattern, 'save');
indexPattern.fields.forEach(function (field, i) {
- var oldCount = field.count;
+ let oldCount = field.count;
indexPattern.popularizeField(field.name);
@@ -266,10 +266,10 @@ describe('index pattern', function () {
});
it('should increment the poplarity count', function () {
- var saveSpy = sinon.stub(indexPattern, 'save');
+ let saveSpy = sinon.stub(indexPattern, 'save');
indexPattern.fields.forEach(function (field, i) {
- var oldCount = field.count;
- var incrementAmount = 4;
+ let oldCount = field.count;
+ let incrementAmount = 4;
indexPattern.popularizeField(field.name, incrementAmount);
@@ -280,9 +280,9 @@ describe('index pattern', function () {
it('should decrement the poplarity count', function () {
indexPattern.fields.forEach(function (field, i) {
- var oldCount = field.count;
- var incrementAmount = 4;
- var decrementAmount = -2;
+ let oldCount = field.count;
+ let incrementAmount = 4;
+ let decrementAmount = -2;
indexPattern.popularizeField(field.name, incrementAmount);
indexPattern.popularizeField(field.name, decrementAmount);
@@ -293,7 +293,7 @@ describe('index pattern', function () {
it('should not go below 0', function () {
indexPattern.fields.forEach(function (field) {
- var decrementAmount = -Number.MAX_VALUE;
+ let decrementAmount = -Number.MAX_VALUE;
indexPattern.popularizeField(field.name, decrementAmount);
expect(field.count).to.equal(0);
});
@@ -311,11 +311,11 @@ describe('index pattern', function () {
it('invokes interval toDetailedIndexList with given start/stop times', async function () {
await indexPattern.toDetailedIndexList(1, 2);
- var id = indexPattern.id;
+ let id = indexPattern.id;
expect(intervals.toIndexList.calledWith(id, interval, 1, 2)).to.be(true);
});
it('is fulfilled by the result of interval toDetailedIndexList', async function () {
- var indexList = await indexPattern.toDetailedIndexList();
+ let indexList = await indexPattern.toDetailedIndexList();
expect(indexList[0].index).to.equal('foo');
expect(indexList[1].index).to.equal('bar');
});
@@ -340,13 +340,13 @@ describe('index pattern', function () {
it('invokes calculateIndices with given start/stop times and sortOrder', async function () {
await indexPattern.toDetailedIndexList(1, 2, 'sortOrder');
- var id = indexPattern.id;
- var field = indexPattern.timeFieldName;
+ let id = indexPattern.id;
+ let field = indexPattern.timeFieldName;
expect(calculateIndices.calledWith(id, field, 1, 2, 'sortOrder')).to.be(true);
});
it('is fulfilled by the result of calculateIndices', async function () {
- var indexList = await indexPattern.toDetailedIndexList();
+ let indexList = await indexPattern.toDetailedIndexList();
expect(indexList[0].index).to.equal('foo');
expect(indexList[1].index).to.equal('bar');
});
@@ -361,7 +361,7 @@ describe('index pattern', function () {
});
it('is fulfilled by id', async function () {
- var indexList = await indexPattern.toDetailedIndexList();
+ let indexList = await indexPattern.toDetailedIndexList();
expect(indexList.index).to.equal(indexPattern.id);
});
});
@@ -372,7 +372,7 @@ describe('index pattern', function () {
});
it('is fulfilled by id', async function () {
- var indexList = await indexPattern.toDetailedIndexList();
+ let indexList = await indexPattern.toDetailedIndexList();
expect(indexList.index).to.equal(indexPattern.id);
});
});
@@ -390,11 +390,11 @@ describe('index pattern', function () {
it('invokes interval toIndexList with given start/stop times', async function () {
await indexPattern.toIndexList(1, 2);
- var id = indexPattern.id;
+ let id = indexPattern.id;
expect(intervals.toIndexList.calledWith(id, interval, 1, 2)).to.be(true);
});
it('is fulfilled by the result of interval toIndexList', async function () {
- var indexList = await indexPattern.toIndexList();
+ let indexList = await indexPattern.toIndexList();
expect(indexList[0]).to.equal('foo');
expect(indexList[1]).to.equal('bar');
});
@@ -420,13 +420,13 @@ describe('index pattern', function () {
it('invokes calculateIndices with given start/stop times and sortOrder', async function () {
await indexPattern.toIndexList(1, 2, 'sortOrder');
- var id = indexPattern.id;
- var field = indexPattern.timeFieldName;
+ let id = indexPattern.id;
+ let field = indexPattern.timeFieldName;
expect(calculateIndices.calledWith(id, field, 1, 2, 'sortOrder')).to.be(true);
});
it('is fulfilled by the result of calculateIndices', async function () {
- var indexList = await indexPattern.toIndexList();
+ let indexList = await indexPattern.toIndexList();
expect(indexList[0]).to.equal('foo');
expect(indexList[1]).to.equal('bar');
});
@@ -442,7 +442,7 @@ describe('index pattern', function () {
});
it('is fulfilled by id', async function () {
- var indexList = await indexPattern.toIndexList();
+ let indexList = await indexPattern.toIndexList();
expect(indexList).to.equal(indexPattern.id);
});
});
diff --git a/src/ui/public/index_patterns/__tests__/_map_field.js b/src/ui/public/index_patterns/__tests__/_map_field.js
index feaf6b4c6dae2..3384e9c530a7c 100644
--- a/src/ui/public/index_patterns/__tests__/_map_field.js
+++ b/src/ui/public/index_patterns/__tests__/_map_field.js
@@ -18,31 +18,31 @@ describe('field mapping normalizer (mapField)', function () {
});
it('should return a modified copy of the object, not modify the original', function () {
- var pristine = _.cloneDeep(fields['foo.bar']);
- var mapped = fn(fields['foo.bar'], 'foo.bar');
+ let pristine = _.cloneDeep(fields['foo.bar']);
+ let mapped = fn(fields['foo.bar'], 'foo.bar');
expect(fields['foo.bar']).to.not.eql(mapped);
expect(fields['foo.bar']).to.eql(pristine);
});
it('should not consider _id indexed unless it is', function () {
- var mapped = fn(fields._id, '_id');
+ let mapped = fn(fields._id, '_id');
expect(mapped.indexed).to.be(false);
- var mapping = _.cloneDeep(fields._id);
+ let mapping = _.cloneDeep(fields._id);
mapping.mapping._id.index = 'not_analyzed';
- var mapped2 = fn(mapping, '_id');
+ let mapped2 = fn(mapping, '_id');
expect(mapped2.indexed).to.be(true);
});
it('should always consider _timestamp to be an indexed date', function () {
- var mapped = fn(fields._timestamp, '_timestamp');
+ let mapped = fn(fields._timestamp, '_timestamp');
expect(mapped.indexed).to.be(true);
expect(mapped.type).to.be('date');
});
it('should treat falsy and no as false for index', function () {
- var mapped = fn(fields.index_no_field, 'index_no_field');
+ let mapped = fn(fields.index_no_field, 'index_no_field');
expect(mapped.indexed).to.be(false);
fields.index_no_field.index = false;
@@ -51,7 +51,7 @@ describe('field mapping normalizer (mapField)', function () {
});
it('should treat other values for index as true', function () {
- var mapped = fn(fields.not_analyzed_field, 'not_analyzed_field');
+ let mapped = fn(fields.not_analyzed_field, 'not_analyzed_field');
expect(mapped.indexed).to.be(true);
});
diff --git a/src/ui/public/index_patterns/__tests__/_pattern_to_wildcard.js b/src/ui/public/index_patterns/__tests__/_pattern_to_wildcard.js
index b65ce865f12bf..e2313bce95759 100644
--- a/src/ui/public/index_patterns/__tests__/_pattern_to_wildcard.js
+++ b/src/ui/public/index_patterns/__tests__/_pattern_to_wildcard.js
@@ -1,7 +1,7 @@
import expect from 'expect.js';
describe('Index pattern to wildcard', function () {
- var fn = require('ui/index_patterns/_pattern_to_wildcard')();
+ let fn = require('ui/index_patterns/_pattern_to_wildcard')();
it('should be a function', function () {
diff --git a/src/ui/public/index_patterns/__tests__/flatten_hit.js b/src/ui/public/index_patterns/__tests__/flatten_hit.js
index 427ef3f074588..632e959b263cc 100644
--- a/src/ui/public/index_patterns/__tests__/flatten_hit.js
+++ b/src/ui/public/index_patterns/__tests__/flatten_hit.js
@@ -13,7 +13,7 @@ describe('IndexPattern#flattenHit()', function () {
beforeEach(ngMock.module('kibana'));
beforeEach(ngMock.inject(function (Private, $injector) {
- var indexPattern = {
+ let indexPattern = {
fields: {
byName: {
'message': { type: 'string' },
diff --git a/src/ui/public/index_patterns/__tests__/intervals.js b/src/ui/public/index_patterns/__tests__/intervals.js
index 241cdda7e53e0..ff486c86a68c4 100644
--- a/src/ui/public/index_patterns/__tests__/intervals.js
+++ b/src/ui/public/index_patterns/__tests__/intervals.js
@@ -14,10 +14,10 @@ describe('Index Patterns', function () {
}));
it('should return correct indices for hourly [logstash-]YYYY.MM.DD.HH', function () {
- var start = moment.utc('2014-01-01T07:00:00Z');
- var end = moment.utc('2014-01-01T08:30:00Z');
- var interval = { name: 'hours', startOf: 'hour', display: 'Hourly' };
- var list = intervals.toIndexList('[logstash-]YYYY.MM.DD.HH', interval, start, end);
+ let start = moment.utc('2014-01-01T07:00:00Z');
+ let end = moment.utc('2014-01-01T08:30:00Z');
+ let interval = { name: 'hours', startOf: 'hour', display: 'Hourly' };
+ let list = intervals.toIndexList('[logstash-]YYYY.MM.DD.HH', interval, start, end);
expect(list).to.eql([
{
index: 'logstash-2014.01.01.07',
@@ -33,10 +33,10 @@ describe('Index Patterns', function () {
});
it('should return correct indices for daily [logstash-]YYYY.MM.DD', function () {
- var start = moment(1418244231248);
- var end = moment(1418849261281);
- var interval = { name: 'days', startOf: 'day', display: 'Daily' };
- var list = intervals.toIndexList('[logstash-]YYYY.MM.DD', interval, start, end);
+ let start = moment(1418244231248);
+ let end = moment(1418849261281);
+ let interval = { name: 'days', startOf: 'day', display: 'Daily' };
+ let list = intervals.toIndexList('[logstash-]YYYY.MM.DD', interval, start, end);
expect(list).to.eql([
{
index: 'logstash-2014.12.10',
@@ -82,10 +82,10 @@ describe('Index Patterns', function () {
});
it('should return correct indices for monthly [logstash-]YYYY.MM', function () {
- var start = moment.utc('2014-12-01');
- var end = moment.utc('2015-02-01');
- var interval = { name: 'months', startOf: 'month', display: 'Monthly' };
- var list = intervals.toIndexList('[logstash-]YYYY.MM', interval, start, end);
+ let start = moment.utc('2014-12-01');
+ let end = moment.utc('2015-02-01');
+ let interval = { name: 'months', startOf: 'month', display: 'Monthly' };
+ let list = intervals.toIndexList('[logstash-]YYYY.MM', interval, start, end);
expect(list).to.eql([
{
index: 'logstash-2014.12',
@@ -106,10 +106,10 @@ describe('Index Patterns', function () {
});
it('should return correct indices for yearly [logstash-]YYYY', function () {
- var start = moment.utc('2014-12-01');
- var end = moment.utc('2015-02-01');
- var interval = { name: 'years', startOf: 'year', display: 'Yearly' };
- var list = intervals.toIndexList('[logstash-]YYYY', interval, start, end);
+ let start = moment.utc('2014-12-01');
+ let end = moment.utc('2015-02-01');
+ let interval = { name: 'years', startOf: 'year', display: 'Yearly' };
+ let list = intervals.toIndexList('[logstash-]YYYY', interval, start, end);
expect(list).to.eql([
{
index: 'logstash-2014',
@@ -126,10 +126,10 @@ describe('Index Patterns', function () {
context('with sortDirection=asc', function () {
it('returns values in ascending order', function () {
- var start = moment.utc('2014-12-01');
- var end = moment.utc('2015-02-01');
- var interval = { name: 'years', startOf: 'year', display: 'Yearly' };
- var list = intervals.toIndexList('[logstash-]YYYY', interval, start, end, 'asc');
+ let start = moment.utc('2014-12-01');
+ let end = moment.utc('2015-02-01');
+ let interval = { name: 'years', startOf: 'year', display: 'Yearly' };
+ let list = intervals.toIndexList('[logstash-]YYYY', interval, start, end, 'asc');
expect(list).to.eql([
{
index: 'logstash-2014',
@@ -147,10 +147,10 @@ describe('Index Patterns', function () {
context('with sortDirection=desc', function () {
it('returns values in descending order', function () {
- var start = moment.utc('2014-12-01');
- var end = moment.utc('2015-02-01');
- var interval = { name: 'years', startOf: 'year', display: 'Yearly' };
- var list = intervals.toIndexList('[logstash-]YYYY', interval, start, end, 'desc');
+ let start = moment.utc('2014-12-01');
+ let end = moment.utc('2015-02-01');
+ let interval = { name: 'years', startOf: 'year', display: 'Yearly' };
+ let list = intervals.toIndexList('[logstash-]YYYY', interval, start, end, 'desc');
expect(list).to.eql([
{
index: 'logstash-2015',
diff --git a/src/ui/public/indexed_array/__tests__/indexed_array.js b/src/ui/public/indexed_array/__tests__/indexed_array.js
index f0ee09fc1fce5..69820fbe8bba4 100644
--- a/src/ui/public/indexed_array/__tests__/indexed_array.js
+++ b/src/ui/public/indexed_array/__tests__/indexed_array.js
@@ -4,7 +4,7 @@ import expect from 'expect.js';
import IndexedArray from 'ui/indexed_array';
// this is generally a data-structure that IndexedArray is good for managing
-var users = [
+let users = [
{ name: 'John', id: 69, username: 'beast', group: 'admins' },
{ name: 'Anon', id: 0, username: 'shhhh', group: 'secret' },
{ name: 'Fern', id: 42, username: 'kitty', group: 'editor' },
@@ -43,7 +43,7 @@ describe('IndexedArray', function () {
describe('Indexing', function () {
it('provides the initial set', function () {
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
initialSet: [1, 2, 3]
});
@@ -55,7 +55,7 @@ describe('IndexedArray', function () {
});
it('indexes the initial set', function () {
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
index: ['username'],
initialSet: users
});
@@ -66,11 +66,11 @@ describe('IndexedArray', function () {
it('updates indices after values are added', function () {
// split up the user list, and add it in chunks
- var firstUser = users.slice(0, 1).pop();
- var otherUsers = users.slice(1);
+ let firstUser = users.slice(0, 1).pop();
+ let otherUsers = users.slice(1);
// start off with all but the first
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
group: ['group'],
order: ['id'],
initialSet: otherUsers
@@ -86,7 +86,7 @@ describe('IndexedArray', function () {
it('updates indices after values are removed', function () {
// start off with all
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
group: ['group'],
order: ['id'],
initialSet: users
@@ -95,18 +95,18 @@ describe('IndexedArray', function () {
// remove the last
reg.pop();
- var expectedCount = users.length - 1;
+ let expectedCount = users.length - 1;
// indexed lists should be updated
expect(reg).to.have.length(expectedCount);
- var sumOfGroups = _.reduce(reg.byGroup, function (note, group) {
+ let sumOfGroups = _.reduce(reg.byGroup, function (note, group) {
return note + group.length;
}, 0);
expect(sumOfGroups).to.eql(expectedCount);
});
it('removes items based on a predicate', function () {
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
group: ['group'],
order: ['id'],
initialSet: users
@@ -120,26 +120,26 @@ describe('IndexedArray', function () {
});
it('updates indices after values are re-ordered', function () {
- var rawUsers = users.slice(0);
+ let rawUsers = users.slice(0);
// collect and shuffle the ids available
- var ids = [];
+ let ids = [];
_.times(rawUsers.length, function (i) { ids.push(i); });
ids = _.shuffle(ids);
// move something here
- var toI = ids.shift();
+ let toI = ids.shift();
// from here
- var fromI = ids.shift();
+ let fromI = ids.shift();
// do the move
- var move = function (arr) { arr.splice(toI, 0, arr.splice(fromI, 1)[0]); };
+ let move = function (arr) { arr.splice(toI, 0, arr.splice(fromI, 1)[0]); };
- var reg = new IndexedArray({
+ let reg = new IndexedArray({
index: ['username'],
initialSet: rawUsers
});
- var index = reg.byUsername;
+ let index = reg.byUsername;
move(reg);
diff --git a/src/ui/public/indexed_array/__tests__/inflector.js b/src/ui/public/indexed_array/__tests__/inflector.js
index 6af57d8ce99c1..3fc45e1a9f974 100644
--- a/src/ui/public/indexed_array/__tests__/inflector.js
+++ b/src/ui/public/indexed_array/__tests__/inflector.js
@@ -3,13 +3,13 @@ import expect from 'expect.js';
describe('IndexedArray Inflector', function () {
it('returns a function', function () {
- var getter = inflector();
+ let getter = inflector();
expect(getter).to.be.a('function');
});
describe('fn', function () {
it('prepends a prefix', function () {
- var inflect = inflector('my');
+ let inflect = inflector('my');
expect(inflect('Family')).to.be('myFamily');
expect(inflect('family')).to.be('myFamily');
@@ -17,7 +17,7 @@ describe('IndexedArray Inflector', function () {
});
it('adds both a prefix and suffix', function () {
- var inflect = inflector('foo', 'Bar');
+ let inflect = inflector('foo', 'Bar');
expect(inflect('box')).to.be('fooBoxBar');
expect(inflect('box.car.MAX')).to.be('fooBoxCarMaxBar');
@@ -25,19 +25,19 @@ describe('IndexedArray Inflector', function () {
});
it('ignores prefix if it is already at the end of the inflected string', function () {
- var inflect = inflector('foo', 'Bar');
+ let inflect = inflector('foo', 'Bar');
expect(inflect('fooBox')).to.be('fooBoxBar');
expect(inflect('FooBox')).to.be('FooBoxBar');
});
it('ignores postfix if it is already at the end of the inflected string', function () {
- var inflect = inflector('foo', 'Bar');
+ let inflect = inflector('foo', 'Bar');
expect(inflect('bar')).to.be('fooBar');
expect(inflect('showBoxBar')).to.be('fooShowBoxBar');
});
it('works with "name"', function () {
- var inflect = inflector('in', 'Order');
+ let inflect = inflector('in', 'Order');
expect(inflect('name')).to.be('inNameOrder');
});
});
diff --git a/src/ui/public/jquery/__tests__/find_test_subject.js b/src/ui/public/jquery/__tests__/find_test_subject.js
index 0bc06bca17358..7a70ec05bd2a1 100644
--- a/src/ui/public/jquery/__tests__/find_test_subject.js
+++ b/src/ui/public/jquery/__tests__/find_test_subject.js
@@ -7,42 +7,42 @@ function $make(subject) {
describe('jQuery.findTestSubject', function () {
it('finds all of the element with a subject', function () {
- var $container = $('
');
- var $match = $make('subject').appendTo($container);
- var $noMatch = $make('notSubject').appendTo($container);
+ let $container = $('
');
+ let $match = $make('subject').appendTo($container);
+ let $noMatch = $make('notSubject').appendTo($container);
- var $found = $container.findTestSubject('subject');
+ let $found = $container.findTestSubject('subject');
expect($found.is($match)).to.be(true);
expect($found.is($noMatch)).to.be(false);
});
it('finds multiple elements with a subject', function () {
- var $container = $('
');
- var $match = $make('subject').appendTo($container);
- var $otherMatch = $make('subject').appendTo($container);
+ let $container = $('
');
+ let $match = $make('subject').appendTo($container);
+ let $otherMatch = $make('subject').appendTo($container);
- var $found = $container.findTestSubject('subject');
+ let $found = $container.findTestSubject('subject');
expect($found.filter($match).size()).to.be(1);
expect($found.filter($otherMatch).size()).to.be(1);
});
it('finds all of the elements with either subject', function () {
- var $container = $('
');
- var $match1 = $make('subject').appendTo($container);
- var $match2 = $make('alsoSubject').appendTo($container);
- var $noMatch = $make('notSubject').appendTo($container);
+ let $container = $('
');
+ let $match1 = $make('subject').appendTo($container);
+ let $match2 = $make('alsoSubject').appendTo($container);
+ let $noMatch = $make('notSubject').appendTo($container);
- var $found = $container.findTestSubject('subject', 'alsoSubject');
+ let $found = $container.findTestSubject('subject', 'alsoSubject');
expect($found.filter($match1).size()).to.be(1);
expect($found.filter($match2).size()).to.be(1);
expect($found.filter($noMatch).size()).to.be(0);
});
it('finds all of the elements with a decendant selector', function () {
- var $container = $('
');
- var $parent = $make('foo name').appendTo($container);
- var $bar = $make('bar othername').appendTo($parent);
- var $baz = $make('baz third name').appendTo($parent);
+ let $container = $('
');
+ let $parent = $make('foo name').appendTo($container);
+ let $bar = $make('bar othername').appendTo($parent);
+ let $baz = $make('baz third name').appendTo($parent);
expect($container.findTestSubject('foo bar').is($bar)).to.be(true);
expect($container.findTestSubject('foo bar').is($baz)).to.be(false);
@@ -52,9 +52,9 @@ describe('jQuery.findTestSubject', function () {
});
it('finds elements with compound subjects', function () {
- var $container = $('
');
- var $bar = $make('button bar').appendTo($container);
- var $baz = $make('button baz').appendTo($container);
+ let $container = $('
');
+ let $bar = $make('button bar').appendTo($container);
+ let $baz = $make('button baz').appendTo($container);
expect($container.findTestSubject('button&bar').is($bar)).to.be(true);
expect($container.findTestSubject('button& bar').is($bar)).to.be(true);
diff --git a/src/ui/public/listen/__tests__/listen.js b/src/ui/public/listen/__tests__/listen.js
index 261139420b4cf..a4dcae53d176d 100644
--- a/src/ui/public/listen/__tests__/listen.js
+++ b/src/ui/public/listen/__tests__/listen.js
@@ -22,8 +22,8 @@ describe('listen component', function () {
});
it('binds to an event emitter', function () {
- var emitter = new Events();
- var $scope = $rootScope.$new();
+ let emitter = new Events();
+ let $scope = $rootScope.$new();
function handler() {}
$scope.$listen(emitter, 'hello', handler);
@@ -33,8 +33,8 @@ describe('listen component', function () {
});
it('binds to $scope, waiting for the destroy event', function () {
- var emitter = new Events();
- var $scope = $rootScope.$new();
+ let emitter = new Events();
+ let $scope = $rootScope.$new();
sinon.stub($scope, '$on');
sinon.stub($rootScope, '$on');
@@ -45,14 +45,14 @@ describe('listen component', function () {
expect($rootScope.$on).to.have.property('callCount', 0);
expect($scope.$on).to.have.property('callCount', 1);
- var call = $scope.$on.firstCall;
+ let call = $scope.$on.firstCall;
expect(call.args[0]).to.be('$destroy');
expect(call.args[1]).to.be.a('function');
});
it('unbinds the event handler when $destroy is triggered', function () {
- var emitter = new Events();
- var $scope = $rootScope.$new();
+ let emitter = new Events();
+ let $scope = $rootScope.$new();
sinon.stub($scope, '$on');
sinon.stub(emitter, 'off');
@@ -62,7 +62,7 @@ describe('listen component', function () {
$scope.$listen(emitter, 'hello', handler);
// get the unbinder that was registered to $scope
- var unbinder = $scope.$on.firstCall.args[1];
+ let unbinder = $scope.$on.firstCall.args[1];
// call the unbinder
expect(emitter.off).to.have.property('callCount', 0);
@@ -70,7 +70,7 @@ describe('listen component', function () {
expect(emitter.off).to.have.property('callCount', 1);
// check that the off args were as expected
- var call = emitter.off.firstCall;
+ let call = emitter.off.firstCall;
expect(call.args[0]).to.be('hello');
expect(call.args[1]).to.be(handler);
});
diff --git a/src/ui/public/navbar_extensions/__tests__/navbar_extensions.js b/src/ui/public/navbar_extensions/__tests__/navbar_extensions.js
index 8f2e78652e701..04518f44d5387 100644
--- a/src/ui/public/navbar_extensions/__tests__/navbar_extensions.js
+++ b/src/ui/public/navbar_extensions/__tests__/navbar_extensions.js
@@ -69,7 +69,7 @@ describe('navbar-extensions directive', function () {
it('should append to end then order == 0', function () {
registerExtension({ order: 0 });
- var $el = init();
+ let $el = init();
expect($el.find('button').last().hasClass('test-button')).to.be.ok();
});
@@ -96,7 +96,7 @@ describe('navbar-extensions directive', function () {
`
});
- var $el = init();
+ let $el = init();
expect($el.find('button').length).to.equal(3);
expect($el.find('button').last().hasClass('test-button-2')).to.be.ok();
diff --git a/src/ui/public/notify/__tests__/lib/_format_es_msg.js b/src/ui/public/notify/__tests__/lib/_format_es_msg.js
index 2a9a2cae4526a..5b89a909386bc 100644
--- a/src/ui/public/notify/__tests__/lib/_format_es_msg.js
+++ b/src/ui/public/notify/__tests__/lib/_format_es_msg.js
@@ -3,23 +3,23 @@ import expect from 'expect.js';
describe('formatESMsg', function () {
it('should return undefined if passed a basic error', function () {
- var err = new Error('This is a normal error');
+ let err = new Error('This is a normal error');
- var actual = formatESMsg(err);
+ let actual = formatESMsg(err);
expect(actual).to.be(undefined);
});
it('should return undefined if passed a string', function () {
- var err = 'This is a error string';
+ let err = 'This is a error string';
- var actual = formatESMsg(err);
+ let actual = formatESMsg(err);
expect(actual).to.be(undefined);
});
it('should return the root_cause if passed an extended elasticsearch', function () {
- var err = new Error('This is an elasticsearch error');
+ let err = new Error('This is an elasticsearch error');
err.resp = {
error : {
root_cause : [
@@ -30,13 +30,13 @@ describe('formatESMsg', function () {
}
};
- var actual = formatESMsg(err);
+ let actual = formatESMsg(err);
expect(actual).to.equal('I am the detailed message');
});
it('should combine the reason messages if more than one is returned.', function () {
- var err = new Error('This is an elasticsearch error');
+ let err = new Error('This is an elasticsearch error');
err.resp = {
error : {
root_cause : [
@@ -50,7 +50,7 @@ describe('formatESMsg', function () {
}
};
- var actual = formatESMsg(err);
+ let actual = formatESMsg(err);
expect(actual).to.equal('I am the detailed message 1\nI am the detailed message 2');
});
diff --git a/src/ui/public/notify/__tests__/lib/_format_msg.js b/src/ui/public/notify/__tests__/lib/_format_msg.js
index 393a44f2ddbd8..725fd6a518d73 100644
--- a/src/ui/public/notify/__tests__/lib/_format_msg.js
+++ b/src/ui/public/notify/__tests__/lib/_format_msg.js
@@ -3,26 +3,26 @@ import expect from 'expect.js';
describe('formatMsg', function () {
it('should prepend the second argument to result', function () {
- var actual = formatMsg('error message', 'unit_test');
+ let actual = formatMsg('error message', 'unit_test');
expect(actual).to.equal('unit_test: error message');
});
it('should handle a simple string', function () {
- var actual = formatMsg('error message');
+ let actual = formatMsg('error message');
expect(actual).to.equal('error message');
});
it('should handle a simple Error object', function () {
- var err = new Error('error message');
- var actual = formatMsg(err);
+ let err = new Error('error message');
+ let actual = formatMsg(err);
expect(actual).to.equal('error message');
});
it('should handle a simple Angular $http error object', function () {
- var err = {
+ let err = {
data: {
statusCode: 403,
error: 'Forbidden',
@@ -32,13 +32,13 @@ describe('formatMsg', function () {
config: {},
statusText: 'Forbidden'
};
- var actual = formatMsg(err);
+ let actual = formatMsg(err);
expect(actual).to.equal('Error 403 Forbidden: [security_exception] action [indices:data/read/mget] is unauthorized for user [user]');
});
it('should handle an extended elasticsearch error', function () {
- var err = {
+ let err = {
resp : {
error : {
root_cause : [
@@ -50,7 +50,7 @@ describe('formatMsg', function () {
}
};
- var actual = formatMsg(err);
+ let actual = formatMsg(err);
expect(actual).to.equal('I am the detailed message');
});
diff --git a/src/ui/public/notify/__tests__/notifier.js b/src/ui/public/notify/__tests__/notifier.js
index 7c180c3580c8d..6416683902929 100644
--- a/src/ui/public/notify/__tests__/notifier.js
+++ b/src/ui/public/notify/__tests__/notifier.js
@@ -6,11 +6,11 @@ import Notifier from 'ui/notify/notifier';
describe('Notifier', function () {
let $interval;
- var message = 'Oh, the humanity!';
+ let message = 'Oh, the humanity!';
let notifier;
let params;
- var version = window.__KBN__.version;
- var buildNum = window.__KBN__.buildNum;
+ let version = window.__KBN__.version;
+ let buildNum = window.__KBN__.buildNum;
beforeEach(function () {
ngMock.module('kibana');
@@ -56,7 +56,7 @@ describe('Notifier', function () {
});
it('sets timeRemaining and decrements', function () {
- var notif = notify('error');
+ let notif = notify('error');
expect(notif.timeRemaining).to.equal(300);
$interval.flush(1000);
@@ -64,8 +64,8 @@ describe('Notifier', function () {
});
it('closes notification on lifetime expiry', function () {
- var expectation = sinon.mock();
- var notif = notifier.error(message, expectation);
+ let expectation = sinon.mock();
+ let notif = notifier.error(message, expectation);
expectation.once();
expectation.withExactArgs('ignore');
@@ -76,7 +76,7 @@ describe('Notifier', function () {
});
it('allows canceling of timer', function () {
- var notif = notify('error');
+ let notif = notify('error');
expect(notif.timerId).to.not.be(undefined);
notif.cancelTimer();
@@ -85,7 +85,7 @@ describe('Notifier', function () {
});
it('resets timer on addition to stack', function () {
- var notif = notify('error');
+ let notif = notify('error');
$interval.flush(100000);
expect(notif.timeRemaining).to.equal(200);
@@ -95,12 +95,12 @@ describe('Notifier', function () {
});
it('allows reporting', function () {
- var includesReport = _.includes(notify('error').actions, 'report');
+ let includesReport = _.includes(notify('error').actions, 'report');
expect(includesReport).to.true;
});
it('allows accepting', function () {
- var includesAccept = _.includes(notify('error').actions, 'accept');
+ let includesAccept = _.includes(notify('error').actions, 'accept');
expect(includesAccept).to.true;
});
@@ -133,12 +133,12 @@ describe('Notifier', function () {
});
it('does not allow reporting', function () {
- var includesReport = _.includes(notify('warning').actions, 'report');
+ let includesReport = _.includes(notify('warning').actions, 'report');
expect(includesReport).to.false;
});
it('allows accepting', function () {
- var includesAccept = _.includes(notify('warning').actions, 'accept');
+ let includesAccept = _.includes(notify('warning').actions, 'accept');
expect(includesAccept).to.true;
});
@@ -171,12 +171,12 @@ describe('Notifier', function () {
});
it('does not allow reporting', function () {
- var includesReport = _.includes(notify('info').actions, 'report');
+ let includesReport = _.includes(notify('info').actions, 'report');
expect(includesReport).to.false;
});
it('allows accepting', function () {
- var includesAccept = _.includes(notify('info').actions, 'accept');
+ let includesAccept = _.includes(notify('info').actions, 'accept');
expect(includesAccept).to.true;
});
@@ -197,13 +197,13 @@ describe('Notifier', function () {
function testVersionInfo(fnName) {
context('when version is configured', function () {
it('adds version to notification', function () {
- var notification = notify(fnName);
+ let notification = notify(fnName);
expect(notification.info.version).to.equal(version);
});
});
context('when build number is configured', function () {
it('adds buildNum to notification', function () {
- var notification = notify(fnName);
+ let notification = notify(fnName);
expect(notification.info.buildNum).to.equal(buildNum);
});
});
diff --git a/src/ui/public/paginated_table/__tests__/index.js b/src/ui/public/paginated_table/__tests__/index.js
index cbf6324455b27..5a1c6da246285 100644
--- a/src/ui/public/paginated_table/__tests__/index.js
+++ b/src/ui/public/paginated_table/__tests__/index.js
@@ -13,11 +13,11 @@ describe('paginated table', function () {
let $scope;
let $elScope;
let $orderBy;
- var defaultPerPage = 10;
+ let defaultPerPage = 10;
- var makeData = function (colCount, rowCount) {
- var columns = [];
- var rows = [];
+ let makeData = function (colCount, rowCount) {
+ let columns = [];
+ let rows = [];
if (_.isNumber(colCount)) {
_.times(colCount, function (i) {
@@ -29,7 +29,7 @@ describe('paginated table', function () {
if (_.isNumber(rowCount)) {
_.times(rowCount, function (col) {
- var rowItems = [];
+ let rowItems = [];
_.times(columns.length, function (row) {
rowItems.push('item' + col + row);
@@ -47,7 +47,7 @@ describe('paginated table', function () {
};
};
- var renderTable = function (cols, rows, perPage) {
+ let renderTable = function (cols, rows, perPage) {
$scope.cols = cols || [];
$scope.rows = rows || [];
$scope.perPage = perPage || defaultPerPage;
@@ -67,23 +67,23 @@ describe('paginated table', function () {
describe('rendering', function () {
it('should not display without rows', function () {
- var cols = [{
+ let cols = [{
title: 'test1'
}];
- var rows = [];
+ let rows = [];
renderTable(cols, rows);
expect($el.children().size()).to.be(0);
});
it('should render columns and rows', function () {
- var data = makeData(2, 2);
- var cols = data.columns;
- var rows = data.rows;
+ let data = makeData(2, 2);
+ let cols = data.columns;
+ let rows = data.rows;
renderTable(cols, rows);
expect($el.children().size()).to.be(1);
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
// should pad rows
expect(tableRows.size()).to.be(defaultPerPage);
// should contain the row data
@@ -95,13 +95,13 @@ describe('paginated table', function () {
it('should paginate rows', function () {
// note: paginate truncates pages, so don't make too many
- var rowCount = _.random(16, 24);
- var perPageCount = _.random(5, 8);
- var data = makeData(3, rowCount);
- var pageCount = Math.ceil(rowCount / perPageCount);
+ let rowCount = _.random(16, 24);
+ let perPageCount = _.random(5, 8);
+ let data = makeData(3, rowCount);
+ let pageCount = Math.ceil(rowCount / perPageCount);
renderTable(data.columns, data.rows, perPageCount);
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.size()).to.be(perPageCount);
// add 2 for the first and last page links
expect($el.find('paginate-controls a').size()).to.be(pageCount + 2);
@@ -131,7 +131,7 @@ describe('paginated table', function () {
// });
it('should not sort by default', function () {
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be(data.rows[0][0]);
expect(tableRows.eq(lastRowIndex).find('td').eq(0).text()).to.be(data.rows[lastRowIndex][0]);
});
@@ -141,7 +141,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(999);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('bbbb');
expect(tableRows.eq(0).find('td').eq(1).text()).to.be('aaaa');
expect(tableRows.eq(0).find('td').eq(2).text()).to.be('zzzz');
@@ -154,7 +154,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(0);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('bbbb');
expect(tableRows.eq(0).find('td').eq(1).text()).to.be('aaaa');
expect(tableRows.eq(0).find('td').eq(2).text()).to.be('zzzz');
@@ -165,7 +165,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(0);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('aaaa');
expect(tableRows.eq(lastRowIndex).find('td').eq(0).text()).to.be('zzzz');
});
@@ -176,7 +176,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(0);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('zzzz');
expect(tableRows.eq(lastRowIndex).find('td').eq(0).text()).to.be('aaaa');
});
@@ -188,7 +188,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(0);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be(data.rows[0][0]);
expect(tableRows.eq(lastRowIndex).find('td').eq(0).text()).to.be('aaaa');
});
@@ -202,7 +202,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(1);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(1).text()).to.be('aaaa');
expect(tableRows.eq(lastRowIndex).find('td').eq(1).text()).to.be('zzzz');
});
@@ -212,15 +212,15 @@ describe('paginated table', function () {
describe('sorting duplicate columns', function () {
let data;
let paginatedTable;
- var colText = 'test row';
+ let colText = 'test row';
beforeEach(function () {
- var cols = [
+ let cols = [
{ title: colText },
{ title: colText },
{ title: colText }
];
- var rows = [
+ let rows = [
['bbbb', 'aaaa', 'zzzz'],
['cccc', 'cccc', 'aaaa'],
['zzzz', 'bbbb', 'bbbb'],
@@ -233,7 +233,7 @@ describe('paginated table', function () {
});
it('should have duplicate column titles', function () {
- var columns = $el.find('thead th span');
+ let columns = $el.find('thead th span');
columns.each(function () {
expect($(this).text()).to.be(colText);
});
@@ -244,7 +244,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(2);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('cccc');
expect(tableRows.eq(0).find('td').eq(1).text()).to.be('cccc');
expect(tableRows.eq(0).find('td').eq(2).text()).to.be('aaaa');
@@ -258,7 +258,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(2);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('td').eq(0).text()).to.be('cccc');
expect(tableRows.eq(0).find('td').eq(1).text()).to.be('cccc');
expect(tableRows.eq(0).find('td').eq(2).text()).to.be('aaaa');
@@ -281,7 +281,7 @@ describe('paginated table', function () {
paginatedTable.sortColumn(1);
$scope.$digest();
- var sorters = $el.find('thead th i');
+ let sorters = $el.find('thead th i');
expect(sorters.eq(0).hasClass('fa-sort')).to.be(true);
expect(sorters.eq(1).hasClass('fa-sort')).to.be(false);
expect(sorters.eq(2).hasClass('fa-sort')).to.be(true);
@@ -311,7 +311,7 @@ describe('paginated table', function () {
// TODO: This is failing randomly
it('should allow custom sorting handler', function () {
- var columnIndex = 1;
+ let columnIndex = 1;
paginatedTable.sortColumn(columnIndex);
$scope.$digest();
expect(sortHandler.callCount).to.be(1);
@@ -341,7 +341,7 @@ describe('paginated table', function () {
});
it('should append object markup', function () {
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('h1').size()).to.be(0);
expect(tableRows.eq(1).find('h1').size()).to.be(1);
expect(tableRows.eq(2).find('h1').size()).to.be(0);
@@ -350,7 +350,7 @@ describe('paginated table', function () {
it('should sort using object value', function () {
paginatedTable.sortColumn(0);
$scope.$digest();
- var tableRows = $el.find('tbody tr');
+ let tableRows = $el.find('tbody tr');
expect(tableRows.eq(0).find('h1').size()).to.be(0);
expect(tableRows.eq(1).find('h1').size()).to.be(0);
// html row should be the last row
diff --git a/src/ui/public/persisted_log/__tests__/persisted_log.js b/src/ui/public/persisted_log/__tests__/persisted_log.js
index 41ad7e078a3b7..11115f087e6f8 100644
--- a/src/ui/public/persisted_log/__tests__/persisted_log.js
+++ b/src/ui/public/persisted_log/__tests__/persisted_log.js
@@ -8,9 +8,9 @@ let storage;
let config;
let PersistedLog;
-var historyName = 'testHistory';
-var historyLimit = 10;
-var payload = [
+let historyName = 'testHistory';
+let historyLimit = 10;
+let payload = [
{ first: 'clark', last: 'kent' },
{ first: 'peter', last: 'parker' },
{ first: 'bruce', last: 'wayne' }
@@ -41,7 +41,7 @@ describe('PersistedLog', function () {
describe('expected API', function () {
it('has expected methods', function () {
- var log = new PersistedLog(historyName);
+ let log = new PersistedLog(historyName);
expect(log.add).to.be.a('function');
expect(log.get).to.be.a('function');
@@ -50,17 +50,17 @@ describe('PersistedLog', function () {
describe('internal functionality', function () {
it('reads from storage', function () {
- var log = new PersistedLog(historyName);
+ let log = new PersistedLog(historyName);
expect(storage.get.calledOnce).to.be(true);
expect(storage.get.calledWith(historyName)).to.be(true);
});
it('writes to storage', function () {
- var log = new PersistedLog(historyName);
- var newItem = { first: 'diana', last: 'prince' };
+ let log = new PersistedLog(historyName);
+ let newItem = { first: 'diana', last: 'prince' };
- var data = log.add(newItem);
+ let data = log.add(newItem);
expect(storage.set.calledOnce).to.be(true);
expect(data).to.eql([newItem]);
@@ -70,19 +70,19 @@ describe('PersistedLog', function () {
describe('persisting data', function () {
it('fetches records from storage', function () {
storage.get.returns(payload);
- var log = new PersistedLog(historyName);
+ let log = new PersistedLog(historyName);
- var items = log.get();
+ let items = log.get();
expect(items.length).to.equal(3);
expect(items).to.eql(payload);
});
it('prepends new records', function () {
storage.get.returns(payload.slice(0));
- var log = new PersistedLog(historyName);
- var newItem = { first: 'selina', last: 'kyle' };
+ let log = new PersistedLog(historyName);
+ let newItem = { first: 'selina', last: 'kyle' };
- var items = log.add(newItem);
+ let items = log.add(newItem);
expect(items.length).to.equal(payload.length + 1);
expect(items[0]).to.eql(newItem);
});
@@ -90,26 +90,26 @@ describe('PersistedLog', function () {
describe('stack options', function () {
it('should observe the maxLength option', function () {
- var bulkData = [];
+ let bulkData = [];
- for (var i = 0; i < historyLimit; i++) {
+ for (let i = 0; i < historyLimit; i++) {
bulkData.push(['record ' + i]);
}
storage.get.returns(bulkData);
- var log = new PersistedLog(historyName, { maxLength: historyLimit });
+ let log = new PersistedLog(historyName, { maxLength: historyLimit });
log.add(['new array 1']);
- var items = log.add(['new array 2']);
+ let items = log.add(['new array 2']);
expect(items.length).to.equal(historyLimit);
});
it('should observe the filterDuplicates option', function () {
storage.get.returns(payload.slice(0));
- var log = new PersistedLog(historyName, { filterDuplicates: true });
- var newItem = payload[1];
+ let log = new PersistedLog(historyName, { filterDuplicates: true });
+ let newItem = payload[1];
- var items = log.add(newItem);
+ let items = log.add(newItem);
expect(items.length).to.equal(payload.length);
});
diff --git a/src/ui/public/persisted_state/__tests__/persisted_state.js b/src/ui/public/persisted_state/__tests__/persisted_state.js
index e79f36a3bac97..af6a2deb3c9cf 100644
--- a/src/ui/public/persisted_state/__tests__/persisted_state.js
+++ b/src/ui/public/persisted_state/__tests__/persisted_state.js
@@ -36,7 +36,7 @@ describe('Persisted State', function () {
});
it('should create a state instance with data', function () {
- var val = { red: 'blue' };
+ let val = { red: 'blue' };
persistedState = new PersistedState(val);
expect(persistedState.get()).to.eql(val);
@@ -45,7 +45,7 @@ describe('Persisted State', function () {
});
it('should create a copy of the state passed in', function () {
- var val = { red: 'blue' };
+ let val = { red: 'blue' };
persistedState = new PersistedState(val);
expect(persistedState.get()).to.eql(val);
@@ -53,10 +53,10 @@ describe('Persisted State', function () {
});
it('should not throw if creating valid child object', function () {
- var run = function () {
- var val = { red: 'blue' };
- var path = ['test.path'];
- var parent = new PersistedState();
+ let run = function () {
+ let val = { red: 'blue' };
+ let path = ['test.path'];
+ let parent = new PersistedState();
new PersistedState(val, path, parent);
};
@@ -64,8 +64,8 @@ describe('Persisted State', function () {
});
it('should throw if given an invalid value', function () {
- var run = function () {
- var val = 'bananas';
+ let run = function () {
+ let val = 'bananas';
new PersistedState(val);
};
@@ -75,10 +75,10 @@ describe('Persisted State', function () {
});
it('should not throw if given primitive to child', function () {
- var run = function () {
- var val = 'bananas';
- var path = ['test.path'];
- var parent = new PersistedState();
+ let run = function () {
+ let val = 'bananas';
+ let path = ['test.path'];
+ let parent = new PersistedState();
new PersistedState(val, path, parent);
};
@@ -86,10 +86,10 @@ describe('Persisted State', function () {
});
it('should throw if given an invalid parent object', function () {
- var run = function () {
- var val = { red: 'blue' };
- var path = ['test.path'];
- var parent = {};
+ let run = function () {
+ let val = { red: 'blue' };
+ let path = ['test.path'];
+ let parent = {};
new PersistedState(val, path, parent);
};
@@ -99,10 +99,10 @@ describe('Persisted State', function () {
});
it('should throw if given a parent without a path', function () {
- var run = function () {
- var val = { red: 'blue' };
+ let run = function () {
+ let val = { red: 'blue' };
let path;
- var parent = new PersistedState();
+ let parent = new PersistedState();
new PersistedState(val, path, parent);
};
@@ -117,8 +117,8 @@ describe('Persisted State', function () {
let childState;
it('should not append the child state to the parent, without parent value', function () {
- var childIndex = 'i can haz child';
- var persistedState = new PersistedState();
+ let childIndex = 'i can haz child';
+ let persistedState = new PersistedState();
childState = persistedState.createChild(childIndex);
// parent state should not contain the child state
@@ -127,9 +127,9 @@ describe('Persisted State', function () {
});
it('should not append the child state to the parent, with parent value', function () {
- var childIndex = 'i can haz child';
- var persistedStateValue = { original: true };
- var persistedState = new PersistedState(persistedStateValue);
+ let childIndex = 'i can haz child';
+ let persistedStateValue = { original: true };
+ let persistedState = new PersistedState(persistedStateValue);
childState = persistedState.createChild(childIndex);
// child state should be empty, we didn't give it any default data
@@ -141,14 +141,14 @@ describe('Persisted State', function () {
});
it('should append the child state to the parent, with parent and child values', function () {
- var childIndex = 'i can haz child';
- var childStateValue = { tacos: 'yes please' };
- var persistedStateValue = { original: true };
- var persistedState = new PersistedState(persistedStateValue);
+ let childIndex = 'i can haz child';
+ let childStateValue = { tacos: 'yes please' };
+ let persistedStateValue = { original: true };
+ let persistedState = new PersistedState(persistedStateValue);
childState = persistedState.createChild(childIndex, childStateValue);
// parent state should contain the child and its original state value
- var parentState = persistedState.get();
+ let parentState = persistedState.get();
expect(parentState).to.have.property('original', true);
expect(parentState).to.have.property(childIndex);
expect(parentState[childIndex]).to.eql(childStateValue);
@@ -157,15 +157,15 @@ describe('Persisted State', function () {
describe('deep child state creation', function () {
it('should delegate get/set calls to parent state', function () {
- var children = [{
+ let children = [{
path: 'first*child',
value: { first: true, second: false }
}, {
path: 'second child',
value: { first: false, second: true }
}];
- var persistedStateValue = { original: true };
- var persistedState = new PersistedState(persistedStateValue);
+ let persistedStateValue = { original: true };
+ let persistedState = new PersistedState(persistedStateValue);
// first child is a child of the parent persistedState
children[0].instance = persistedState.createChild(children[0].path, children[0].value);
@@ -176,7 +176,7 @@ describe('Persisted State', function () {
expect(children[1].instance.get()).to.eql(children[1].value);
// parent should contain original props and first child path, but not the second child path
- var parentState = persistedState.get();
+ let parentState = persistedState.get();
_.keys(persistedStateValue).forEach(function (key) {
expect(parentState).to.have.property(key);
});
@@ -184,28 +184,28 @@ describe('Persisted State', function () {
expect(parentState).to.not.have.property(children[1].path);
// second child path should be inside the first child
- var firstChildState = children[0].instance.get();
+ let firstChildState = children[0].instance.get();
expect(firstChildState).to.have.property(children[1].path);
expect(firstChildState[children[1].path]).to.eql(children[1].value);
// check that the second child is still accessible from the parent instance
- var firstChild = persistedState.get(children[0].path);
+ let firstChild = persistedState.get(children[0].path);
expect(firstChild).to.have.property(children[1].path);
});
});
describe('child state removal', function () {
it('should clear path from parent state', function () {
- var persistedState = new PersistedState();
- var childState = persistedState.createChild('child', { userId: 1234 });
+ let persistedState = new PersistedState();
+ let childState = persistedState.createChild('child', { userId: 1234 });
expect(persistedState.get()).to.eql({ child: { userId: 1234 }});
persistedState.removeChild('child');
expect(persistedState.get()).to.eql({});
});
it('should reset original parent value at path', function () {
- var persistedState = new PersistedState({ user: 1234 });
- var childState = persistedState.createChild('user', { id: 5678 });
+ let persistedState = new PersistedState({ user: 1234 });
+ let childState = persistedState.createChild('user', { id: 5678 });
expect(persistedState.get()).to.eql({ user: { id: 5678 }});
persistedState.removeChild('user');
@@ -213,8 +213,8 @@ describe('Persisted State', function () {
});
it('should clear changedState', function () {
- var persistedState = new PersistedState({ user: 1234 });
- var childState = persistedState.createChild('user');
+ let persistedState = new PersistedState({ user: 1234 });
+ let childState = persistedState.createChild('user');
childState.set('name', 'user name');
expect(persistedState.getChanges()).to.eql({ user: { name: 'user name' }});
@@ -225,16 +225,16 @@ describe('Persisted State', function () {
describe('deep child state removal', function () {
it('should clear path from parent state', function () {
- var persistedState = new PersistedState();
- var childState = persistedState.createChild('child.state', { userId: 1234 });
+ let persistedState = new PersistedState();
+ let childState = persistedState.createChild('child.state', { userId: 1234 });
expect(persistedState.get()).to.eql({ child: { state: { userId: 1234 }}});
persistedState.removeChild('child.state');
expect(persistedState.get()).to.eql({});
});
it('should reset original parent value at path', function () {
- var persistedState = new PersistedState({ user: { id: 1234 }});
- var childState = persistedState.createChild('user.id', 5678);
+ let persistedState = new PersistedState({ user: { id: 1234 }});
+ let childState = persistedState.createChild('user.id', 5678);
expect(persistedState.get()).to.eql({ user: { id: 5678 }});
persistedState.removeChild('user.id');
@@ -242,8 +242,8 @@ describe('Persisted State', function () {
});
it('should reset original parent other values at path', function () {
- var persistedState = new PersistedState({ user: { name: 'user' }});
- var childState = persistedState.createChild('user.id', 5678);
+ let persistedState = new PersistedState({ user: { name: 'user' }});
+ let childState = persistedState.createChild('user.id', 5678);
expect(persistedState.get()).to.eql({ user: { name: 'user', id: 5678 }});
persistedState.removeChild('user.id');
@@ -251,8 +251,8 @@ describe('Persisted State', function () {
});
it('should clear the changed state', function () {
- var persistedState = new PersistedState({ user: { id: 1234 }});
- var childState = persistedState.createChild('user.name');
+ let persistedState = new PersistedState({ user: { id: 1234 }});
+ let childState = persistedState.createChild('user.name');
childState.set('user name');
expect(persistedState.getChanges()).to.eql({ user: { name: 'user name' }});
@@ -264,8 +264,8 @@ describe('Persisted State', function () {
describe('child state conditions', function () {
it('should be merged with the parent state', function () {
- var parent = new PersistedState({ name: 'test' });
- var child = parent.createChild('child', 'value');
+ let parent = new PersistedState({ name: 'test' });
+ let child = parent.createChild('child', 'value');
expect(parent.get()).to.eql({
name: 'test',
child: 'value'
@@ -285,8 +285,8 @@ describe('Persisted State', function () {
});
it('should give child state precedence', function () {
- var parent = new PersistedState({ user: { id: 1234, name: 'test' }});
- var child = parent.createChild('user', { name: 'child test' });
+ let parent = new PersistedState({ user: { id: 1234, name: 'test' }});
+ let child = parent.createChild('user', { name: 'child test' });
expect(parent.get()).to.eql({
user: {
id: 1234,
@@ -299,8 +299,8 @@ describe('Persisted State', function () {
});
it('should be cleaned up with removeChild', function () {
- var parent = new PersistedState({ name: 'test' });
- var child = parent.createChild('child', 'value');
+ let parent = new PersistedState({ name: 'test' });
+ let child = parent.createChild('child', 'value');
expect(parent.get()).to.eql({
name: 'test',
child: 'value'
@@ -315,16 +315,16 @@ describe('Persisted State', function () {
describe('colliding child paths and parent state values', function () {
it('should not change the child path value by default', function () {
- var childIndex = 'childTest';
- var persistedStateValue = {};
+ let childIndex = 'childTest';
+ let persistedStateValue = {};
persistedStateValue[childIndex] = { overlapping_index: true };
- var persistedState = new PersistedState(persistedStateValue);
- var state = persistedState.get();
+ let persistedState = new PersistedState(persistedStateValue);
+ let state = persistedState.get();
expect(state).to.have.property(childIndex);
expect(state[childIndex]).to.eql(persistedStateValue[childIndex]);
- var childState = persistedState.createChild(childIndex);
+ let childState = persistedState.createChild(childIndex);
expect(childState.get()).to.eql(persistedStateValue[childIndex]);
// make sure the parent state is still the same
@@ -334,21 +334,21 @@ describe('Persisted State', function () {
});
it('should merge default child state', function () {
- var childIndex = 'childTest';
- var childStateValue = { child_index: false };
- var persistedStateValue = {};
+ let childIndex = 'childTest';
+ let childStateValue = { child_index: false };
+ let persistedStateValue = {};
persistedStateValue[childIndex] = { parent_index: true };
- var persistedState = new PersistedState(persistedStateValue);
- var state = persistedState.get();
+ let persistedState = new PersistedState(persistedStateValue);
+ let state = persistedState.get();
expect(state).to.have.property(childIndex);
expect(state[childIndex]).to.eql(persistedStateValue[childIndex]);
// pass in child state value
- var childState = persistedState.createChild(childIndex, childStateValue);
+ let childState = persistedState.createChild(childIndex, childStateValue);
// parent's default state is merged with child state
- var compare = _.merge({}, childStateValue, persistedStateValue[childIndex]);
+ let compare = _.merge({}, childStateValue, persistedStateValue[childIndex]);
expect(childState.get()).to.eql(compare);
state = persistedState.get();
expect(state).to.have.property(childIndex);
@@ -358,11 +358,11 @@ describe('Persisted State', function () {
describe('mutation', function () {
it('should not mutate the internal object', function () {
- var persistedStateValue = { hello: 'world' };
- var insertedObj = { farewell: 'cruel world' };
- var persistedState = new PersistedState(persistedStateValue);
+ let persistedStateValue = { hello: 'world' };
+ let insertedObj = { farewell: 'cruel world' };
+ let persistedState = new PersistedState(persistedStateValue);
- var obj = persistedState.get();
+ let obj = persistedState.get();
_.assign(obj, insertedObj);
expect(obj).to.have.property('farewell');
@@ -379,38 +379,38 @@ describe('Persisted State', function () {
describe('exporting state to JSON', function () {
it('should return the full JSON representation', function () {
- var persistedState = new PersistedState(persistedStateValue);
+ let persistedState = new PersistedState(persistedStateValue);
- var json = persistedState.toJSON();
+ let json = persistedState.toJSON();
expect(json).to.eql(persistedStateValue);
});
it('should return the JSON representation of the child state', function () {
- var persistedState = new PersistedState(persistedStateValue);
- var childState = persistedState.createChild('awesome', { pants: false });
+ let persistedState = new PersistedState(persistedStateValue);
+ let childState = persistedState.createChild('awesome', { pants: false });
expect(childState.toJSON()).to.eql({ pants: false });
// verify JSON output of the parent state
- var parentCompare = _.assign({ awesome: { pants: false }}, persistedStateValue);
+ let parentCompare = _.assign({ awesome: { pants: false }}, persistedStateValue);
expect(persistedState.toJSON()).to.eql(parentCompare);
});
it('should export stringified version of state', function () {
- var persistedState = new PersistedState(persistedStateValue);
- var childState = persistedState.createChild('awesome', { pants: false });
+ let persistedState = new PersistedState(persistedStateValue);
+ let childState = persistedState.createChild('awesome', { pants: false });
- var data = childState.toString();
+ let data = childState.toString();
expect(JSON.parse(data)).to.eql({ pants: false });
// verify JSON output of the parent state
- var parentCompare = _.assign({ awesome: { pants: false }}, persistedStateValue);
+ let parentCompare = _.assign({ awesome: { pants: false }}, persistedStateValue);
expect(JSON.parse(persistedState.toString())).to.eql(parentCompare);
});
});
describe('importing state from JSON string (hydration)', function () {
it('should set the state from JSON string input', function () {
- var stateJSON = JSON.stringify(persistedStateValue);
- var persistedState = new PersistedState();
+ let stateJSON = JSON.stringify(persistedStateValue);
+ let persistedState = new PersistedState();
expect(persistedState.get()).to.eql({});
persistedState.fromString(stateJSON);
@@ -421,7 +421,7 @@ describe('Persisted State', function () {
describe('get state', function () {
it('should perform deep gets with various formats', function () {
- var obj = {
+ let obj = {
red: {
green: {
blue: 'yellow'
@@ -432,7 +432,7 @@ describe('Persisted State', function () {
violet: ''
}
};
- var persistedState = new PersistedState(obj);
+ let persistedState = new PersistedState(obj);
expect(persistedState.get()).to.eql(obj);
expect(persistedState.get('red')).to.eql({ green: { blue: 'yellow' } });
@@ -451,7 +451,7 @@ describe('Persisted State', function () {
});
it('should perform deep gets with arrays', function () {
- var persistedState = new PersistedState({ hello: { nouns: ['world', 'humans', 'everyone'] } });
+ let persistedState = new PersistedState({ hello: { nouns: ['world', 'humans', 'everyone'] } });
expect(persistedState.get()).to.eql({ hello: { nouns: ['world', 'humans', 'everyone'] } });
expect(persistedState.get('hello')).to.eql({ nouns: ['world', 'humans', 'everyone'] });
@@ -459,9 +459,9 @@ describe('Persisted State', function () {
});
it('should pass defaults to parent delegation', function () {
- var persistedState = new PersistedState({ parent: true });
- var childState = persistedState.createChild('child', { account: { name: 'first child' }});
- var defaultValue = 'i have no data';
+ let persistedState = new PersistedState({ parent: true });
+ let childState = persistedState.createChild('child', { account: { name: 'first child' }});
+ let defaultValue = 'i have no data';
expect(childState.get('account.name', defaultValue)).to.eql('first child');
expect(childState.get('account.age', defaultValue)).to.eql(defaultValue);
@@ -471,25 +471,25 @@ describe('Persisted State', function () {
describe('set state', function () {
describe('path format support', function () {
it('should create deep objects from dot notation', function () {
- var persistedState = new PersistedState();
+ let persistedState = new PersistedState();
persistedState.set('one.two.three', 4);
expect(persistedState.get()).to.eql({ one: { two: { three: 4 } } });
});
it('should create deep objects from array notation', function () {
- var persistedState = new PersistedState();
+ let persistedState = new PersistedState();
persistedState.set('one[two][three]', 4);
expect(persistedState.get()).to.eql({ one: { two: { three: 4 } } });
});
it('should create deep objects from arrays', function () {
- var persistedState = new PersistedState();
+ let persistedState = new PersistedState();
persistedState.set(['one', 'two', 'three'], 4);
expect(persistedState.get()).to.eql({ one: { two: { three: 4 } } });
});
it('should create deep objects with an existing path', function () {
- var persistedState = new PersistedState({}, 'deep.path');
+ let persistedState = new PersistedState({}, 'deep.path');
persistedState.set('green[red].blue', 4);
expect(persistedState.get()).to.eql({ green: { red: { blue: 4 } }});
});
@@ -555,19 +555,19 @@ describe('Persisted State', function () {
describe('internal state tracking', function () {
it('should be an empty object', function () {
- var persistedState = new PersistedState();
+ let persistedState = new PersistedState();
expect(persistedState._defaultState).to.eql({});
});
it('should store the default state value', function () {
- var val = { one: 1, two: 2 };
- var persistedState = new PersistedState(val);
+ let val = { one: 1, two: 2 };
+ let persistedState = new PersistedState(val);
expect(persistedState._defaultState).to.eql(val);
});
it('should keep track of changes', function () {
- var val = { one: 1, two: 2 };
- var persistedState = new PersistedState(val);
+ let val = { one: 1, two: 2 };
+ let persistedState = new PersistedState(val);
persistedState.set('two', 22);
expect(persistedState._defaultState).to.eql(val);
@@ -579,14 +579,14 @@ describe('Persisted State', function () {
let persistedState;
let emitter;
- var getByType = function (type, spy) {
+ let getByType = function (type, spy) {
spy = spy || emitter;
return spy.getCalls().filter(function (call) {
return call.args[0] === type;
});
};
- var watchEmitter = function (state) {
+ let watchEmitter = function (state) {
return sinon.spy(state, 'emit');
};
@@ -667,7 +667,7 @@ describe('Persisted State', function () {
});
it('should emit on parent and child instances', function (done) {
- var child = persistedState.createChild('checker');
+ let child = persistedState.createChild('checker');
expect(getByType('change')).to.have.length(0);
// parent and child should emit, set up listener to test
diff --git a/src/ui/public/private/__tests__/private.js b/src/ui/public/private/__tests__/private.js
index 873a22ad2871a..fc3dab39d3436 100644
--- a/src/ui/public/private/__tests__/private.js
+++ b/src/ui/public/private/__tests__/private.js
@@ -11,12 +11,12 @@ describe('Private module loader', function () {
}));
it('accepts a provider that will be called to init a module', function () {
- var football = {};
+ let football = {};
function Provider() {
return football;
}
- var instance = Private(Provider);
+ let instance = Private(Provider);
expect(instance).to.be(football);
});
@@ -25,25 +25,25 @@ describe('Private module loader', function () {
return Private;
}
- var instance = Private(Provider);
+ let instance = Private(Provider);
expect(instance).to.be(Private);
});
it('detects circular dependencies', function () {
expect(function () {
function Provider1() {
- var p3 = Private(Provider3);
+ let p3 = Private(Provider3);
}
function Provider2() {
- var p3 = Private(Provider3);
+ let p3 = Private(Provider3);
}
function Provider3() {
- var p1 = Private(Provider3);
+ let p1 = Private(Provider3);
}
- var p1 = Private(Provider1);
+ let p1 = Private(Provider1);
}).to.throwException(/circular/i);
});
@@ -57,24 +57,24 @@ describe('Private module loader', function () {
describe('#stub', function () {
it('accepts a replacement instance for a Provider', function () {
- var replaced = {};
- var replacement = {};
+ let replaced = {};
+ let replacement = {};
function Provider() {
return replaced;
}
- var instance = Private(Provider);
+ let instance = Private(Provider);
expect(instance).to.be(replaced);
Private.stub(Provider, replacement);
- var instance2 = Private(Provider);
+ let instance2 = Private(Provider);
expect(instance2).to.be(replacement);
Private.stub(Provider, replaced);
- var instance3 = Private(Provider);
+ let instance3 = Private(Provider);
expect(instance3).to.be(replaced);
});
});
@@ -89,18 +89,18 @@ describe('Private module loader', function () {
return {};
}
- var instance1 = Private(Provider1);
+ let instance1 = Private(Provider1);
expect(instance1).to.be.an('object');
Private.swap(Provider1, Provider2);
- var instance2 = Private(Provider1);
+ let instance2 = Private(Provider1);
expect(instance2).to.be.an('object');
expect(instance2).to.not.be(instance1);
Private.swap(Provider1, Provider1);
- var instance3 = Private(Provider1);
+ let instance3 = Private(Provider1);
expect(instance3).to.be(instance1);
});
@@ -115,12 +115,12 @@ describe('Private module loader', function () {
};
}
- var instance1 = Private(Provider1);
+ let instance1 = Private(Provider1);
expect(instance1).to.be.an('object');
Private.swap(Provider1, Provider2);
- var instance2 = Private(Provider1);
+ let instance2 = Private(Provider1);
expect(instance2).to.have.property('instance1');
expect(instance2.instance1).to.be(instance1);
});
diff --git a/src/ui/public/reflow_watcher/__tests__/reflow_watcher.js b/src/ui/public/reflow_watcher/__tests__/reflow_watcher.js
index dbf5b5461f9d7..576fa9f0bd9ae 100644
--- a/src/ui/public/reflow_watcher/__tests__/reflow_watcher.js
+++ b/src/ui/public/reflow_watcher/__tests__/reflow_watcher.js
@@ -8,11 +8,11 @@ import EventsProvider from 'ui/events';
import ReflowWatcherProvider from 'ui/reflow_watcher';
describe('Reflow watcher', function () {
- var $body = $(document.body);
- var $window = $(window);
- var expectStubbedEventAndEl = function (stub, event, $el) {
+ let $body = $(document.body);
+ let $window = $(window);
+ let expectStubbedEventAndEl = function (stub, event, $el) {
expect(stub.getCalls().some(function (call) {
- var events = call.args[0].split(' ');
+ let events = call.args[0].split(' ');
return _.contains(events, event) && $el.is(call.thisValue);
})).to.be(true);
};
@@ -70,7 +70,7 @@ describe('Reflow watcher', function () {
});
it('triggers the "reflow" event within a new angular tick', function () {
- var stub = sinon.stub();
+ let stub = sinon.stub();
reflowWatcher.on('reflow', stub);
reflowWatcher.trigger();
diff --git a/src/ui/public/registry/__tests__/index.js b/src/ui/public/registry/__tests__/index.js
index fb39dc64c9617..85091d32bc754 100644
--- a/src/ui/public/registry/__tests__/index.js
+++ b/src/ui/public/registry/__tests__/index.js
@@ -13,14 +13,14 @@ describe('Registry', function () {
}));
it('is technically a function', function () {
- var reg = registry();
+ let reg = registry();
expect(reg).to.be.a('function');
});
describe('#register', function () {
it('accepts a Private module', function () {
- var reg = registry();
- var mod = function SomePrivateModule() {};
+ let reg = registry();
+ let mod = function SomePrivateModule() {};
reg.register(mod);
// modules are not exposed, so this is the most that we can test
@@ -29,13 +29,13 @@ describe('Registry', function () {
describe('as a module', function () {
it('exposes the list of registered modules', function () {
- var reg = registry();
- var mod = function SomePrivateModule(Private) {
+ let reg = registry();
+ let mod = function SomePrivateModule(Private) {
this.PrivateModuleLoader = Private;
};
reg.register(mod);
- var modules = Private(reg);
+ let modules = Private(reg);
expect(modules).to.have.length(1);
expect(modules[0]).to.have.property('PrivateModuleLoader', Private);
});
@@ -43,16 +43,16 @@ describe('Registry', function () {
describe('spec', function () {
it('executes with the module list as "this", and can override it', function () {
- var i = 0;
+ let i = 0;
let self;
- var reg = registry({
+ let reg = registry({
constructor: function () {
return { mods: (self = this) };
}
});
- var modules = Private(reg);
+ let modules = Private(reg);
expect(modules).to.be.an('object');
expect(modules).to.have.property('mods', self);
});
@@ -60,7 +60,7 @@ describe('Registry', function () {
describe('spec.name', function () {
it('sets the displayName of the registry and the name param on the final instance', function () {
- var reg = registry({
+ let reg = registry({
name: 'visTypes'
});
@@ -71,28 +71,28 @@ describe('Registry', function () {
describe('spec.constructor', function () {
it('executes before the modules are returned', function () {
- var i = 0;
- var reg = registry({
+ let i = 0;
+ let reg = registry({
constructor: function () {
i = i + 1;
}
});
- var modules = Private(reg);
+ let modules = Private(reg);
expect(i).to.be(1);
});
it('executes with the module list as "this", and can override it', function () {
- var i = 0;
+ let i = 0;
let self;
- var reg = registry({
+ let reg = registry({
constructor: function () {
return { mods: (self = this) };
}
});
- var modules = Private(reg);
+ let modules = Private(reg);
expect(modules).to.be.an('object');
expect(modules).to.have.property('mods', self);
});
@@ -100,13 +100,13 @@ describe('Registry', function () {
describe('spec[any]', function () {
it('mixes the extra properties into the module list', function () {
- var reg = registry({
+ let reg = registry({
someMethod: function () {
return this;
}
});
- var modules = Private(reg);
+ let modules = Private(reg);
expect(modules).to.have.property('someMethod');
expect(modules.someMethod()).to.be(modules);
});
diff --git a/src/ui/public/routes/__tests__/_route_manager.js b/src/ui/public/routes/__tests__/_route_manager.js
index 29f99f49a1195..75685be9b093a 100644
--- a/src/ui/public/routes/__tests__/_route_manager.js
+++ b/src/ui/public/routes/__tests__/_route_manager.js
@@ -5,7 +5,7 @@ import RouteManager from 'ui/routes/route_manager';
import expect from 'expect.js';
let routes; // will contain an new instance of RouteManager for each test
-var chainableMethods = [
+let chainableMethods = [
{ name: 'when', args: ['', {}] },
{ name: 'otherwise', args: [{}] },
{ name: 'defaults', args: [/regexp/, {}] }
@@ -31,7 +31,7 @@ describe('routes/route_manager', function () {
describe('#otherwise', function () {
it('should forward the last otherwise route', function () {
- var otherRoute = {};
+ let otherRoute = {};
routes.otherwise({});
routes.otherwise(otherRoute);
@@ -68,7 +68,7 @@ describe('routes/route_manager', function () {
describe('#config', function () {
it('should add defined routes to the global $routeProvider service in order', function () {
- var args = [
+ let args = [
['/one', {}],
['/two', {}]
];
@@ -81,8 +81,8 @@ describe('routes/route_manager', function () {
expect($rp.when.callCount).to.be(args.length);
_.times(args.length, function (i) {
- var call = $rp.when.getCall(i);
- var a = args.shift();
+ let call = $rp.when.getCall(i);
+ let a = args.shift();
expect(call.args[0]).to.be(a[0]);
expect(call.args[1]).to.be(a[1]);
diff --git a/src/ui/public/routes/__tests__/_work_queue.js b/src/ui/public/routes/__tests__/_work_queue.js
index 1321ec0fd81e4..863f7345075bd 100644
--- a/src/ui/public/routes/__tests__/_work_queue.js
+++ b/src/ui/public/routes/__tests__/_work_queue.js
@@ -25,10 +25,10 @@ describe('work queue', function () {
describe('#resolveWhenFull', function () {
it('resolves requests waiting for the queue to fill when appropriate', function () {
- var size = _.random(5, 50);
+ let size = _.random(5, 50);
queue.limit = size;
- var whenFull = Promise.defer();
+ let whenFull = Promise.defer();
sinon.stub(whenFull, 'resolve');
queue.resolveWhenFull(whenFull);
@@ -53,11 +53,11 @@ describe('work queue', function () {
* can manipulate the filled queue
*/
function fillWithStubs(then) {
- var size = _.random(5, 50);
- var stub = sinon.stub();
+ let size = _.random(5, 50);
+ let stub = sinon.stub();
_.times(size, function () {
- var d = Promise.defer();
+ let d = Promise.defer();
// overwrite the defer methods with the stub
d.resolve = stub;
d.reject = stub;
diff --git a/src/ui/public/routes/__tests__/_wrap_route_with_prep.js b/src/ui/public/routes/__tests__/_wrap_route_with_prep.js
index d1e915abf4d25..a56cb503e1d46 100644
--- a/src/ui/public/routes/__tests__/_wrap_route_with_prep.js
+++ b/src/ui/public/routes/__tests__/_wrap_route_with_prep.js
@@ -18,16 +18,16 @@ describe('wrapRouteWithPrep fn', function () {
routes = new RouteManager();
});
- var SchedulingTest = function (opts) {
+ let SchedulingTest = function (opts) {
opts = opts || {};
- var delaySetup = opts.delayUserWork ? 0 : 50;
- var delayUserWork = opts.delayUserWork ? 50 : 0;
+ let delaySetup = opts.delayUserWork ? 0 : 50;
+ let delayUserWork = opts.delayUserWork ? 50 : 0;
return function () {
ngMock.module('kibana', 'kibana/notify');
- var setupComplete = false;
- var userWorkComplete = false;
+ let setupComplete = false;
+ let userWorkComplete = false;
let route;
let Private;
let Promise;
diff --git a/src/ui/public/safe_confirm/__tests__/safe_confirm.js b/src/ui/public/safe_confirm/__tests__/safe_confirm.js
index e30201d534f7f..7b33aaad955a3 100644
--- a/src/ui/public/safe_confirm/__tests__/safe_confirm.js
+++ b/src/ui/public/safe_confirm/__tests__/safe_confirm.js
@@ -34,7 +34,7 @@ describe('ui/safe_confirm', function () {
expect($window.confirm.called).to.be(false);
});
it('returned promise is not resolved', function () {
- var isResolved = false;
+ let isResolved = false;
function markAsResolved() {
isResolved = true;
}
diff --git a/src/ui/public/state_management/__tests__/app_state.js b/src/ui/public/state_management/__tests__/app_state.js
index 5de4631512a2b..6f9af310db4a4 100644
--- a/src/ui/public/state_management/__tests__/app_state.js
+++ b/src/ui/public/state_management/__tests__/app_state.js
@@ -27,7 +27,7 @@ describe('State Management', function () {
});
it('should use passed in params', function () {
- var params = {
+ let params = {
test: true,
mock: false
};
@@ -46,8 +46,8 @@ describe('State Management', function () {
});
it('should be destroyed on $routeChangeStart', function () {
- var destroySpy = sinon.spy(appState, 'destroy');
- var url = '/test/path';
+ let destroySpy = sinon.spy(appState, 'destroy');
+ let url = '/test/path';
$rootScope.$emit('$routeChangeStart');
diff --git a/src/ui/public/state_management/__tests__/state.js b/src/ui/public/state_management/__tests__/state.js
index 9af33460604c7..d0233594e5b44 100644
--- a/src/ui/public/state_management/__tests__/state.js
+++ b/src/ui/public/state_management/__tests__/state.js
@@ -23,26 +23,26 @@ describe('State Management', function () {
describe('Provider', function () {
it('should reset the state to the defaults', function () {
- var state = new State('_s', { message: ['test'] });
+ let state = new State('_s', { message: ['test'] });
state.reset();
- var search = $location.search();
+ let search = $location.search();
expect(search).to.have.property('_s');
expect(search._s).to.equal('(message:!(test))');
expect(state.message).to.eql(['test']);
});
it('should apply the defaults upon initialization', function () {
- var state = new State('_s', { message: 'test' });
+ let state = new State('_s', { message: 'test' });
expect(state).to.have.property('message', 'test');
});
it('should inherit from Events', function () {
- var state = new State();
+ let state = new State();
expect(state).to.be.an(Events);
});
it('should emit an event if reset with changes', function (done) {
- var state = new State('_s', { message: 'test' });
+ let state = new State('_s', { message: 'test' });
state.on('reset_with_changes', function (keys) {
expect(keys).to.eql(['message']);
done();
@@ -54,7 +54,7 @@ describe('State Management', function () {
});
it('should not emit an event if reset without changes', function () {
- var state = new State('_s', { message: 'test' });
+ let state = new State('_s', { message: 'test' });
state.on('reset_with_changes', function () {
expect().fail();
});
@@ -67,29 +67,29 @@ describe('State Management', function () {
describe('Search', function () {
it('should save to $location.search()', function () {
- var state = new State('_s', { test: 'foo' });
+ let state = new State('_s', { test: 'foo' });
state.save();
- var search = $location.search();
+ let search = $location.search();
expect(search).to.have.property('_s');
expect(search._s).to.equal('(test:foo)');
});
it('should emit an event if changes are saved', function (done) {
- var state = new State();
+ let state = new State();
state.on('save_with_changes', function (keys) {
expect(keys).to.eql(['test']);
done();
});
state.test = 'foo';
state.save();
- var search = $location.search();
+ let search = $location.search();
$rootScope.$apply();
});
});
describe('Fetch', function () {
it('should emit an event if changes are fetched', function (done) {
- var state = new State();
+ let state = new State();
state.on('fetch_with_changes', function (keys) {
expect(keys).to.eql(['foo']);
done();
@@ -101,7 +101,7 @@ describe('State Management', function () {
});
it('should have events that attach to scope', function (done) {
- var state = new State();
+ let state = new State();
state.on('test', function (message) {
expect(message).to.equal('foo');
done();
@@ -111,7 +111,7 @@ describe('State Management', function () {
});
it('should fire listeners for #onUpdate() on #fetch()', function (done) {
- var state = new State();
+ let state = new State();
state.on('fetch_with_changes', function (keys) {
expect(keys).to.eql(['foo']);
done();
@@ -123,7 +123,7 @@ describe('State Management', function () {
});
it('should apply defaults to fetches', function () {
- var state = new State('_s', { message: 'test' });
+ let state = new State('_s', { message: 'test' });
$location.search({ _s: '(foo:bar)' });
state.fetch();
expect(state).to.have.property('foo', 'bar');
@@ -131,15 +131,15 @@ describe('State Management', function () {
});
it('should call fetch when $routeUpdate is fired on $rootScope', function () {
- var state = new State();
- var spy = sinon.spy(state, 'fetch');
+ let state = new State();
+ let spy = sinon.spy(state, 'fetch');
$rootScope.$emit('$routeUpdate', 'test');
sinon.assert.calledOnce(spy);
});
it('should clear state when missing form URL', function () {
let stateObj;
- var state = new State();
+ let state = new State();
// set satte via URL
$location.search({ _s: '(foo:(bar:baz))' });
diff --git a/src/ui/public/storage/__tests__/storage.js b/src/ui/public/storage/__tests__/storage.js
index 907c16dd7c018..8a4d5e2872f7c 100644
--- a/src/ui/public/storage/__tests__/storage.js
+++ b/src/ui/public/storage/__tests__/storage.js
@@ -5,7 +5,7 @@ import 'ui/storage';
let storage;
let $window;
-var payload = { first: 'john', last: 'smith' };
+let payload = { first: 'john', last: 'smith' };
function init() {
@@ -69,21 +69,21 @@ describe('StorageService', function () {
describe('json data', function () {
it('should parse JSON when reading from the store', function () {
- var getItem = $window.localStorage.getItem;
+ let getItem = $window.localStorage.getItem;
getItem.returns(JSON.stringify(payload));
- var data = storage.get('name');
+ let data = storage.get('name');
expect(data).to.eql(payload);
});
it('should write JSON string to the store', function () {
- var setItem = $window.localStorage.setItem;
- var key = 'name';
- var value = payload;
+ let setItem = $window.localStorage.setItem;
+ let key = 'name';
+ let value = payload;
storage.set(key, value);
- var call = setItem.getCall(0);
+ let call = setItem.getCall(0);
expect(call.args[0]).to.equal(key);
expect(call.args[1]).to.equal(JSON.stringify(value));
});
@@ -91,15 +91,15 @@ describe('StorageService', function () {
describe('expected responses', function () {
it('should return null when not exists', function () {
- var data = storage.get('notexists');
+ let data = storage.get('notexists');
expect(data).to.equal(null);
});
it('should return null when invalid JSON', function () {
- var getItem = $window.localStorage.getItem;
+ let getItem = $window.localStorage.getItem;
getItem.returns('not: json');
- var data = storage.get('name');
+ let data = storage.get('name');
expect(data).to.equal(null);
});
});
diff --git a/src/ui/public/stringify/__tests__/_color.js b/src/ui/public/stringify/__tests__/_color.js
index 652ef54ffefdf..f48823ea3d5e1 100644
--- a/src/ui/public/stringify/__tests__/_color.js
+++ b/src/ui/public/stringify/__tests__/_color.js
@@ -13,7 +13,7 @@ describe('Color Format', function () {
}));
it('should add colors if the value is in range', function () {
- var colorer = new ColorFormat({
+ let colorer = new ColorFormat({
colors: [{
range: '100:150',
text: 'blue',
@@ -27,7 +27,7 @@ describe('Color Format', function () {
});
it('should not convert invalid ranges', function () {
- var colorer = new ColorFormat({
+ let colorer = new ColorFormat({
colors: [{
range: '100150',
text: 'blue',
diff --git a/src/ui/public/stringify/__tests__/_conformance.js b/src/ui/public/stringify/__tests__/_conformance.js
index f1da188ef28fd..3154ae73c3616 100644
--- a/src/ui/public/stringify/__tests__/_conformance.js
+++ b/src/ui/public/stringify/__tests__/_conformance.js
@@ -8,7 +8,7 @@ let fieldFormats;
let FieldFormat;
let config;
-var formatIds = [
+let formatIds = [
'bytes',
'date',
'duration',
@@ -73,7 +73,7 @@ module.exports = describe('conformance', function () {
basicPatternTests('number', require('numeral'))();
it('tries to parse strings', function () {
- var number = new (fieldFormats.getType('number'))({ pattern: '0.0b' });
+ let number = new (fieldFormats.getType('number'))({ pattern: '0.0b' });
expect(number.convert(123.456)).to.be('123.5B');
expect(number.convert('123.456')).to.be('123.5B');
});
@@ -81,11 +81,11 @@ module.exports = describe('conformance', function () {
});
function basicPatternTests(id, lib) {
- var confKey = id === 'date' ? 'dateFormat' : 'format:' + id + ':defaultPattern';
+ let confKey = id === 'date' ? 'dateFormat' : 'format:' + id + ':defaultPattern';
return function () {
it('converts using the format:' + id + ':defaultPattern config', function () {
- var inst = fieldFormats.getInstance(id);
+ let inst = fieldFormats.getInstance(id);
[
'0b',
'0 b',
@@ -93,22 +93,22 @@ module.exports = describe('conformance', function () {
'0.[000]b',
'0.[0]b'
].forEach(function (pattern) {
- var num = _.random(-10000, 10000, true);
+ let num = _.random(-10000, 10000, true);
config.set(confKey, pattern);
expect(inst.convert(num)).to.be(lib(num).format(pattern));
});
});
it('uses the pattern param if available', function () {
- var num = _.random(-10000, 10000, true);
- var defFormat = '0b';
- var customFormat = '0.00000%';
+ let num = _.random(-10000, 10000, true);
+ let defFormat = '0b';
+ let customFormat = '0.00000%';
config.set(confKey, defFormat);
- var defInst = fieldFormats.getInstance(id);
+ let defInst = fieldFormats.getInstance(id);
- var Type = fieldFormats.getType(id);
- var customInst = new Type({ pattern: customFormat });
+ let Type = fieldFormats.getType(id);
+ let customInst = new Type({ pattern: customFormat });
expect(defInst.convert(num)).to.not.be(customInst.convert(num));
expect(defInst.convert(num)).to.be(lib(num).format(defFormat));
diff --git a/src/ui/public/stringify/__tests__/_date.js b/src/ui/public/stringify/__tests__/_date.js
index f1975e0ce2594..aec730580bf48 100644
--- a/src/ui/public/stringify/__tests__/_date.js
+++ b/src/ui/public/stringify/__tests__/_date.js
@@ -15,8 +15,8 @@ describe('Date Format', function () {
settings = config;
fieldFormats = Private(RegistryFieldFormatsProvider);
- var DateFormat = fieldFormats.getType('date');
- var date = new DateFormat();
+ let DateFormat = fieldFormats.getType('date');
+ let date = new DateFormat();
convert = date.convert.bind(date);
}));
@@ -30,17 +30,17 @@ describe('Date Format', function () {
function setDefaultTimezone() {
moment.tz.setDefault(settings.get('dateFormat:tz'));
}
- var time = 1445027693942;
+ let time = 1445027693942;
off = $scope.$on('change:config.dateFormat:tz', setDefaultTimezone);
settings.set('dateFormat:tz', 'America/Chicago');
$scope.$digest();
- var chicagoTime = convert(time);
+ let chicagoTime = convert(time);
settings.set('dateFormat:tz', 'America/Phoenix');
$scope.$digest();
- var phoenixTime = convert(time);
+ let phoenixTime = convert(time);
expect(chicagoTime).not.to.equal(phoenixTime);
off();
diff --git a/src/ui/public/stringify/__tests__/_ip.js b/src/ui/public/stringify/__tests__/_ip.js
index f49294c97d9c0..cd953acd1d445 100644
--- a/src/ui/public/stringify/__tests__/_ip.js
+++ b/src/ui/public/stringify/__tests__/_ip.js
@@ -10,7 +10,7 @@ describe('IP Address Format', function () {
}));
it('converts a value from a decimal to a string', function () {
- var ip = fieldFormats.getInstance('ip');
+ let ip = fieldFormats.getInstance('ip');
expect(ip.convert(1186489492)).to.be('70.184.100.148');
});
diff --git a/src/ui/public/stringify/__tests__/_source.js b/src/ui/public/stringify/__tests__/_source.js
index 8d2b9ae5de94b..63d4691c33b09 100644
--- a/src/ui/public/stringify/__tests__/_source.js
+++ b/src/ui/public/stringify/__tests__/_source.js
@@ -28,8 +28,8 @@ describe('_source formatting', function () {
}));
it('uses the _source, field, and hit to create a