From 211abfee19e926f133bfaaef480d6a100fd95c08 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 19 May 2020 17:51:33 +0200 Subject: [PATCH 1/2] move role reset into the top level after clause (#66971) # Conflicts: # test/functional/apps/visualize/_area_chart.js --- test/functional/apps/visualize/_area_chart.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/functional/apps/visualize/_area_chart.js b/test/functional/apps/visualize/_area_chart.js index efe94a11415d4..753dc898b52f7 100644 --- a/test/functional/apps/visualize/_area_chart.js +++ b/test/functional/apps/visualize/_area_chart.js @@ -70,7 +70,11 @@ export default function ({ getService, getPageObjects }) { await initAreaChart(); }); - it('should save and load with special characters', async function () { + after(async function() { + await security.testUser.restoreDefaults(); + }); + + it('should save and load with special characters', async function() { const vizNamewithSpecialChars = vizName1 + '/?&=%'; await PageObjects.visualize.saveVisualizationExpectSuccessAndBreadcrumb( vizNamewithSpecialChars @@ -291,7 +295,6 @@ export default function ({ getService, getPageObjects }) { const url = await browser.getCurrentUrl(); const embedUrl = url.split('/visualize/').pop().replace('embed=true', ''); await PageObjects.common.navigateToUrl('visualize', embedUrl); - await security.testUser.restoreDefaults(); }); }); From de41414f5e8729e31a84cc1b5a686f85c52f599a Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Wed, 3 Jun 2020 14:42:54 +0200 Subject: [PATCH 2/2] fix eslint --- test/functional/apps/visualize/_area_chart.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/functional/apps/visualize/_area_chart.js b/test/functional/apps/visualize/_area_chart.js index 753dc898b52f7..1ba3234ea4b71 100644 --- a/test/functional/apps/visualize/_area_chart.js +++ b/test/functional/apps/visualize/_area_chart.js @@ -70,11 +70,11 @@ export default function ({ getService, getPageObjects }) { await initAreaChart(); }); - after(async function() { + after(async function () { await security.testUser.restoreDefaults(); }); - it('should save and load with special characters', async function() { + it('should save and load with special characters', async function () { const vizNamewithSpecialChars = vizName1 + '/?&=%'; await PageObjects.visualize.saveVisualizationExpectSuccessAndBreadcrumb( vizNamewithSpecialChars