Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB Validation fix color rule validation #67759

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

flash1293
Copy link
Contributor

Fixes #67301

This PR adds a forgotten property to the background color rule schema and allows the values of gauge color rules to be undefined as well.

@flash1293 flash1293 marked this pull request as ready for review May 29, 2020 14:45
@flash1293 flash1293 requested review from a team and timroes May 29, 2020 14:45
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (validation error haven't tested)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 884704d into elastic:master Jun 3, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Jun 3, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Jun 3, 2020
# Conflicts:
#	src/plugins/vis_type_timeseries/server/routes/post_vis_schema.ts
flash1293 added a commit that referenced this pull request Jun 3, 2020
flash1293 added a commit that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kibana 7.7.0: Console warnings when adding a color rule to a TSVB Metric visualization
4 participants