From e3c3e37f30af5a8791e718259ac59a761bd1788e Mon Sep 17 00:00:00 2001 From: vitalics Date: Tue, 16 Apr 2019 17:27:46 +0300 Subject: [PATCH 01/11] base implementation --- test/functional/apps/visualize/_tsvb_chart.ts | 19 ------ test/functional/apps/visualize/_tsvb_table.ts | 60 +++++++++++++++++++ test/functional/apps/visualize/index.ts | 1 + .../page_objects/visual_builder_page.ts | 41 ++++++++++++- 4 files changed, 99 insertions(+), 22 deletions(-) create mode 100644 test/functional/apps/visualize/_tsvb_table.ts diff --git a/test/functional/apps/visualize/_tsvb_chart.ts b/test/functional/apps/visualize/_tsvb_chart.ts index 2c4eb59b638fe..26c8b72dbf37a 100644 --- a/test/functional/apps/visualize/_tsvb_chart.ts +++ b/test/functional/apps/visualize/_tsvb_chart.ts @@ -122,25 +122,6 @@ export default function({ getService, getPageObjects }: FtrProviderContext) { }); }); - describe('table', () => { - beforeEach(async () => { - await PageObjects.visualBuilder.resetPage( - '2015-09-22 06:00:00.000', - '2015-09-22 11:00:00.000' - ); - await PageObjects.visualBuilder.clickTable(); - }); - - it('should display correct values on changing group by field and column name', async () => { - await PageObjects.visualBuilder.selectGroupByField('machine.os.raw'); - await PageObjects.visualBuilder.setLabelValue('OS'); - await PageObjects.visualize.waitForVisualizationRenderingStabilized(); - const tableData = await PageObjects.visualBuilder.getViewTable(); - const expectedData = 'OS Count\nwin 8 13\nwin xp 10\nwin 7 12\nios 5\nosx 3'; - expect(tableData).to.be(expectedData); - }); - }); - describe.skip('switch index patterns', () => { before(async () => { log.debug('Load kibana_sample_data_flights data'); diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts new file mode 100644 index 0000000000000..6a8f96b4f55cd --- /dev/null +++ b/test/functional/apps/visualize/_tsvb_table.ts @@ -0,0 +1,60 @@ +/* + * Licensed to Elasticsearch B.V. under one or more contributor + * license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright + * ownership. Elasticsearch B.V. licenses this file to you under + * the Apache License, Version 2.0 (the "License"); you may + * not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import expect from '@kbn/expect'; +import { FtrProviderContext } from '../../ftr_provider_context'; + +// eslint-disable-next-line import/no-default-export +export default function ({ getPageObjects, getService }: FtrProviderContext) { + const { visualBuilder, visualize } = getPageObjects(['visualBuilder', 'visualize']); + const log = getService('log'); + + describe('visual builder', function describeIndexTests() { + describe('table', () => { + beforeEach(async () => { + await visualBuilder.resetPage( + '2015-09-22 06:00:00.000', + '2015-09-22 11:00:00.000' + ); + await visualBuilder.clickTable(); + // table preparation + await visualBuilder.selectGroupByField('machine.os.raw'); + await visualBuilder.setColumnLabelValue('OS'); + await visualize.waitForVisualizationRenderingStabilized(); + }); + + it('should display correct values on changing group by field and column name', async () => { + const EXPECTED = 'OS Count\nwin 8 13\nwin xp 10\nwin 7 12\nios 5\nosx 3'; + + const tableData = await visualBuilder.getViewTable(); + expect(tableData).to.be(EXPECTED); + }); + + it('should display correct values on changing metrics aggregation', async () => { + const EXPECTED = 'OS Cardinality\nwin 8 12\nwin xp 9\nwin 7 8\nios 5\nosx 3'; + + await visualBuilder.setLabel('Cardinality'); + await visualBuilder.selectAggType('Cardinality'); + await visualBuilder.setFieldForAggregation('machine.ram'); + const tableData = await visualBuilder.getViewTable(); + expect(tableData).to.be(EXPECTED); + }); + }); + }); +} diff --git a/test/functional/apps/visualize/index.ts b/test/functional/apps/visualize/index.ts index 1a3bc8c776fa7..aaf46f28e0c45 100644 --- a/test/functional/apps/visualize/index.ts +++ b/test/functional/apps/visualize/index.ts @@ -80,6 +80,7 @@ export default function({ getService, loadTestFile }: FtrProviderContext) { loadTestFile(require.resolve('./_vertical_bar_chart_nontimeindex')); loadTestFile(require.resolve('./_tsvb_chart')); loadTestFile(require.resolve('./_tsvb_markdown')); + loadTestFile(require.resolve('./_tsvb_table')); loadTestFile(require.resolve('./_vega_chart')); }); }); diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index fefb334ed39c1..26e006e37ae75 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -235,7 +235,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro }); } - public async selectAggType(value: string | number, nth = 0) { + public async selectAggType(value: string | number, nth: number = 0): Promise { const elements = await testSubjects.findAll('aggSelector'); await comboBox.setElement(elements[nth], value); return await PageObjects.header.waitUntilLoadingHasFinished(); @@ -262,14 +262,22 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro await comboBox.set('groupByField', fieldName); } - public async setLabelValue(value: string) { + public async setColumnLabelValue(value: string) { const el = await testSubjects.find('columnLabelName'); await el.clearValue(); await el.type(value); await PageObjects.header.waitUntilLoadingHasFinished(); } - public async getViewTable() { + /** + * get values for rendered table + * + * **Note:** this work only for table visualization + * + * @returns {Promise} + * @memberof VisualBuilderPage + */ + public async getViewTable(): Promise { const tableView = await testSubjects.find('tableView'); return await tableView.getVisibleText(); } @@ -294,7 +302,34 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro await el.pressKeys(browser.keys.RETURN); await PageObjects.header.waitUntilLoadingHasFinished(); } + + /** + * set label name for aggregation + * + * @param {string} labelName + * @param {number} [nth=0] + * @memberof VisualBuilderPage + */ + public async setLabel(labelName: string, nth: number = 0): Promise { + const input = (await find.allByCssSelector('[placeholder="Label"]'))[nth]; + await input.type(labelName); + } + + /** + * set field for type of aggregation + * + * @param {string} field name of field + * @param {number} [aggNth=0] number of aggregation. Start by zero + * @default 0 + * @memberof VisualBuilderPage + */ + public async setFieldForAggregation(field: string, aggNth: number = 0): Promise { + const label = (await find.allByCssSelector('.tvbSeriesEditor__container .tvbSeriesEditor'))[aggNth]; + const fieldEl = (await label.findAllByCssSelector('[data-test-subj = "comboBoxInput"]'))[1]; + await comboBox.setElement(fieldEl, field); + } } + return new VisualBuilderPage(); } From 07ea6a736df150d465ad4481bf097c286d08186e Mon Sep 17 00:00:00 2001 From: vitalics Date: Wed, 17 Apr 2019 12:23:46 +0300 Subject: [PATCH 02/11] fix prettier issues --- test/functional/apps/visualize/_tsvb_table.ts | 8 ++------ test/functional/page_objects/visual_builder_page.ts | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts index 6a8f96b4f55cd..55bae6698a97d 100644 --- a/test/functional/apps/visualize/_tsvb_table.ts +++ b/test/functional/apps/visualize/_tsvb_table.ts @@ -21,17 +21,13 @@ import expect from '@kbn/expect'; import { FtrProviderContext } from '../../ftr_provider_context'; // eslint-disable-next-line import/no-default-export -export default function ({ getPageObjects, getService }: FtrProviderContext) { +export default function({ getPageObjects }: FtrProviderContext) { const { visualBuilder, visualize } = getPageObjects(['visualBuilder', 'visualize']); - const log = getService('log'); describe('visual builder', function describeIndexTests() { describe('table', () => { beforeEach(async () => { - await visualBuilder.resetPage( - '2015-09-22 06:00:00.000', - '2015-09-22 11:00:00.000' - ); + await visualBuilder.resetPage('2015-09-22 06:00:00.000', '2015-09-22 11:00:00.000'); await visualBuilder.clickTable(); // table preparation await visualBuilder.selectGroupByField('machine.os.raw'); diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index 26e006e37ae75..48f1087720381 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -324,12 +324,12 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro * @memberof VisualBuilderPage */ public async setFieldForAggregation(field: string, aggNth: number = 0): Promise { - const label = (await find.allByCssSelector('.tvbSeriesEditor__container .tvbSeriesEditor'))[aggNth]; + const labels = await find.allByCssSelector('.tvbSeriesEditor__container .tvbSeriesEditor'); + const label = labels[aggNth]; const fieldEl = (await label.findAllByCssSelector('[data-test-subj = "comboBoxInput"]'))[1]; await comboBox.setElement(fieldEl, field); } } - return new VisualBuilderPage(); } From ec680c7293a58509c89d2c4668fa5ae47c54db45 Mon Sep 17 00:00:00 2001 From: vitalics Date: Thu, 18 Apr 2019 15:29:05 +0300 Subject: [PATCH 03/11] add expectation for table visualization --- test/functional/apps/visualize/_tsvb_table.ts | 1 + test/functional/page_objects/visual_builder_page.ts | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts index 55bae6698a97d..6b32d4c8f6af5 100644 --- a/test/functional/apps/visualize/_tsvb_table.ts +++ b/test/functional/apps/visualize/_tsvb_table.ts @@ -30,6 +30,7 @@ export default function({ getPageObjects }: FtrProviderContext) { await visualBuilder.resetPage('2015-09-22 06:00:00.000', '2015-09-22 11:00:00.000'); await visualBuilder.clickTable(); // table preparation + await visualBuilder.checkTableExisting(); await visualBuilder.selectGroupByField('machine.os.raw'); await visualBuilder.setColumnLabelValue('OS'); await visualize.waitForVisualizationRenderingStabilized(); diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index 48f1087720381..b64b2abf0c558 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -303,6 +303,17 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro await PageObjects.header.waitUntilLoadingHasFinished(); } + /** + * check that table visualization is visible and ready for interact + * + * @returns {Promise} + * @memberof VisualBuilderPage + */ + public async checkTableExisting(): Promise { + await testSubjects.existOrFail('visualizationLoader'); + await testSubjects.existOrFail('noTSVBDataMessage'); + } + /** * set label name for aggregation * From d114fbb43797cbd7ff66c42cc5955e6baf073551 Mon Sep 17 00:00:00 2001 From: vitalics Date: Thu, 18 Apr 2019 15:33:14 +0300 Subject: [PATCH 04/11] run 60 times --- .ci/jobs.yml | 98 ++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 79 insertions(+), 19 deletions(-) diff --git a/.ci/jobs.yml b/.ci/jobs.yml index 596f22215a2a6..9f74acd1df4a3 100644 --- a/.ci/jobs.yml +++ b/.ci/jobs.yml @@ -1,26 +1,86 @@ JOB: - kibana-intake - x-pack-intake - - kibana-ciGroup1 - - kibana-ciGroup2 - - kibana-ciGroup3 - - kibana-ciGroup4 - - kibana-ciGroup5 - - kibana-ciGroup6 - - kibana-ciGroup7 - - kibana-ciGroup8 - - kibana-ciGroup9 - - kibana-ciGroup10 - - kibana-ciGroup11 - - kibana-ciGroup12 + # - kibana-ciGroup1 + # - kibana-ciGroup2 + # - kibana-ciGroup3 + # - kibana-ciGroup4 + # - kibana-ciGroup5 + # - kibana-ciGroup6 + # - kibana-ciGroup7 + # - kibana-ciGroup8 + # - kibana-ciGroup9 + # - kibana-ciGroup10 + # - kibana-ciGroup11 + # - kibana-ciGroup12 + - x-pack-ciGroup12-1 + - x-pack-ciGroup12-2 + - x-pack-ciGroup12-3 + - x-pack-ciGroup12-4 + - x-pack-ciGroup12-5 + - x-pack-ciGroup12-6 + - x-pack-ciGroup12-7 + - x-pack-ciGroup12-8 + - x-pack-ciGroup12-9 + - x-pack-ciGroup12-10 + - x-pack-ciGroup12-11 + - x-pack-ciGroup12-12 + - x-pack-ciGroup12-13 + - x-pack-ciGroup12-14 + - x-pack-ciGroup12-15 + - x-pack-ciGroup12-16 + - x-pack-ciGroup12-17 + - x-pack-ciGroup12-18 + - x-pack-ciGroup12-19 + - x-pack-ciGroup12-20 + - x-pack-ciGroup12-21 + - x-pack-ciGroup12-22 + - x-pack-ciGroup12-23 + - x-pack-ciGroup12-24 + - x-pack-ciGroup12-25 + - x-pack-ciGroup12-26 + - x-pack-ciGroup12-27 + - x-pack-ciGroup12-28 + - x-pack-ciGroup12-29 + - x-pack-ciGroup12-30 + - x-pack-ciGroup12-31 + - x-pack-ciGroup12-32 + - x-pack-ciGroup12-33 + - x-pack-ciGroup12-34 + - x-pack-ciGroup12-35 + - x-pack-ciGroup12-36 + - x-pack-ciGroup12-37 + - x-pack-ciGroup12-38 + - x-pack-ciGroup12-39 + - x-pack-ciGroup12-40 + - x-pack-ciGroup12-41 + - x-pack-ciGroup12-42 + - x-pack-ciGroup12-43 + - x-pack-ciGroup12-44 + - x-pack-ciGroup12-45 + - x-pack-ciGroup12-46 + - x-pack-ciGroup12-47 + - x-pack-ciGroup12-48 + - x-pack-ciGroup12-49 + - x-pack-ciGroup12-50 + - x-pack-ciGroup12-51 + - x-pack-ciGroup12-52 + - x-pack-ciGroup12-53 + - x-pack-ciGroup12-54 + - x-pack-ciGroup12-55 + - x-pack-ciGroup12-56 + - x-pack-ciGroup12-57 + - x-pack-ciGroup12-58 + - x-pack-ciGroup12-59 + - x-pack-ciGroup12-60 # make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh - - x-pack-ciGroup1 - - x-pack-ciGroup2 - - x-pack-ciGroup3 - - x-pack-ciGroup4 - - x-pack-ciGroup5 - - x-pack-ciGroup6 - - x-pack-ciGroup7 + # - x-pack-ciGroup1 + # - x-pack-ciGroup2 + # - x-pack-ciGroup3 + # - x-pack-ciGroup4 + # - x-pack-ciGroup5 + # - x-pack-ciGroup6 + # - x-pack-ciGroup7 # `~` is yaml for `null` exclude: ~ From ec1c55b15e114cd1abceddc54cbe5409dae46090 Mon Sep 17 00:00:00 2001 From: vitalics Date: Thu, 18 Apr 2019 17:46:26 +0300 Subject: [PATCH 05/11] revert ci jobs --- .ci/jobs.yml | 98 ++++++++++------------------------------------------ 1 file changed, 19 insertions(+), 79 deletions(-) diff --git a/.ci/jobs.yml b/.ci/jobs.yml index 9f74acd1df4a3..596f22215a2a6 100644 --- a/.ci/jobs.yml +++ b/.ci/jobs.yml @@ -1,86 +1,26 @@ JOB: - kibana-intake - x-pack-intake - # - kibana-ciGroup1 - # - kibana-ciGroup2 - # - kibana-ciGroup3 - # - kibana-ciGroup4 - # - kibana-ciGroup5 - # - kibana-ciGroup6 - # - kibana-ciGroup7 - # - kibana-ciGroup8 - # - kibana-ciGroup9 - # - kibana-ciGroup10 - # - kibana-ciGroup11 - # - kibana-ciGroup12 - - x-pack-ciGroup12-1 - - x-pack-ciGroup12-2 - - x-pack-ciGroup12-3 - - x-pack-ciGroup12-4 - - x-pack-ciGroup12-5 - - x-pack-ciGroup12-6 - - x-pack-ciGroup12-7 - - x-pack-ciGroup12-8 - - x-pack-ciGroup12-9 - - x-pack-ciGroup12-10 - - x-pack-ciGroup12-11 - - x-pack-ciGroup12-12 - - x-pack-ciGroup12-13 - - x-pack-ciGroup12-14 - - x-pack-ciGroup12-15 - - x-pack-ciGroup12-16 - - x-pack-ciGroup12-17 - - x-pack-ciGroup12-18 - - x-pack-ciGroup12-19 - - x-pack-ciGroup12-20 - - x-pack-ciGroup12-21 - - x-pack-ciGroup12-22 - - x-pack-ciGroup12-23 - - x-pack-ciGroup12-24 - - x-pack-ciGroup12-25 - - x-pack-ciGroup12-26 - - x-pack-ciGroup12-27 - - x-pack-ciGroup12-28 - - x-pack-ciGroup12-29 - - x-pack-ciGroup12-30 - - x-pack-ciGroup12-31 - - x-pack-ciGroup12-32 - - x-pack-ciGroup12-33 - - x-pack-ciGroup12-34 - - x-pack-ciGroup12-35 - - x-pack-ciGroup12-36 - - x-pack-ciGroup12-37 - - x-pack-ciGroup12-38 - - x-pack-ciGroup12-39 - - x-pack-ciGroup12-40 - - x-pack-ciGroup12-41 - - x-pack-ciGroup12-42 - - x-pack-ciGroup12-43 - - x-pack-ciGroup12-44 - - x-pack-ciGroup12-45 - - x-pack-ciGroup12-46 - - x-pack-ciGroup12-47 - - x-pack-ciGroup12-48 - - x-pack-ciGroup12-49 - - x-pack-ciGroup12-50 - - x-pack-ciGroup12-51 - - x-pack-ciGroup12-52 - - x-pack-ciGroup12-53 - - x-pack-ciGroup12-54 - - x-pack-ciGroup12-55 - - x-pack-ciGroup12-56 - - x-pack-ciGroup12-57 - - x-pack-ciGroup12-58 - - x-pack-ciGroup12-59 - - x-pack-ciGroup12-60 + - kibana-ciGroup1 + - kibana-ciGroup2 + - kibana-ciGroup3 + - kibana-ciGroup4 + - kibana-ciGroup5 + - kibana-ciGroup6 + - kibana-ciGroup7 + - kibana-ciGroup8 + - kibana-ciGroup9 + - kibana-ciGroup10 + - kibana-ciGroup11 + - kibana-ciGroup12 # make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh - # - x-pack-ciGroup1 - # - x-pack-ciGroup2 - # - x-pack-ciGroup3 - # - x-pack-ciGroup4 - # - x-pack-ciGroup5 - # - x-pack-ciGroup6 - # - x-pack-ciGroup7 + - x-pack-ciGroup1 + - x-pack-ciGroup2 + - x-pack-ciGroup3 + - x-pack-ciGroup4 + - x-pack-ciGroup5 + - x-pack-ciGroup6 + - x-pack-ciGroup7 # `~` is yaml for `null` exclude: ~ From 6865f110adb59a123d5879b48adaec0872fa008d Mon Sep 17 00:00:00 2001 From: vitalics Date: Tue, 30 Apr 2019 10:13:01 +0300 Subject: [PATCH 06/11] fix review issues --- test/functional/apps/visualize/_tsvb_table.ts | 4 ++-- test/functional/page_objects/visual_builder_page.ts | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/functional/apps/visualize/_tsvb_table.ts b/test/functional/apps/visualize/_tsvb_table.ts index 6b32d4c8f6af5..18f741bc9f8f2 100644 --- a/test/functional/apps/visualize/_tsvb_table.ts +++ b/test/functional/apps/visualize/_tsvb_table.ts @@ -29,8 +29,8 @@ export default function({ getPageObjects }: FtrProviderContext) { beforeEach(async () => { await visualBuilder.resetPage('2015-09-22 06:00:00.000', '2015-09-22 11:00:00.000'); await visualBuilder.clickTable(); - // table preparation - await visualBuilder.checkTableExisting(); + + await visualBuilder.checkTableTabIsPresent(); await visualBuilder.selectGroupByField('machine.os.raw'); await visualBuilder.setColumnLabelValue('OS'); await visualize.waitForVisualizationRenderingStabilized(); diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index b64b2abf0c558..a2b1090034048 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -309,9 +309,13 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro * @returns {Promise} * @memberof VisualBuilderPage */ - public async checkTableExisting(): Promise { + public async checkTableTabIsPresent(): Promise { await testSubjects.existOrFail('visualizationLoader'); - await testSubjects.existOrFail('noTSVBDataMessage'); + + const noDataExists = await testSubjects.exists('noTSVBDataMessage'); + if (!noDataExists) { + await testSubjects.existOrFail('tableView'); + } } /** From 5985f952fd4ecddff5d2e74af700ebada1c0b349 Mon Sep 17 00:00:00 2001 From: vitalics Date: Thu, 16 May 2019 18:46:29 +0300 Subject: [PATCH 07/11] fix logic for check table presentance. --- test/functional/page_objects/visual_builder_page.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts index a2b1090034048..8bc5114bf953f 100644 --- a/test/functional/page_objects/visual_builder_page.ts +++ b/test/functional/page_objects/visual_builder_page.ts @@ -311,10 +311,10 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro */ public async checkTableTabIsPresent(): Promise { await testSubjects.existOrFail('visualizationLoader'); - - const noDataExists = await testSubjects.exists('noTSVBDataMessage'); - if (!noDataExists) { - await testSubjects.existOrFail('tableView'); + const isDataExists = await testSubjects.exists('tableView'); + log.debug(`data is already rendered: ${isDataExists}`); + if (!isDataExists) { + await testSubjects.existOrFail('noTSVBDataMessage'); } } @@ -339,7 +339,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro * @memberof VisualBuilderPage */ public async setFieldForAggregation(field: string, aggNth: number = 0): Promise { - const labels = await find.allByCssSelector('.tvbSeriesEditor__container .tvbSeriesEditor'); + const labels = await testSubjects.findAll('aggRow'); const label = labels[aggNth]; const fieldEl = (await label.findAllByCssSelector('[data-test-subj = "comboBoxInput"]'))[1]; await comboBox.setElement(fieldEl, field); From 5f51e64b5dc8a7b641a1fb7f5faad1f4f4a85dd1 Mon Sep 17 00:00:00 2001 From: vitalics Date: Fri, 17 May 2019 11:57:45 +0300 Subject: [PATCH 08/11] run 30 times run for ciGroup 12 --- .ci/jobs.yml | 68 +++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/.ci/jobs.yml b/.ci/jobs.yml index 596f22215a2a6..56c315eb1b7ee 100644 --- a/.ci/jobs.yml +++ b/.ci/jobs.yml @@ -1,26 +1,56 @@ JOB: - kibana-intake - x-pack-intake - - kibana-ciGroup1 - - kibana-ciGroup2 - - kibana-ciGroup3 - - kibana-ciGroup4 - - kibana-ciGroup5 - - kibana-ciGroup6 - - kibana-ciGroup7 - - kibana-ciGroup8 - - kibana-ciGroup9 - - kibana-ciGroup10 - - kibana-ciGroup11 - - kibana-ciGroup12 + - kibana-ciGroup12-1 + - kibana-ciGroup12-2 + - kibana-ciGroup12-3 + - kibana-ciGroup12-4 + - kibana-ciGroup12-5 + - kibana-ciGroup12-6 + - kibana-ciGroup12-7 + - kibana-ciGroup12-8 + - kibana-ciGroup12-9 + - kibana-ciGroup12-10 + - kibana-ciGroup12-11 + - kibana-ciGroup12-12 + - kibana-ciGroup12-13 + - kibana-ciGroup12-14 + - kibana-ciGroup12-15 + - kibana-ciGroup12-16 + - kibana-ciGroup12-17 + - kibana-ciGroup12-18 + - kibana-ciGroup12-19 + - kibana-ciGroup12-20 + - kibana-ciGroup12-21 + - kibana-ciGroup12-22 + - kibana-ciGroup12-23 + - kibana-ciGroup12-24 + - kibana-ciGroup12-25 + - kibana-ciGroup12-26 + - kibana-ciGroup12-27 + - kibana-ciGroup12-28 + - kibana-ciGroup12-29 + - kibana-ciGroup12-30 + # - kibana-ciGroup1 + # - kibana-ciGroup2 + # - kibana-ciGroup3 + # - kibana-ciGroup4 + # - kibana-ciGroup5 + # - kibana-ciGroup6 + # - kibana-ciGroup7 + # - kibana-ciGroup8 + # - kibana-ciGroup9 + # - kibana-ciGroup10 + # - kibana-ciGroup11 + # - kibana-ciGroup12 # make sure all x-pack-ciGroups are listed in test/scripts/jenkins_xpack_ci_group.sh - - x-pack-ciGroup1 - - x-pack-ciGroup2 - - x-pack-ciGroup3 - - x-pack-ciGroup4 - - x-pack-ciGroup5 - - x-pack-ciGroup6 - - x-pack-ciGroup7 + # - x-pack-ciGroup1 + # - x-pack-ciGroup2 + # - x-pack-ciGroup3 + # - x-pack-ciGroup4 + # - x-pack-ciGroup5 + # - x-pack-ciGroup6 + # - x-pack-ciGroup7 # `~` is yaml for `null` exclude: ~ From 6412572b55a3f149c4ad05ed70c8b97b80e74d03 Mon Sep 17 00:00:00 2001 From: vitalics Date: Fri, 17 May 2019 12:12:56 +0300 Subject: [PATCH 09/11] fix nultirun job usage --- src/functional_test_runner/lib/mocha/setup_mocha.js | 7 +++++-- test/scripts/jenkins_ci_group.sh | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/functional_test_runner/lib/mocha/setup_mocha.js b/src/functional_test_runner/lib/mocha/setup_mocha.js index a7a302f222a57..28ba0fadb3e54 100644 --- a/src/functional_test_runner/lib/mocha/setup_mocha.js +++ b/src/functional_test_runner/lib/mocha/setup_mocha.js @@ -60,8 +60,11 @@ export async function setupMocha(lifecycle, log, config, providers) { filterSuitesByTags({ log, mocha, - include: config.get('suiteTags.include'), - exclude: config.get('suiteTags.exclude'), + include: config.get('suiteTags.include') + .map(tag => tag.replace(/-\d+$/, '')), + exclude: config.get('suiteTags.exclude') + .map(tag => tag.replace(/-\d+$/, '')), + }); return mocha; diff --git a/test/scripts/jenkins_ci_group.sh b/test/scripts/jenkins_ci_group.sh index 521719be6a1a4..635848dedbd4c 100755 --- a/test/scripts/jenkins_ci_group.sh +++ b/test/scripts/jenkins_ci_group.sh @@ -19,7 +19,7 @@ node scripts/build --debug --oss; export TEST_BROWSER_HEADLESS=1 -checks-reporter-with-killswitch "Functional tests / Group ${CI_GROUP}" yarn run grunt "run:functionalTests_ciGroup${CI_GROUP}"; +# checks-reporter-with-killswitch "Functional tests / Group ${CI_GROUP}" yarn run grunt "run:functionalTests_ciGroup${CI_GROUP}"; if [ "$CI_GROUP" == "1" ]; then # build kbn_tp_sample_panel_action From ab28625fd5b930df87cff729cc93ce371c8a8045 Mon Sep 17 00:00:00 2001 From: spalger Date: Wed, 22 May 2019 09:34:13 -0700 Subject: [PATCH 10/11] disable ciGroup membership check --- test/scripts/jenkins_ci_group.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scripts/jenkins_ci_group.sh b/test/scripts/jenkins_ci_group.sh index 635848dedbd4c..3d680ab9ca843 100755 --- a/test/scripts/jenkins_ci_group.sh +++ b/test/scripts/jenkins_ci_group.sh @@ -13,7 +13,7 @@ function report { trap report EXIT -"$(FORCE_COLOR=0 yarn bin)/grunt" functionalTests:ensureAllTestsInCiGroup; +# "$(FORCE_COLOR=0 yarn bin)/grunt" functionalTests:ensureAllTestsInCiGroup; node scripts/build --debug --oss; From c661835b31f5dde1b4583e4ef77dcdbc83156f12 Mon Sep 17 00:00:00 2001 From: spalger Date: Wed, 22 May 2019 09:37:01 -0700 Subject: [PATCH 11/11] reenable functional test groups --- test/scripts/jenkins_ci_group.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scripts/jenkins_ci_group.sh b/test/scripts/jenkins_ci_group.sh index 3d680ab9ca843..c80b80e486b49 100755 --- a/test/scripts/jenkins_ci_group.sh +++ b/test/scripts/jenkins_ci_group.sh @@ -19,7 +19,7 @@ node scripts/build --debug --oss; export TEST_BROWSER_HEADLESS=1 -# checks-reporter-with-killswitch "Functional tests / Group ${CI_GROUP}" yarn run grunt "run:functionalTests_ciGroup${CI_GROUP}"; +checks-reporter-with-killswitch "Functional tests / Group ${CI_GROUP}" yarn run grunt "run:functionalTests_ciGroup${CI_GROUP}"; if [ "$CI_GROUP" == "1" ]; then # build kbn_tp_sample_panel_action