Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Fix styling after breaking EUI changes #27021

Merged
merged 2 commits into from
Dec 12, 2018
Merged

[Infra UI] Fix styling after breaking EUI changes #27021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee57503
Fix eui theme import due to upstream changes
weltenwort Dec 12, 2018
d29a76f
Re-enable header section growth after upstream changes
weltenwort Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/infra/public/apps/start_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ThemeProvider } from 'styled-components';

// TODO use theme provided from parentApp when kibana supports it
import { EuiErrorBoundary } from '@elastic/eui';
import * as euiVars from '@elastic/eui/dist/eui_theme_k6_light.json';
import euiVars from '@elastic/eui/dist/eui_theme_k6_light.json';
import { I18nProvider } from '@kbn/i18n/react';
import { InfraFrontendLibs } from '../lib/lib';
import { PageRouter } from '../routes';
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/infra/public/components/header/legacy_header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const LegacyHeader: React.SFC<LegacyHeaderProps> = ({
breadcrumbs = [],
}) => (
<HeaderWrapper>
<EuiHeaderSection>
<EuiHeaderSection grow>
<EuiHeaderBreadcrumbs breadcrumbs={breadcrumbs} />
</EuiHeaderSection>
{appendSections}
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/infra/types/eui.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ declare module '@elastic/eui' {
export type EuiHeaderSectionSide = 'left' | 'right';
type EuiHeaderSectionProps = CommonProps & {
side?: EuiHeaderSectionSide;
grow?: boolean;
};
export const EuiHeaderSection: React.SFC<EuiHeaderSectionProps>;

Expand Down