[6.x] Index lifecycle (#25553) #26918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] Index lifecycle (elastic#25071) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * bare bones policy table implementation * implementing delete policy behavior * fixing sorting and paging * fixing policy table title * rudimentary navigation flow * fixing delete * Index lifecycle management wizard (elastic#21925) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * adjusting to changes in ES API * adding version and modified date to policies table * implementing new CRUD approach * simplified delete * cleanup edit_policy * removed wizard code * fixing issue with edit policy * fixing issue with closing delete confirmation modal * making max age and max size not mutually exclusive * removing names of covered indices from policy table * changing minimum_age to min_age * first pass at index lifecycle extensions * adding retry button for ilm covered index that is in error * first pass at index lifecycle banner * i18n work * more i18n * fixing issue with node attributes * removing console.log statements * fixing issue with deserializing number_of_shards for edit policy * defaulting shrink to false and fixing ui spacing issue * removing hot phase shard count from warm phase * scrolling to first error when user submits form for edit policy * disabling UI for index management when enabled is false in kibana.yml * disabling index lifecycle management when enabled is false in kibana.yml * extending index management filter to allow for searching fields * add support for filtering to indices with errors for index lifecycle management banner * i18n work * fixing error wrappers * fixing tests * adding view JSON for index lifecycle policy on edit screen * fixing label for i18n on policy JSON flyout * removing console.log statements * fixing tests * removing console.log statements * adding key for banner extensions * fixing bad import for FormattedMessage * add link to edit index lifecycle policy from index management index summary * adding key for map of summary extensions * adding proper icon for retry lifecycle action * factoring out common min age component * factoring out common NodeAllocation component * add copy to clipboard for json policy flyout * adding validation rules for policy names to match ES rules * fixing issues with policy names with non-alphabetic characters like & ^ % ? * moving create policy button to top right and adding fill * adding better empty state for policy list * moving shrink and force merge titles and descriptions to the left * moving show JSON button to right and limiting width of JSON flyout * fixing warning about lifecycle prop type for JSON flyout * fixing issue with warning on prop isShowingErrors * removing outdated README * simplifying constants * moving components to more logical places * moving lib and api files to services * renaming provider to enricher * factoring out common data enricher behavior * consolidating index management extension code * removing unnecessary colon * Revert "removing unnecessary colon" This reverts commit 1971280. * removing unnecessary colon * adding callout to ilm summary for errors * better formatting for banner extensions * Revert "disabling UI for index management when enabled is false in kibana.yml" This reverts commit 45d4e8c. * removing unnecessary code for detecting disabled plugin * adding config prefix of xpack.index_lifecycle_management * making policy link use href and consolidating link encoding logic * removed outdated comment * removed outdated comment * better solution for policy name in URI * fixing issue with index management being disabled and index_lifecycle_management not * adding link to index management list filtered to policy name from index_lifecycle_management policy list * fixing tests * adding popover for stack trace for ilm errors * adding stack trace and phase definition popovers to ilm summary in index management * adding to blacklist for node attributes and not showing node allocation section when there are not any node attributes to choose from * not showing create policy button in upper right for empty state * moving policy name form field to right to be consistent with the rest of the form layout * moving save button to left and using secondary color * added copied to clipboard toast message * moving activate/deactivate buttons to left on edit policy page * deleting unnecessary less file * using spacer instead of style * translating success message for edit policy save * fixing missing props warnings for EuiDescribedFormGroup usages * better error handling borrowed from rollups * disabling delete when a policy is attached to indices * adding remove lifecycle policy action * fixing issue with remove ilm policy showing for non-managed indices` * adding add lifecycle policy action to index management extensions in index lifecycle management * adding confirm modal for remove lifecycle policy * fixing validation * fixing issue with back button and edit policy retaining old policy * removing console.log * making no policy modal for add lifecycle policy make more sense (no add button) * Calling reloadIndices when a lifecycle policy gets added or removed * fixing logic issue with spinner showing * refactoring confirm modal on policy list page * adding an add to index template button on policy list page * fixing console warning about select value being null * fixing issue with modal not opening from index management table manage menu * changing app title and adding i18n for it * more naming changes and adding beta badge * adding filter extension to index management and using it to add filters for index lifecycle management * fixing broken jest test * fixing issue with banners appearing/disappearing based on filters * adding xpack.ilm.ui.enabled to allow cloud to disable the ui * add ability to configure list of node attributes to ignore in kibana.yml for cloud * filtering out reserved system templates from fetch route list * adding warning when user tries to add a policy to a template that already has a policy * fixing a11y issues on edit policy form * incorporating docs team feedback on copy * adding learn more link to add policy to index template modal * fixing app order for management * fixing breadcrumb issue by adding redirect for BASE_PATH (and adding memory leak fix) * making version and covered indices column smaller and adding horizontal scroll and min width * right align actions and better width solution for columns * bigger spacer under callout for no node attributes * restricting width of edit page * fixing typo * removing unnecessary store code for index templates * fixing react warning about boolean type * moving beta badge in line with title on policies screen * better UI for show JSON for edit policy * commenting on the memory leak fix for React Router redirects * fixing fatal error with node allocation flyout * fixing issue with banner not showing * moving unmanaged/managed filter to filter group to make it clearer what they mean * removing unused code * copy changes * adding context menu for policy table instead of icon buttons * adding fix errors badge for phases * removing unnecessary close button in flyout footer * adding spinner when nodeOptions are not present * moving view a list button below input * adding more explanation to add policy to index template modal * adding documentation link for main ILM docs in ES * only showing view nodes link when node attributes are selected * removing colon from flyout title * fixing layout for view nodes button for attributes * making loading spinner larger for node attributes select * fixing issue with button going off end of table * removing title from empty prompt for policy table * fixing max width for edit policy page * copy edits * don't show pager when number of policies is less than minimum page size * making number of replicas optional and adding optional label * fixing sort for policy table * fixing flicker for node allocation * removing redundant message for index policies defined * fixing spacing/alignment issues on error display for summary * fixing issues with pager not showing and controls disappearing when filters applied * adding tests for policy table * more test additions * making search bar incremental for index management * making JSON policy flyout show ES request JSON not internal representation * adding error message when user tries to submit add policy to index without selecting policy * adding validation for missing template on add policy to index template modal * adding tests for ilm index management extensions * adding tests for edit policy * removing learn about node attributes link until docs come * fixing prop type warning * adding missing translations * better tests for edit policy * adding tests for node attribute inputs * better tests for node attributes * fixing policy table test * fixing bad i18n id * updating snapshot
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: