back to canvas way of loading plugins #26463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
lukeelmers
reviewed
Nov 30, 2018
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
20e4a5a to
482c447
Compare
ppisljar
added
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-app |
|
Pinging @elastic/kibana-canvas |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
482c447 to
484b34a
Compare
💔 Build Failed |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
484b34a to
3f323d9
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
3f323d9 to
8dbdc5e
Compare
💚 Build Succeeded |
clintandrewhall
approved these changes
Dec 3, 2018
| import { getPluginStream } from '../lib/get_plugin_stream'; | ||
|
|
||
| export function plugins(server) { | ||
| server.route({ | ||
| method: 'GET', | ||
| path: '/api/canvas/plugins', | ||
| handler: function (request) { | ||
| handler: function (request, h) { |
There was a problem hiding this comment.
Could you make this a fully-stated variable, so it's clear what this is?
There was a problem hiding this comment.
FYI, h is the standard name for the response toolkit in newer versions of Hapi
rashidkpc
approved these changes
Dec 4, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Dec 5, 2018
ppisljar
added a commit
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During moving interpreter to OSS dynamic plugin loading was broken, this tries to fix it, and goes back to the way canvas handled plugin loading before
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[x] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately