From ec5bbf7124ac48a1c68198823539849fc2e7a7a1 Mon Sep 17 00:00:00 2001 From: Stacey Gammon Date: Tue, 23 Oct 2018 14:04:29 -0400 Subject: [PATCH 1/2] Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes --- test/functional/page_objects/dashboard_page.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/functional/page_objects/dashboard_page.js b/test/functional/page_objects/dashboard_page.js index 6f9c8f100899e..969ecd77c2963 100644 --- a/test/functional/page_objects/dashboard_page.js +++ b/test/functional/page_objects/dashboard_page.js @@ -317,11 +317,9 @@ export function DashboardPageProvider({ getService, getPageObjects }) { await this.clickSave(); } - await PageObjects.header.waitUntilLoadingHasFinished(); - // Confirm that the Dashboard has actually been saved await testSubjects.existOrFail('saveDashboardSuccess'); - + await PageObjects.header.waitUntilLoadingHasFinished(); await this.waitForSaveModalToClose(); } From cca7bf195c24d7b0b264f96d1985cf608347b14c Mon Sep 17 00:00:00 2001 From: Stacey Gammon Date: Tue, 23 Oct 2018 14:06:11 -0400 Subject: [PATCH 2/2] turn test back on --- test/functional/apps/dashboard/_embeddable_rendering.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/apps/dashboard/_embeddable_rendering.js b/test/functional/apps/dashboard/_embeddable_rendering.js index 07ceeed9544a1..1a0f47ed28e17 100644 --- a/test/functional/apps/dashboard/_embeddable_rendering.js +++ b/test/functional/apps/dashboard/_embeddable_rendering.js @@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }) { await dashboardExpect.vegaTextsDoNotExist(['5,000']); }; - describe.skip('dashboard embeddable rendering', function describeIndexTests() { + describe('dashboard embeddable rendering', function describeIndexTests() { before(async () => { await PageObjects.dashboard.clickNewDashboard();