From af91e8e666f38c5528ea6e17102bd28b865165ff Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Thu, 16 Jan 2025 12:03:00 -0700 Subject: [PATCH 1/7] Add warnings to upgrade assistant for search sessions --- docs/upgrade-notes.asciidoc | 22 +++ .../shared/data/server/deprecations/index.ts | 10 ++ .../server/deprecations/search_sessions.ts | 138 ++++++++++++++++++ .../plugins/shared/data/server/plugin.ts | 2 + 4 files changed, 172 insertions(+) create mode 100644 src/platform/plugins/shared/data/server/deprecations/index.ts create mode 100644 src/platform/plugins/shared/data/server/deprecations/search_sessions.ts diff --git a/docs/upgrade-notes.asciidoc b/docs/upgrade-notes.asciidoc index efad12e457b1d..74929af33fe57 100644 --- a/docs/upgrade-notes.asciidoc +++ b/docs/upgrade-notes.asciidoc @@ -200,4 +200,26 @@ Systems that use HTTP/1 or don't have TLS configured will get a deprecation warn Verify that TLS is properly configured by enabling it and providing valid certificates in the settings. Test your system to ensure that connections are established securely over HTTP/2. If your Kibana server is hosted behind a load balancer or reverse proxy we recommend testing your deployment configuration before upgrading to 9.0. +==== + + +[discrete] +[[known-issue-xxxxxx]] +.Search sessions has been disabled by default (9.0.0) +[%collapsible] +==== +*Details* + +Starting from version 9.0.0, search sessions has been disabled by default. To view, manage, and restore search sessions, the feature needs to be explicitly re-enabled. + +*Impact* + +Search sessions will be disabled unless they are explicitly enabled in config.yml. + +*Action* + +If you would like to continue using, managing, and restoring search sessions in 9.0, you'll need to re-enable them in your kibana.yml configuration file. If not, no action is necessary. + +To re-enable search sessions, add the following in your config.yml: + +``` +data.search.sessions.enabled: true +``` ==== \ No newline at end of file diff --git a/src/platform/plugins/shared/data/server/deprecations/index.ts b/src/platform/plugins/shared/data/server/deprecations/index.ts new file mode 100644 index 0000000000000..4baf9c3e1e867 --- /dev/null +++ b/src/platform/plugins/shared/data/server/deprecations/index.ts @@ -0,0 +1,10 @@ +/* + * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one + * or more contributor license agreements. Licensed under the "Elastic License + * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side + * Public License v 1"; you may not use this file except in compliance with, at + * your election, the "Elastic License 2.0", the "GNU Affero General Public + * License v3.0 only", or the "Server Side Public License, v 1". + */ + +export { createSearchSessionsDeprecationsConfig } from './search_sessions'; diff --git a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts new file mode 100644 index 0000000000000..15ba8e23973e2 --- /dev/null +++ b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts @@ -0,0 +1,138 @@ +/* + * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one + * or more contributor license agreements. Licensed under the "Elastic License + * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side + * Public License v 1"; you may not use this file except in compliance with, at + * your election, the "Elastic License 2.0", the "GNU Affero General Public + * License v3.0 only", or the "Server Side Public License, v 1". + */ + +import type { + CoreSetup, + DeprecationsDetails, + GetDeprecationsContext, + RegisterDeprecationsConfig, + SavedObjectsFindResult, +} from '@kbn/core/server'; +import { i18n } from '@kbn/i18n'; +import type { DocLinks } from '@kbn/doc-links'; +import type { DeprecationDetailsMessage } from '@kbn/core-deprecations-common'; +import { SEARCH_SESSION_TYPE, SearchSessionSavedObjectAttributes } from '../../common'; + +type SearchSessionAttributes = Pick< + SearchSessionSavedObjectAttributes, + 'name' | 'username' | 'expires' +>; + +export const createSearchSessionsDeprecationsConfig: ( + core: CoreSetup +) => RegisterDeprecationsConfig = (core: CoreSetup) => ({ + getDeprecations: async (context: GetDeprecationsContext): Promise => { + const [coreStart] = await core.getStartServices(); + const savedObjectsClient = coreStart.savedObjects.getScopedClient(context.request, { + includedHiddenTypes: [SEARCH_SESSION_TYPE], + }); + const finder = savedObjectsClient.createPointInTimeFinder({ + type: 'search-session', + perPage: 1000, + fields: ['name', 'username', 'expires'], + namespaces: ['*'], + }); + + const searchSessions: Array> = []; + + for await (const response of finder.find()) { + searchSessions.push( + ...response.saved_objects.filter( + (so) => new Date(so.attributes.expires).getTime() > Date.now() + ) + ); + } + + if (!searchSessions.length) { + return []; + } + + return [ + { + title: i18n.translate('data.deprecations.searchSessionsTitle', { + defaultMessage: 'Found active search sessions', + }), + message: buildMessage({ + searchSessions, + docLinks: core.docLinks.links, + }), + deprecationType: 'feature', + level: 'warning', + correctiveActions: { + manualSteps: [ + i18n.translate('data.deprecations.searchSessions.manualStepOneMessage', { + defaultMessage: 'Open the kibana.yml config file.', + }), + i18n.translate('data.deprecations.searchSessions.manualStepTwoMessage', { + defaultMessage: 'Add the following: "data.search.sessions.enabled: true"', + }), + i18n.translate('data.deprecations.searchSessions.manualStepTwoMessage', { + defaultMessage: + 'Alternatively, if you do not want to keep these search sessions after upgrade, navigate to Stack Management > Search Sessions and delete any sessions that have not expired.', + }), + ], + }, + }, + ]; + }, +}); + +const searchSessionIdLabel = i18n.translate( + 'data.deprecations.searchSessions.searchSessionIdLabel', + { + defaultMessage: 'ID', + } +); + +const searchSessionNameLabel = i18n.translate( + 'data.deprecations.searchSessions.searchSessionNameLabel', + { + defaultMessage: 'Name', + } +); + +const searchSessionUserLabel = i18n.translate( + 'data.deprecations.searchSessions.searchSessionUserLabel', + { + defaultMessage: 'User', + } +); + +const searchSessionSpacesLabel = i18n.translate( + 'data.deprecations.searchSessions.searchSessionSpacesLabel', + { + defaultMessage: 'Spaces', + } +); + +const buildSearchSessionsListEntry = ( + so: SavedObjectsFindResult +) => `- **${searchSessionIdLabel}:** ${so.id} + - **${searchSessionNameLabel}:** ${so.attributes.name} + - **${searchSessionUserLabel}:** ${so.attributes.username} + - **${searchSessionSpacesLabel}:** ${so.namespaces?.join(', ')}`; + +const buildMessage = ({ + searchSessions, + docLinks, +}: { + searchSessions: Array>; + docLinks: DocLinks; +}): DeprecationDetailsMessage => ({ + type: 'markdown', + content: i18n.translate('data.deprecations.scriptedFieldsMessage', { + defaultMessage: `The search sessions feature is deprecated and will be disabled by default in 9.0. You currently have {numberOfSearchSessions} active search session(s). If you would like to continue using, managing, and restoring search sessions in 9.0, you'll need to re-enable them in your kibana.yml configuration file. If not, no action is necessary. +The following is a list of all active search sessions and their associated spaces: +{searchSessionsList}`, + values: { + numberOfSearchSessions: searchSessions.length, + searchSessionsList: searchSessions.map(buildSearchSessionsListEntry).join('\n'), + }, + }), +}); diff --git a/src/platform/plugins/shared/data/server/plugin.ts b/src/platform/plugins/shared/data/server/plugin.ts index c18353960db57..885e4a3c1368e 100644 --- a/src/platform/plugins/shared/data/server/plugin.ts +++ b/src/platform/plugins/shared/data/server/plugin.ts @@ -12,6 +12,7 @@ import { ExpressionsServerSetup } from '@kbn/expressions-plugin/server'; import { PluginStart as DataViewsServerPluginStart } from '@kbn/data-views-plugin/server'; import { UsageCollectionSetup } from '@kbn/usage-collection-plugin/server'; import { FieldFormatsSetup, FieldFormatsStart } from '@kbn/field-formats-plugin/server'; +import { createSearchSessionsDeprecationsConfig } from './deprecations'; import { ConfigSchema } from './config'; import type { ISearchSetup, ISearchStart } from './search'; import { DatatableUtilitiesService } from './datatable_utilities'; @@ -90,6 +91,7 @@ export class DataServerPlugin this.kqlTelemetryService.setup(core, { usageCollection }); core.uiSettings.register(getUiSettings(core.docLinks, this.config.enableUiSettingsValidations)); + core.deprecations.registerDeprecations(createSearchSessionsDeprecationsConfig(core)); const searchSetup = this.searchService.setup(core, { expressions, From 0c2c7acfe86dc3635897cc614d19aea2da0b3ee1 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Thu, 16 Jan 2025 19:15:32 +0000 Subject: [PATCH 2/7] [CI] Auto-commit changed files from 'node scripts/notice' --- src/platform/plugins/shared/data/tsconfig.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/platform/plugins/shared/data/tsconfig.json b/src/platform/plugins/shared/data/tsconfig.json index 1edc83a23e05e..cc404762e91f8 100644 --- a/src/platform/plugins/shared/data/tsconfig.json +++ b/src/platform/plugins/shared/data/tsconfig.json @@ -53,7 +53,9 @@ "@kbn/search-types", "@kbn/safer-lodash-set", "@kbn/esql-utils", - "@kbn/shared-ux-table-persist" + "@kbn/shared-ux-table-persist", + "@kbn/doc-links", + "@kbn/core-deprecations-common" ], "exclude": [ "target/**/*", From ca3e3ebd19bea302d084c51be40015100e67969a Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Thu, 16 Jan 2025 12:55:57 -0700 Subject: [PATCH 3/7] Add link to upgrade notes --- docs/upgrade-notes.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/upgrade-notes.asciidoc b/docs/upgrade-notes.asciidoc index 74929af33fe57..eb50ab066d673 100644 --- a/docs/upgrade-notes.asciidoc +++ b/docs/upgrade-notes.asciidoc @@ -204,7 +204,7 @@ If your Kibana server is hosted behind a load balancer or reverse proxy we recom [discrete] -[[known-issue-xxxxxx]] +[[known-issue-206998]] .Search sessions has been disabled by default (9.0.0) [%collapsible] ==== From 5fff4689225c99843c9d2a50ecc468875864cfda Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Thu, 16 Jan 2025 12:57:53 -0700 Subject: [PATCH 4/7] Remove unused reference --- .../shared/data/server/deprecations/search_sessions.ts | 8 +------- src/platform/plugins/shared/data/tsconfig.json | 1 - 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts index 15ba8e23973e2..ef15684ba0b73 100644 --- a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts +++ b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts @@ -15,7 +15,6 @@ import type { SavedObjectsFindResult, } from '@kbn/core/server'; import { i18n } from '@kbn/i18n'; -import type { DocLinks } from '@kbn/doc-links'; import type { DeprecationDetailsMessage } from '@kbn/core-deprecations-common'; import { SEARCH_SESSION_TYPE, SearchSessionSavedObjectAttributes } from '../../common'; @@ -58,10 +57,7 @@ export const createSearchSessionsDeprecationsConfig: ( title: i18n.translate('data.deprecations.searchSessionsTitle', { defaultMessage: 'Found active search sessions', }), - message: buildMessage({ - searchSessions, - docLinks: core.docLinks.links, - }), + message: buildMessage({ searchSessions }), deprecationType: 'feature', level: 'warning', correctiveActions: { @@ -120,10 +116,8 @@ const buildSearchSessionsListEntry = ( const buildMessage = ({ searchSessions, - docLinks, }: { searchSessions: Array>; - docLinks: DocLinks; }): DeprecationDetailsMessage => ({ type: 'markdown', content: i18n.translate('data.deprecations.scriptedFieldsMessage', { diff --git a/src/platform/plugins/shared/data/tsconfig.json b/src/platform/plugins/shared/data/tsconfig.json index cc404762e91f8..1418e95b45e40 100644 --- a/src/platform/plugins/shared/data/tsconfig.json +++ b/src/platform/plugins/shared/data/tsconfig.json @@ -54,7 +54,6 @@ "@kbn/safer-lodash-set", "@kbn/esql-utils", "@kbn/shared-ux-table-persist", - "@kbn/doc-links", "@kbn/core-deprecations-common" ], "exclude": [ From c1112861f5dddc9c3c0d9e2f1e3f582010f3df5f Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Fri, 24 Jan 2025 14:13:31 -0700 Subject: [PATCH 5/7] Review feedback --- docs/upgrade-notes.asciidoc | 2 +- .../data/server/config_deprecations.test.ts | 6 +- .../shared/data/server/config_deprecations.ts | 16 ++--- .../server/deprecations/search_sessions.ts | 69 ++++--------------- 4 files changed, 27 insertions(+), 66 deletions(-) diff --git a/docs/upgrade-notes.asciidoc b/docs/upgrade-notes.asciidoc index cc0fcaa367de7..06a6b81740150 100644 --- a/docs/upgrade-notes.asciidoc +++ b/docs/upgrade-notes.asciidoc @@ -335,7 +335,7 @@ Starting from version 9.0.0, search sessions has been disabled by default. To vi Search sessions will be disabled unless they are explicitly enabled in config.yml. *Action* + -If you would like to continue using, managing, and restoring search sessions in 9.0, you'll need to re-enable them in your kibana.yml configuration file. If not, no action is necessary. +If you would like to continue using, managing, and restoring search sessions in 9.0, you'll need to re-enable the feature in your kibana.yml configuration file. If not, no action is necessary. To re-enable search sessions, add the following in your config.yml: diff --git a/src/platform/plugins/shared/data/server/config_deprecations.test.ts b/src/platform/plugins/shared/data/server/config_deprecations.test.ts index 1a103ca695549..c208c4093b2b3 100644 --- a/src/platform/plugins/shared/data/server/config_deprecations.test.ts +++ b/src/platform/plugins/shared/data/server/config_deprecations.test.ts @@ -62,7 +62,7 @@ describe('Config Deprecations', () => { expect(messages).toMatchInlineSnapshot(` Array [ "Setting \\"xpack.data_enhanced.search.sessions\\" has been replaced by \\"data.search.sessions\\"", - "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.0.0.", + "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.1.0.", ] `); }); @@ -103,7 +103,7 @@ describe('Config Deprecations', () => { "You no longer need to configure \\"data.search.sessions.expireInterval\\".", "You no longer need to configure \\"data.search.sessions.monitoringTaskTimeout\\".", "You no longer need to configure \\"data.search.sessions.notTouchedInProgressTimeout\\".", - "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.0.0.", + "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.1.0.", ] `); }); @@ -147,7 +147,7 @@ describe('Config Deprecations', () => { "You no longer need to configure \\"data.search.sessions.expireInterval\\".", "You no longer need to configure \\"data.search.sessions.monitoringTaskTimeout\\".", "You no longer need to configure \\"data.search.sessions.notTouchedInProgressTimeout\\".", - "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.0.0.", + "Configuring \\"data.search.sessions.enabled\\" is deprecated and will be removed in 9.1.0.", ] `); }); diff --git a/src/platform/plugins/shared/data/server/config_deprecations.ts b/src/platform/plugins/shared/data/server/config_deprecations.ts index 3235369082839..95e3fc941dcce 100644 --- a/src/platform/plugins/shared/data/server/config_deprecations.ts +++ b/src/platform/plugins/shared/data/server/config_deprecations.ts @@ -27,12 +27,12 @@ export const configDeprecationProvider: ConfigDeprecationProvider = ({ unusedFromRoot('data.search.sessions.notTouchedInProgressTimeout', { level }), // Search sessions config deprecations - deprecateFromRoot('data.search.sessions.enabled', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.notTouchedTimeout', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.maxUpdateRetries', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.defaultExpiration', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.management.maxSessions', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.management.refreshInterval', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.management.refreshTimeout', '9.0.0', { level }), - deprecateFromRoot('data.search.sessions.management.expiresSoonWarning', '9.0.0', { level }), + deprecateFromRoot('data.search.sessions.enabled', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.notTouchedTimeout', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.maxUpdateRetries', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.defaultExpiration', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.management.maxSessions', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.management.refreshInterval', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.management.refreshTimeout', '9.1.0', { level }), + deprecateFromRoot('data.search.sessions.management.expiresSoonWarning', '9.1.0', { level }), ]; diff --git a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts index ef15684ba0b73..bad520a641729 100644 --- a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts +++ b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts @@ -27,26 +27,22 @@ export const createSearchSessionsDeprecationsConfig: ( core: CoreSetup ) => RegisterDeprecationsConfig = (core: CoreSetup) => ({ getDeprecations: async (context: GetDeprecationsContext): Promise => { + const searchSessionsLink = core.http.basePath.prepend('/app/management/kibana/search_sessions'); const [coreStart] = await core.getStartServices(); const savedObjectsClient = coreStart.savedObjects.getScopedClient(context.request, { includedHiddenTypes: [SEARCH_SESSION_TYPE], }); - const finder = savedObjectsClient.createPointInTimeFinder({ + const results = await savedObjectsClient.find({ type: 'search-session', perPage: 1000, fields: ['name', 'username', 'expires'], + sortField: 'created', + sortOrder: 'desc', namespaces: ['*'], }); - const searchSessions: Array> = []; - - for await (const response of finder.find()) { - searchSessions.push( - ...response.saved_objects.filter( - (so) => new Date(so.attributes.expires).getTime() > Date.now() - ) - ); - } + const searchSessions: Array> = + results.saved_objects.filter((so) => new Date(so.attributes.expires).getTime() > Date.now()); if (!searchSessions.length) { return []; @@ -55,22 +51,22 @@ export const createSearchSessionsDeprecationsConfig: ( return [ { title: i18n.translate('data.deprecations.searchSessionsTitle', { - defaultMessage: 'Found active search sessions', + defaultMessage: 'Search sessions has been disabled by default', }), - message: buildMessage({ searchSessions }), + message: buildMessage({ searchSessions, searchSessionsLink }), deprecationType: 'feature', level: 'warning', correctiveActions: { manualSteps: [ i18n.translate('data.deprecations.searchSessions.manualStepOneMessage', { - defaultMessage: 'Open the kibana.yml config file.', + defaultMessage: 'Navigate to Stack Management > Kibana > Search Sessions', }), i18n.translate('data.deprecations.searchSessions.manualStepTwoMessage', { - defaultMessage: 'Add the following: "data.search.sessions.enabled: true"', + defaultMessage: 'Delete search sessions that have not expired', }), i18n.translate('data.deprecations.searchSessions.manualStepTwoMessage', { defaultMessage: - 'Alternatively, if you do not want to keep these search sessions after upgrade, navigate to Stack Management > Search Sessions and delete any sessions that have not expired.', + 'Alternatively, to continue using search sessions, open the kibana.yml config file and add the following: "data.search.sessions.enabled: true"', }), ], }, @@ -79,54 +75,19 @@ export const createSearchSessionsDeprecationsConfig: ( }, }); -const searchSessionIdLabel = i18n.translate( - 'data.deprecations.searchSessions.searchSessionIdLabel', - { - defaultMessage: 'ID', - } -); - -const searchSessionNameLabel = i18n.translate( - 'data.deprecations.searchSessions.searchSessionNameLabel', - { - defaultMessage: 'Name', - } -); - -const searchSessionUserLabel = i18n.translate( - 'data.deprecations.searchSessions.searchSessionUserLabel', - { - defaultMessage: 'User', - } -); - -const searchSessionSpacesLabel = i18n.translate( - 'data.deprecations.searchSessions.searchSessionSpacesLabel', - { - defaultMessage: 'Spaces', - } -); - -const buildSearchSessionsListEntry = ( - so: SavedObjectsFindResult -) => `- **${searchSessionIdLabel}:** ${so.id} - - **${searchSessionNameLabel}:** ${so.attributes.name} - - **${searchSessionUserLabel}:** ${so.attributes.username} - - **${searchSessionSpacesLabel}:** ${so.namespaces?.join(', ')}`; - const buildMessage = ({ searchSessions, + searchSessionsLink, }: { searchSessions: Array>; + searchSessionsLink: string; }): DeprecationDetailsMessage => ({ type: 'markdown', content: i18n.translate('data.deprecations.scriptedFieldsMessage', { - defaultMessage: `The search sessions feature is deprecated and will be disabled by default in 9.0. You currently have {numberOfSearchSessions} active search session(s). If you would like to continue using, managing, and restoring search sessions in 9.0, you'll need to re-enable them in your kibana.yml configuration file. If not, no action is necessary. -The following is a list of all active search sessions and their associated spaces: -{searchSessionsList}`, + defaultMessage: `The search sessions feature is deprecated and is disabled by default in 9.0. You currently have {numberOfSearchSessions} active search session(s): [Manage Search Sessions]({searchSessionsLink})`, values: { numberOfSearchSessions: searchSessions.length, - searchSessionsList: searchSessions.map(buildSearchSessionsListEntry).join('\n'), + searchSessionsLink, }, }), }); From 0c6c5376ed632e0b8c90c112f9227e68debc1bed Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Tue, 28 Jan 2025 10:02:09 -0700 Subject: [PATCH 6/7] Update src/platform/plugins/shared/data/server/deprecations/search_sessions.ts Co-authored-by: Julia Rechkunova --- .../plugins/shared/data/server/deprecations/search_sessions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts index bad520a641729..445a744417920 100644 --- a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts +++ b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts @@ -66,7 +66,7 @@ export const createSearchSessionsDeprecationsConfig: ( }), i18n.translate('data.deprecations.searchSessions.manualStepTwoMessage', { defaultMessage: - 'Alternatively, to continue using search sessions, open the kibana.yml config file and add the following: "data.search.sessions.enabled: true"', + 'Alternatively, to continue using search sessions until 9.1, open the kibana.yml config file and add the following: "data.search.sessions.enabled: true"', }), ], }, From 22fb74a7bfdaa7eac04935cbba5fb94537ba6601 Mon Sep 17 00:00:00 2001 From: Lukas Olson Date: Tue, 28 Jan 2025 13:13:02 -0700 Subject: [PATCH 7/7] Review feedback --- docs/upgrade-notes.asciidoc | 4 ++-- .../shared/data/server/deprecations/search_sessions.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/upgrade-notes.asciidoc b/docs/upgrade-notes.asciidoc index 3bdd6a23e893f..2835541a821a0 100644 --- a/docs/upgrade-notes.asciidoc +++ b/docs/upgrade-notes.asciidoc @@ -325,11 +325,11 @@ If your Kibana server is hosted behind a load balancer or reverse proxy we recom [discrete] [[known-issue-206998]] -.Search sessions has been disabled by default (9.0.0) +.Search sessions disabled by default (9.0.0) [%collapsible] ==== *Details* + -Starting from version 9.0.0, search sessions has been disabled by default. To view, manage, and restore search sessions, the feature needs to be explicitly re-enabled. +Starting from version 9.0.0, search sessions are disabled by default. To view, manage, and restore search sessions, the feature needs to be explicitly re-enabled. *Impact* + Search sessions will be disabled unless they are explicitly enabled in config.yml. diff --git a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts index 445a744417920..2fdd42fd2d898 100644 --- a/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts +++ b/src/platform/plugins/shared/data/server/deprecations/search_sessions.ts @@ -51,7 +51,7 @@ export const createSearchSessionsDeprecationsConfig: ( return [ { title: i18n.translate('data.deprecations.searchSessionsTitle', { - defaultMessage: 'Search sessions has been disabled by default', + defaultMessage: 'Search sessions will be disabled by default', }), message: buildMessage({ searchSessions, searchSessionsLink }), deprecationType: 'feature',