@@ -134,7 +134,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {
@@ -147,7 +147,7 @@ export function LinkedSearch({ savedSearch, eventEmitter }: LinkedSearchProps) {
>
diff --git a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
index 6d8f4ebaffdc..ab2a51b2beef 100644
--- a/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
+++ b/src/plugins/visualizations/public/visualize_app/utils/use/use_linked_search_updates.ts
@@ -48,7 +48,7 @@ export const useLinkedSearchUpdates = (
if (showToast) {
services.toastNotifications.addSuccess(
i18n.translate('visualizations.linkedToSearch.unlinkSuccessNotificationText', {
- defaultMessage: `Unlinked from Discover Session ''{searchTitle}''`,
+ defaultMessage: `Unlinked from Discover session ''{searchTitle}''`,
values: {
searchTitle: savedSearch.title,
},
diff --git a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
index 7d987ecd22a8..e0647737acb8 100644
--- a/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
+++ b/src/plugins/visualizations/public/wizard/search_selection/search_selection.tsx
@@ -55,7 +55,7 @@ export class SearchSelection extends React.Component
{
noItemsMessage={i18n.translate(
'visualizations.newVisWizard.searchSelection.notFoundLabel',
{
- defaultMessage: 'No matching indices or Discover Sessions found.',
+ defaultMessage: 'No matching indices or Discover sessions found.',
}
)}
savedObjectMetaData={[
@@ -65,7 +65,7 @@ export class SearchSelection extends React.Component {
name: i18n.translate(
'visualizations.newVisWizard.searchSelection.savedObjectType.search',
{
- defaultMessage: 'Discover Session',
+ defaultMessage: 'Discover session',
}
),
// ignore the saved searches that have text-based languages queries
From 24ebbc9761693bd010dba910360a22300d0a9665 Mon Sep 17 00:00:00 2001
From: Julia Rechkunova
Date: Wed, 11 Dec 2024 12:07:50 +0100
Subject: [PATCH 20/43] Update docs/developer/plugin-list.asciidoc
Co-authored-by: Davis McPhee
---
docs/developer/plugin-list.asciidoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
index 46b89585f779..97d2bf9c7b60 100644
--- a/docs/developer/plugin-list.asciidoc
+++ b/docs/developer/plugin-list.asciidoc
@@ -309,7 +309,7 @@ oss plugins.
|{kib-repo}blob/{branch}/src/plugins/saved_search/README.md[savedSearch]
|Contains the saved search saved object definition and helpers.
-This object is created when a user saves current session in the Discover app.
+This object is created when a user saves their current session in the Discover app.
|{kib-repo}blob/{branch}/src/plugins/screenshot_mode/README.md[screenshotMode]
From ecfa7d56d978e9fd9b2a61e2f376548a822880a0 Mon Sep 17 00:00:00 2001
From: Julia Rechkunova
Date: Wed, 11 Dec 2024 12:12:20 +0100
Subject: [PATCH 21/43] Update docs/discover/save-search.asciidoc
Co-authored-by: Davis McPhee
---
docs/discover/save-search.asciidoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/discover/save-search.asciidoc b/docs/discover/save-search.asciidoc
index 490be4cd49b2..dc9227970b89 100644
--- a/docs/discover/save-search.asciidoc
+++ b/docs/discover/save-search.asciidoc
@@ -21,7 +21,7 @@ image::discover/images/read-only-badge.png[Example of Discover's read only acces
By default, a saved Discover session stores the query text, filters, and
current view of *Discover*, including the columns and sort order in the document table, and the {data-source}.
-. Once you've created a search worth saving, click *Save* in the toolbar.
+. Once you've created a view worth saving, click *Save* in the toolbar.
. Enter a name for the session.
. Optionally store <> and the time range with the session.
. Click *Save*.
From 5b3938ea73be4dfed421e6a76c1256536e48ef7f Mon Sep 17 00:00:00 2001
From: Julia Rechkunova
Date: Wed, 11 Dec 2024 12:18:08 +0100
Subject: [PATCH 22/43] [Discover] Address other comments
---
docs/developer/plugin-list.asciidoc | 2 +-
docs/discover/document-explorer.asciidoc | 2 +-
docs/discover/save-search.asciidoc | 8 ++++----
docs/discover/search.asciidoc | 8 ++++----
packages/kbn-saved-search-component/README.md | 2 +-
.../header/__snapshots__/header.test.tsx.snap | 2 +-
src/plugins/discover/README.md | 2 +-
.../open_search_panel.test.tsx.snap | 8 ++++----
.../top_nav/use_top_nav_links.test.tsx | 16 ++++++++--------
.../__snapshots__/not_found_errors.test.tsx.snap | 10 +++++-----
10 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
index 46b89585f779..036025b201e7 100644
--- a/docs/developer/plugin-list.asciidoc
+++ b/docs/developer/plugin-list.asciidoc
@@ -91,7 +91,7 @@ This API doesn't support angular, for registering angular dev tools, bootstrap a
|{kib-repo}blob/{branch}/src/plugins/discover/README.md[discover]
-|Contains the Discover application and the Discover session embeddable (formerly the Saved Search embeddable).
+|Contains the Discover application and the saved search embeddable.
|{kib-repo}blob/{branch}/src/plugins/discover_shared/README.md[discoverShared]
diff --git a/docs/discover/document-explorer.asciidoc b/docs/discover/document-explorer.asciidoc
index 826ce9ca29f6..d026cf2930f1 100644
--- a/docs/discover/document-explorer.asciidoc
+++ b/docs/discover/document-explorer.asciidoc
@@ -36,7 +36,7 @@ In the pop-up, drag the column names to their new order.
* To resize a column, drag the right edge of the column header until the column is the width that you want.
+
-Column widths are stored with a saved Discover session. When you add the Discover session as a panel to dashboards, it appears the same as in **Discover**.
+Column widths are stored with a Discover session. When you add a Discover session as a dashboard panel, it appears the same as in **Discover**.
[float]
[[document-explorer-density]]
diff --git a/docs/discover/save-search.asciidoc b/docs/discover/save-search.asciidoc
index 490be4cd49b2..ed66940ae6bb 100644
--- a/docs/discover/save-search.asciidoc
+++ b/docs/discover/save-search.asciidoc
@@ -3,7 +3,7 @@
A saved Discover session is a convenient way to reuse a search
that you've created in *Discover*.
-Saved Discover sessions are good for returning to them later or adding search results to a dashboard,
+Discover sessions are good for saving a configured view of Discover to use later or adding search results to a dashboard,
and can also serve as a foundation for building visualizations.
[role="xpack"]
@@ -18,14 +18,14 @@ image::discover/images/read-only-badge.png[Example of Discover's read only acces
[float]
=== Save a Discover session
-By default, a saved Discover session stores the query text, filters, and
+By default, a Discover session stores the query text, filters, and
current view of *Discover*, including the columns and sort order in the document table, and the {data-source}.
. Once you've created a search worth saving, click *Save* in the toolbar.
. Enter a name for the session.
. Optionally store <> and the time range with the session.
. Click *Save*.
-. To reload your search results in *Discover*, click *Open* in the toolbar, and select the saved search.
+. To reload your search results in *Discover*, click *Open* in the toolbar, and select the saved Discover session.
+
If the saved Discover session is associated with a different {data-source} than is currently
selected, opening the saved Discover session changes the selected {data-source}. The query language
@@ -47,4 +47,4 @@ used for the saved Discover session is also automatically selected.
. Open or create the dashboard, then click *Edit*.
. Click *Add from library*.
. From the *Types* dropdown, select *Discover session*.
-. Select the saved Discover session that you want to add, then click *X* to close the list.
+. Select the Discover session that you want to add, then click *X* to close the list.
diff --git a/docs/discover/search.asciidoc b/docs/discover/search.asciidoc
index 475cc6ecbebb..c7fde4159ec9 100644
--- a/docs/discover/search.asciidoc
+++ b/docs/discover/search.asciidoc
@@ -95,7 +95,7 @@ status:[400 TO 499] AND (extension:php OR extension:html)
=== Save a Discover session
A saved Discover session persists your current view of Discover for later retrieval and reuse. You can reload a saved session into Discover, add it to a dashboard, and use it as the basis for a visualization.
-A saved Discover session includes the query text, filters, and optionally, the time filter. A saved Discover session also includes the selected columns in the document table, the sort order, and the current index pattern.
+A Discover session includes the query text, filters, and optionally, the time filter. A Discover session also includes the selected columns in the document table, the sort order, and the current {data-source}.
[role="xpack"]
[[discover-read-only-access]]
@@ -121,8 +121,8 @@ To load a saved session into Discover:
. Click *Open* in the toolbar.
. Select the session you want to open.
-If the saved Discover session is associated with a different index pattern than is currently
-selected, opening the saved Discover session changes the selected index pattern. The query language
+If the saved Discover session is associated with a different {data-source} than is currently
+selected, opening the saved Discover session changes the selected {data-source}. The query language
used for the saved Discover session will also be automatically selected.
[[save-load-delete-query]]
@@ -133,7 +133,7 @@ A saved query is a portable collection of query text and filters that you can re
* View the results of the same query in multiple apps
* Share your query
-Saved queries don't include information specific to Discover, such as the currently selected columns in the document table, the sort order, and the index pattern. If you want to save your current view of Discover for later retrieval and reuse, create a <> instead.
+Saved queries don't include information specific to Discover, such as the currently selected columns in the document table, the sort order, and the {data-source}. If you want to save your current view of Discover for later retrieval and reuse, create a <> instead.
[role="xpack"]
==== Read-only access
diff --git a/packages/kbn-saved-search-component/README.md b/packages/kbn-saved-search-component/README.md
index df712a286d44..61ec5a6cd8a9 100644
--- a/packages/kbn-saved-search-component/README.md
+++ b/packages/kbn-saved-search-component/README.md
@@ -1,6 +1,6 @@
# @kbn/saved-search-component
-A component wrapper around Discover Session embeddable. This can be used in solutions without being within a Dasboard context.
+A component wrapper around Discover session embeddable. This can be used in solutions without being within a Dasboard context.
This can be used to render a context-aware (logs etc) "document table".
diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap
index c45d97c7b009..97486302553f 100644
--- a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap
+++ b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/header/__snapshots__/header.test.tsx.snap
@@ -7,7 +7,7 @@ exports[`Header should render normally 1`] = `
>
diff --git a/src/plugins/discover/README.md b/src/plugins/discover/README.md
index f08acb54df89..6f3f17c97e7a 100644
--- a/src/plugins/discover/README.md
+++ b/src/plugins/discover/README.md
@@ -1,6 +1,6 @@
# Discover
-Contains the Discover application and the Discover session embeddable (formerly the Saved Search embeddable).
+Contains the Discover application and the saved search embeddable.
## Project tree
diff --git a/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap b/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap
index debc23bf401b..7a7945fb2089 100644
--- a/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap
+++ b/src/plugins/discover/public/application/main/components/top_nav/__snapshots__/open_search_panel.test.tsx.snap
@@ -14,7 +14,7 @@ exports[`OpenSearchPanel render 1`] = `
>
@@ -25,7 +25,7 @@ exports[`OpenSearchPanel render 1`] = `
id="discoverOpenSearch"
noItemsMessage={
}
@@ -34,7 +34,7 @@ exports[`OpenSearchPanel render 1`] = `
Array [
Object {
"getIconForSavedObject": [Function],
- "name": "Discover Session",
+ "name": "Discover session",
"type": "search",
},
]
@@ -63,7 +63,7 @@ exports[`OpenSearchPanel render 1`] = `
onClick={[MockFunction]}
>
diff --git a/src/plugins/discover/public/application/main/components/top_nav/use_top_nav_links.test.tsx b/src/plugins/discover/public/application/main/components/top_nav/use_top_nav_links.test.tsx
index b1dfe1d8e4b7..7bd88f75ffdd 100644
--- a/src/plugins/discover/public/application/main/components/top_nav/use_top_nav_links.test.tsx
+++ b/src/plugins/discover/public/application/main/components/top_nav/use_top_nav_links.test.tsx
@@ -91,7 +91,7 @@ describe('useTopNavLinks', () => {
"testId": "discoverOpenButton",
},
Object {
- "description": "Share Discover Session",
+ "description": "Share Discover session",
"iconOnly": true,
"iconType": "share",
"id": "share",
@@ -100,7 +100,7 @@ describe('useTopNavLinks', () => {
"testId": "shareTopNavButton",
},
Object {
- "description": "Save Discover Session",
+ "description": "Save Discover session",
"emphasize": true,
"iconType": "save",
"id": "save",
@@ -149,25 +149,25 @@ describe('useTopNavLinks', () => {
"testId": "openInspectorButton",
},
Object {
- "description": "New Discover Session",
+ "description": "New Discover session",
"iconOnly": true,
"iconType": "plus",
"id": "new",
- "label": "New Discover Session",
+ "label": "New Discover session",
"run": [Function],
"testId": "discoverNewButton",
},
Object {
- "description": "Open a saved Discover Session",
+ "description": "Open a saved Discover session",
"iconOnly": true,
"iconType": "folderOpen",
"id": "open",
- "label": "Open a saved Discover Session",
+ "label": "Open a saved Discover session",
"run": [Function],
"testId": "discoverOpenButton",
},
Object {
- "description": "Share Discover Session",
+ "description": "Share Discover session",
"iconOnly": true,
"iconType": "share",
"id": "share",
@@ -176,7 +176,7 @@ describe('useTopNavLinks', () => {
"testId": "shareTopNavButton",
},
Object {
- "description": "Save Discover Session",
+ "description": "Save Discover session",
"emphasize": true,
"iconType": "save",
"id": "save",
diff --git a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap
index d4a7a8bf8e74..2e35a620dc25 100644
--- a/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap
+++ b/src/plugins/saved_objects_management/public/management_section/object_view/components/__snapshots__/not_found_errors.test.tsx.snap
@@ -25,7 +25,7 @@ exports[`NotFoundErrors component renders correctly for index-pattern type 1`] =
The data view associated with this object no longer exists.