[8.16] [APM] Make trace.id an optional field (#201821)
#201986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes [elastic#201803](elastic#201803) ## Summary This PR fixes the error sample details function, making the `trace.id` an optional field, to prevent the function from crashing in case this field is not in the docs. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit caea206) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/errors/group_id_samples.spec.ts # x-pack/test/apm_api_integration/tests/errors/generate_data.ts
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miloszmarcinkowski
approved these changes
Nov 27, 2024
💚 Build Succeeded
Metrics [docs]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:trace.idan optional field (#201821)Questions ?
Please refer to the Backport tool documentation
\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Carlos Crespo "}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com//pull/201940","number":201940,"state":"MERGED","mergeCommit":{"sha":"4c3fcad3a7e94f2a340940acefe915414bbfabc4","message":"[8.x] [APM] Make `trace.id` an optional field (#201821) (#201940)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[APM] Make `trace.id` an optional field\n(#201821)](https://github.com//pull/201821)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Carlos Crespo "}}]}] BACKPORT-->