Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] use global cdr vuln data view #191581

Merged
merged 13 commits into from
Sep 3, 2024
Merged

[Cloud Security] use global cdr vuln data view #191581

merged 13 commits into from
Sep 3, 2024

Conversation

CohenIdo
Copy link
Contributor

@CohenIdo CohenIdo commented Aug 28, 2024 •
edited
Loading

solves:

Summary

  • Utilize the CDR index pattern in the vulnerability data grid.
  • Implement support for the "Group by" view.
  • The vulnerability data grid is using the global data view.
  • Both vulnerabilities findings types are presented (Native and Wiz)
  • "Group by" functionality is working.
  • Detection rule is created successfully.
  • Clean up code by refactoring duplicate constants that pointed to the same value.
data.view.vuln.mp4

@CohenIdo CohenIdo mentioned this pull request Aug 28, 2024
Merged
@CohenIdo CohenIdo marked this pull request as ready for review August 28, 2024 13:31
@CohenIdo CohenIdo requested review from a team as code owners August 28, 2024 13:31
@CohenIdo CohenIdo added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Aug 28, 2024
@CohenIdo
Copy link
Contributor Author

@elasticmachine merge upstream

@CohenIdo CohenIdo linked an issue Aug 28, 2024 that may be closed by this pull request
Findings page - replace latest vulnerabilities data view with global data view #190387
Closed
5 tasks
@CohenIdo CohenIdo force-pushed the use-global-vuln-data-view branch from 138ab20 to 2d47a28 Compare August 28, 2024 20:37
maxcold
maxcold requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some mix up with the index patterns, pls double check

x-pack/packages/kbn-cloud-security-posture-common/constants.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud_security_posture/common/constants.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud_security_posture/common/constants.ts Outdated Show resolved Hide resolved
...urity_posture/public/pages/vulnerabilities/utils/create_detection_rule_from_vulnerability.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud_security_posture/common/constants.ts Show resolved Hide resolved
x-pack/plugins/cloud_security_posture/server/create_indices/latest_indices.ts Show resolved Hide resolved
@CohenIdo CohenIdo requested a review from maxcold September 2, 2024 15:55
maxcold
maxcold reviewed Sep 2, 2024
View reviewed changes
...ins/cloud_security_posture/public/pages/vulnerabilities/hooks/use_latest_vulnerabilities.tsx Outdated
@@ -91,7 +92,7 @@ export const useLatestVulnerabilities = (options: VulnerabilitiesQuery) => {
* the last loaded record to be used as a from parameter to fetch the next chunk of data.
*/
return useInfiniteQuery(
[LATEST_VULNERABILITIES_INDEX_PATTERN, options],
[CDR_LATEST_NATIVE_VULNERABILITIES_INDEX_PATTERN, options],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it also be CDR_VULNERABILITIES_INDEX_PATTERN here?

Copy link
Contributor Author

@CohenIdo CohenIdo Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CohenIdo CohenIdo requested a review from maxcold September 2, 2024 18:50
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 17.6KB 17.6KB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CohenIdo CohenIdo merged commit c594254 into elastic:main Sep 3, 2024
38 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 3, 2024
@bhavyarm bhavyarm added the Team:Cloud Security Cloud Security team related label Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkraft eyalkraft eyalkraft approved these changes

@maxcold maxcold maxcold approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Findings page - replace latest vulnerabilities data view with global data view
7 participants
@CohenIdo @kibana-ci @elasticmachine @maxcold @eyalkraft @bhavyarm @kibanamachine