[TASK][Security Serverless]: Add semantic headings to Fleet Integration forms #181922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Copenut
added
WCAG A
release_note:skip
1Copenut
commented
Apr 26, 2024
Comment on lines
+143
to
+145
| <EuiTitle size="xs"> | ||
| <h3 id={titleElementId}>{packageInput.title || packageInput.type}</h3> | ||
| </EuiTitle> |
There was a problem hiding this comment.
I opted to switch this out for <EuiTitle/> because I could pass a size prop and ensure the headings were the same size as other H3s on the page without custom CSS.
|
Buildkite test this |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @1Copenut |
|
I've run the Flaky Test Runner a couple of times on flaky FTR suites to make sure I hadn't introduced issues. Both runs passed with 0 issues, and failures were outside the changeset I created. Going to go ahead and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactored the Fleet "Add Integration" form to properly nest headings by level. This improves the experience for screen reader users and helps us improve our standing against WCAG SC 1.3.1 - Info and Relationships (Level A). Screenshot attached below.
Local refactor with nested heading levels
Related issues
Please see the related issue link below. This issue originated from an accessibility review of the Security Serverless project.
Checklist
Delete any items that are not applicable to this PR.
For maintainers