[ProfilingxAPM] Link APM from Profiling UI #180677

cauemarcondes · 2024-04-12T10:01:48Z

A new ES API has been created to support linking APM from the Profiling UI. It's called topN/functions. The new API allows grouping fields. So we first fetch functions grouping by service.name and when the user opens the APM Transactions we make another request grouping by transaction.name.

A new Advanced setting was created to toggle the old API on (fetch functions from Stacktraces API): It's turned off by default.

When there are services on the selected function:
*If we cannot find the transaction, we show N/A.

When there are no services on the selected function:
*hide the APM transactions section

--
Performance boost:
The new API is faster than the Stacktraces API, especially because there's no logic on the Kibana side.
Stacktraces API:

TopN/Functions API:

elasticmachine · 2024-04-12T10:01:54Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2024-04-12T10:01:54Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions · 2024-04-12T10:02:02Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

apmmachine · 2024-04-12T10:02:03Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…fix'

…a into profiling-apm-link-2

iogbole · 2024-04-12T14:28:16Z

@cauemarcondes - suggested copy for the accordion, using the style-for-forms accordion as an inspiration:

Tittle: Distributed Tracing Correlation

Sub-title: A curated view of APM services and transactions that call this function

APM Icon: https://static-www.elastic.co/v3/assets/bltefdd0b53724fa2ce/blt5c6b7c737bbb9532/657196b3d4041cbf8214c5c2/apm-logo-color-reverse-32px.svg

@mdbirnstiehl please review.

FYA @athre0z @christos68k

iogbole · 2024-04-12T14:32:22Z

Also, as discussed in Slack, the list should be sorted by the sample count in desc order, with the ability to filter by both service.name and transaction.name. Thank you

.../plugins/observability_solution/apm/public/components/app/transaction_details_link/index.tsx

x-pack/plugins/observability_solution/profiling/server/routes/apm.ts

x-pack/plugins/observability_solution/profiling/public/services.ts

mdbirnstiehl

Looks good on my side. Thanks!

kpatticha · 2024-04-15T20:19:55Z

...rvability_solution/profiling/public/components/frame_information_window/apm_transactions.tsx

+        }),
+        truncateText: true,
+        sortable: true,
+        render(_, { serviceName, transactionName }) {


The API doesn't return the transaction type? it could be an edge case but a service could have a 2 same transaction names but with different transaction type

Right now fetching the transaction type would mean making more ES queries for each service and transaction just to fetch the transaction types associated. At this point, I don't think it's worth doing it. Let's just make APM pick the first transaction type it finds based on the transaction name.

…a into profiling-apm-link-2

x-pack/plugins/observability_solution/profiling/server/routes/apm.ts

kpatticha

LGTM . I didn't test it manually though cause I don't have profiling data locally

kibana-ci · 2024-04-16T20:28:15Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 91ad321

Failed CI Steps

Jest Integration Tests #6

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1676	1677	+1
`observabilityShared`	196	198	+2
`profiling`	288	291	+3
total			+6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/profiling-utils`	48	55	+7
`observability`	661	669	+8
total			+15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.2MB	3.2MB	+1.4KB
`profiling`	400.7KB	406.6KB	+5.8KB
total			+7.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	150.3KB	150.4KB	+172.0B
`observabilityShared`	63.2KB	64.1KB	+911.0B
`profiling`	18.0KB	18.2KB	+270.0B
total			+1.3KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/profiling-utils`	161	168	+7
`observability`	670	678	+8
total			+15

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…es (#182001) Related to #180677 closes #181886 There's still a small difference on the CO2 values, but that's due to different formats returned by ES apis: ``` TopN Functions "self_annual_co2_tons": 0.0068555964801996295 Flamegraph "AnnualCO2TonsInclusive": [ 0.0069, ``` After: <img width="1765" alt="Screenshot 2024-04-29 at 16 34 57" src="https://github.com/elastic/kibana/assets/55978943/092a704f-69fe-4dd0-99d5-9ac9bce77188"> <img width="1788" alt="Screenshot 2024-04-29 at 16 35 03" src="https://github.com/elastic/kibana/assets/55978943/da4a1406-fad7-48de-81ac-e8aae64cba67">

…es (elastic#182001) Related to elastic#180677 closes elastic#181886 There's still a small difference on the CO2 values, but that's due to different formats returned by ES apis: ``` TopN Functions "self_annual_co2_tons": 0.0068555964801996295 Flamegraph "AnnualCO2TonsInclusive": [ 0.0069, ``` After: <img width="1765" alt="Screenshot 2024-04-29 at 16 34 57" src="https://github.com/elastic/kibana/assets/55978943/092a704f-69fe-4dd0-99d5-9ac9bce77188"> <img width="1788" alt="Screenshot 2024-04-29 at 16 35 03" src="https://github.com/elastic/kibana/assets/55978943/da4a1406-fad7-48de-81ac-e8aae64cba67"> (cherry picked from commit cb77c2d)

…es (elastic#182001) Related to elastic#180677 closes elastic#181886 There's still a small difference on the CO2 values, but that's due to different formats returned by ES apis: ``` TopN Functions "self_annual_co2_tons": 0.0068555964801996295 Flamegraph "AnnualCO2TonsInclusive": [ 0.0069, ``` After: <img width="1765" alt="Screenshot 2024-04-29 at 16 34 57" src="https://github.com/elastic/kibana/assets/55978943/092a704f-69fe-4dd0-99d5-9ac9bce77188"> <img width="1788" alt="Screenshot 2024-04-29 at 16 35 03" src="https://github.com/elastic/kibana/assets/55978943/da4a1406-fad7-48de-81ac-e8aae64cba67">

cauemarcondes added 7 commits April 11, 2024 10:21

[ProfilingxAPM] Show APM transaction links on Profiling ui

03fc284

ui changes

62b7182

adding apm service locator

daf6612

apm transaction by name locator

1cfc734

adding time range

2f3a635

fixing

b5ee771

adv settings

e090081

cauemarcondes added release_note:feature Makes this part of the condensed release notes v8.14.0 labels Apr 12, 2024

cauemarcondes requested review from a team as code owners April 12, 2024 10:01

botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Apr 12, 2024

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

3cb76c0

…fix'

pgayvallet approved these changes Apr 12, 2024

View reviewed changes

cauemarcondes added 3 commits April 12, 2024 13:16

fixing ci

b36ba03

Merge branch 'profiling-apm-link-2' of github.com:cauemarcondes/kiban…

8b2ddcf

…a into profiling-apm-link-2

renaming

d7935a7

crespocarlos reviewed Apr 12, 2024

View reviewed changes

mdbirnstiehl approved these changes Apr 12, 2024

View reviewed changes

cauemarcondes and others added 3 commits April 15, 2024 12:26

search field

c442827

paginating

f27d7da

Merge branch 'main' into profiling-apm-link-2

dca28ec

kpatticha reviewed Apr 15, 2024

View reviewed changes

cauemarcondes added 4 commits April 16, 2024 11:45

paginating

6999697

fixing links

3605d35

fixing i18n

18f5dcf

Merge branch 'profiling-apm-link-2' of github.com:cauemarcondes/kiban…

4505e60

…a into profiling-apm-link-2

cauemarcondes requested a review from crespocarlos April 16, 2024 10:57

shahzad31 approved these changes Apr 16, 2024

View reviewed changes

cauemarcondes requested a review from kpatticha April 16, 2024 11:14

kpatticha reviewed Apr 16, 2024

View reviewed changes

x-pack/plugins/observability_solution/profiling/server/routes/apm.ts Show resolved Hide resolved

kpatticha reviewed Apr 16, 2024

View reviewed changes

x-pack/plugins/observability_solution/profiling/server/routes/apm.ts Outdated Show resolved Hide resolved

fixing profiling route

a78c5ba

kpatticha approved these changes Apr 16, 2024

View reviewed changes

cauemarcondes added 4 commits April 16, 2024 14:27

adding apm access

8794dc1

fixing ci

7db23f6

e2e

dba2d6b

skipping

91ad321

cauemarcondes enabled auto-merge (squash) April 16, 2024 19:10

cauemarcondes merged commit b900b86 into elastic:main Apr 16, 2024
19 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Apr 16, 2024

cauemarcondes deleted the profiling-apm-link-2 branch April 17, 2024 10:53

cauemarcondes mentioned this pull request Apr 30, 2024

[Profiling] Differential views based on same data show different values #182001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ProfilingxAPM] Link APM from Profiling UI #180677

[ProfilingxAPM] Link APM from Profiling UI #180677

cauemarcondes commented Apr 12, 2024 •

edited

Loading

elasticmachine commented Apr 12, 2024

elasticmachine commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

apmmachine commented Apr 12, 2024

iogbole commented Apr 12, 2024

iogbole commented Apr 12, 2024

mdbirnstiehl left a comment

kpatticha Apr 15, 2024 •

edited

Loading

cauemarcondes Apr 16, 2024

kpatticha left a comment

kibana-ci commented Apr 16, 2024

API count

[ProfilingxAPM] Link APM from Profiling UI #180677

[ProfilingxAPM] Link APM from Profiling UI #180677

Conversation

cauemarcondes commented Apr 12, 2024 • edited Loading

elasticmachine commented Apr 12, 2024

elasticmachine commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

apmmachine commented Apr 12, 2024

🤖 GitHub comments

iogbole commented Apr 12, 2024

iogbole commented Apr 12, 2024

mdbirnstiehl left a comment

Choose a reason for hiding this comment

kpatticha Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

cauemarcondes Apr 16, 2024

Choose a reason for hiding this comment

kpatticha left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 16, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

cauemarcondes commented Apr 12, 2024 •

edited

Loading

kpatticha Apr 15, 2024 •

edited

Loading