[Lens] Fixes color mappings special tockens i18n #168152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
bug
nickofthyme
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Looks good to me. Tested vis with non-auto-assign values of (empty) and Other starting with fr-FR then en then finally ja-JP and all color mappings are correctly assigned even for concatenated fields, even with adding a manual (empty) and Other bucket.
Simple fields
Concatenated fields
Probably a rare edge case but I think this would break for fields labeled as (empty) or Other. Not worth trying to fix that but if possible in the future would be nice to pass down the original keyed values instead of inverting from a formatted string value.
stratoula
changed the title
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
approved these changes
Oct 6, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
## Summary fix elastic#168151 To test: - create a cartesian charts with breakdowns that contains both the `Other` group and an `(empty)` value - apply a manual color mapping that use both these terms by select them from the combo-box, not by typing them. - Then change the Kibana language to a different one other than English and see if the color mapping applies correctly. --------- Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit c828ff4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
…68189) # Backport This will backport the following commits from `main` to `8.11`: - [[Lens] Fixes color mappings special tockens i18n (#168152)](#168152) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-06T09:21:41Z","message":"[Lens] Fixes color mappings special tockens i18n (#168152)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/168151\r\n\r\nTo test:\r\n- create a cartesian charts with breakdowns that contains both the\r\n`Other` group and an `(empty)` value\r\n- apply a manual color mapping that use both these terms by select them\r\nfrom the combo-box, not by typing them.\r\n- Then change the Kibana language to a different one other than English\r\nand see if the color mapping applies correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"c828ff49dbf7f4e8ef28adf832ab40bd495ea2db","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","Feature:Lens","backport:prev-minor","v8.11.0","v8.12.0"],"number":168152,"url":"https://github.com/elastic/kibana/pull/168152","mergeCommit":{"message":"[Lens] Fixes color mappings special tockens i18n (#168152)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/168151\r\n\r\nTo test:\r\n- create a cartesian charts with breakdowns that contains both the\r\n`Other` group and an `(empty)` value\r\n- apply a manual color mapping that use both these terms by select them\r\nfrom the combo-box, not by typing them.\r\n- Then change the Kibana language to a different one other than English\r\nand see if the color mapping applies correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"c828ff49dbf7f4e8ef28adf832ab40bd495ea2db"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168152","number":168152,"mergeCommit":{"message":"[Lens] Fixes color mappings special tockens i18n (#168152)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/168151\r\n\r\nTo test:\r\n- create a cartesian charts with breakdowns that contains both the\r\n`Other` group and an `(empty)` value\r\n- apply a manual color mapping that use both these terms by select them\r\nfrom the combo-box, not by typing them.\r\n- Then change the Kibana language to a different one other than English\r\nand see if the color mapping applies correctly.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"c828ff49dbf7f4e8ef28adf832ab40bd495ea2db"}}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
## Summary fix elastic#168151 To test: - create a cartesian charts with breakdowns that contains both the `Other` group and an `(empty)` value - apply a manual color mapping that use both these terms by select them from the combo-box, not by typing them. - Then change the Kibana language to a different one other than English and see if the color mapping applies correctly. --------- Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #168151
To test:
Othergroup and an(empty)value