-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inspector] clusters tab MVP #166025
[inspector] clusters tab MVP #166025
Conversation
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the code, and followed the instructions for testing in Discover. I also did some testing in Dashboard and everything looks great.
Nice test coverage, and very clean code. Left a few very small nits. The only thing that could elevate this is some functional test coverge, but I assume we'll be adding CCS functional test coverage in the future.
src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_view.tsx
Show resolved
Hide resolved
...quests/components/details/clusters_view/clusters_table/shards_view/shard_failure_details.tsx
Show resolved
Hide resolved
...r/public/views/requests/components/details/clusters_view/clusters_health/clusters_health.tsx
Outdated
Show resolved
Hide resolved
...inspector/public/views/requests/components/details/clusters_view/clusters_health/gradient.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Closes #166021
Closes #163381
This PR adds inspector cluster tab MVP
This PR does not:
Test setup
yarn es snapshot -E transport.port=9500 -E http.port=9201 -E path.data=../remote1
elasticsearch.hosts: ["http://localhost:9201"]
to kibana.dev.yml. Note createconfig/kibana.dev.yml
if one does not exist. kibana.dev.yml is not managed by git so it has to be created the first time you add values.yarn start
to start kibana processelasticsearch.hosts
from kibana.dev.ymlyarn es snapshot -E path.data=../local1
kibana_sample_data*,remote1:kibana_sample_data*
timestamp
Local cluster (status=successful)
Remote cluster (status=successful)
Remote cluster (status=partial, failed shard)
Remote cluster (status=skipped, all shards fail)
Remote cluster (status=skipped, no remote)