From 374dd29ec7dcd6006183e79f56151536be99bdde Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 23 Aug 2023 15:16:11 +0200 Subject: [PATCH 01/17] chore(quality-gates): trigger downstream test pipelines from quality-gate pipelines --- .buildkite/hooks/post-command | 6 ++- .buildkite/hooks/pre-command | 8 ++- .../quality-gates/pipeline.tests-qa.yaml | 53 +++++++++++++------ 3 files changed, 49 insertions(+), 18 deletions(-) diff --git a/.buildkite/hooks/post-command b/.buildkite/hooks/post-command index d9a8ad668da0b..123dc8be52a33 100755 --- a/.buildkite/hooks/post-command +++ b/.buildkite/hooks/post-command @@ -1,3 +1,7 @@ #!/usr/bin/env bash -.buildkite/scripts/lifecycle/post_command.sh +if [ "$SKIP_KIBANA_HOOKS" = "1" ]; then + echo "Pipeline file triggered with SKIP_KIBANA_HOOKS, skipping pre_command.sh" +else + .buildkite/scripts/lifecycle/post_command.sh +fi diff --git a/.buildkite/hooks/pre-command b/.buildkite/hooks/pre-command index 58a2c5f0b499d..83b073c218c38 100644 --- a/.buildkite/hooks/pre-command +++ b/.buildkite/hooks/pre-command @@ -1,3 +1,9 @@ #!/usr/bin/env bash -source .buildkite/scripts/lifecycle/pre_command.sh +env + +if [ "$SKIP_KIBANA_HOOKS" = "1" ]; then + echo "Pipeline file triggered with SKIP_KIBANA_HOOKS, skipping pre_command.sh" +else + source .buildkite/scripts/lifecycle/pre_command.sh +fi diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 669b306bc2ceb..baf13b269175f 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -1,20 +1,41 @@ steps: - - label: ":pipeline::kibana::seedling: Trigger Kibana Tests for ${ENVIRONMENT}" - command: echo "replace me with Kibana specific tests" - agent: - image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" + - label: ":pipeline::kibana::seedling: Trigger Kibana Serverless Tests for ${ENVIRONMENT}" + trigger: appex-qa-kibana-serverless-ftr-tests + build: + env: + ENVIRONMENT: ${ENVIRONMENT} + message: Triggered by pipeline.tests.qa.yaml + branch: $BUILDKITE_BRANCH + commit: $BUILDKITE_COMMIT + name: Serverless tests - - label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}" - command: echo "replace me with Fleet specific Kibana tests" - agent: - image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" + - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" + trigger: appex-qa-rac-alert-load + build: + env: + ENVIRONMENT: ${ENVIRONMENT} + message: Triggered by pipeline.tests.qa.yaml + branch: $BUILDKITE_BRANCH + commit: $BUILDKITE_COMMIT + name: RAC Alert load tests - - label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}" - command: echo "replace me with Security specific Kibana tests" - agent: - image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" + - wait: ~ + + - block: ":male-mechanic: Confirm QA tests" + prompt: "Do you confirm, that the QA testing is done and successful?" + +# - label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}" +# command: echo "replace me with Fleet specific Kibana tests" +# agent: +# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" +# +# - label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}" +# command: echo "replace me with Security specific Kibana tests" +# agent: +# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" +# +# - label: ":pipeline::lock::seedling: Trigger Control Plane Kibana Tests for ${ENVIRONMENT}" +# command: echo "replace me with Control Plane specific Kibana tests" +# agent: +# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" - - label: ":pipeline::lock::seedling: Trigger Control Plane Kibana Tests for ${ENVIRONMENT}" - command: echo "replace me with Control Plane specific Kibana tests" - agent: - image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" From ca1e48f25035fcdc9bfa8c30ae9371e1e8bae915 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 23 Aug 2023 15:32:42 +0200 Subject: [PATCH 02/17] chore(quality-gates): move pipeline head file to .buildkite/ where the catalog-info is pointing --- .../pipelines/{quality-gates => }/pipeline.kibana-tests.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) rename .buildkite/pipelines/{quality-gates => }/pipeline.kibana-tests.yaml (82%) diff --git a/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml b/.buildkite/pipelines/pipeline.kibana-tests.yaml similarity index 82% rename from .buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml rename to .buildkite/pipelines/pipeline.kibana-tests.yaml index 27e55dfced9d7..05a76a1339a14 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml +++ b/.buildkite/pipelines/pipeline.kibana-tests.yaml @@ -1,8 +1,5 @@ -env: - ENVIRONMENT: ${ENVIRONMENT?} - steps: - - label: ":pipeline::grey_question::seedling: Trigger Kibana Tests for ${ENVIRONMENT}" + - label: ":pipeline::grey_question::seedling: Trigger Kibana Tests" env: QG_PIPELINE_LOCATION: ".buildkite/pipelines/quality-gates" command: "make -C /agent run-environment-tests" From 5700043532a5f9fd6942bb061bdb3b337cac1590 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 23 Aug 2023 16:19:15 +0200 Subject: [PATCH 03/17] chore(quality-gates): remove name property from build --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index baf13b269175f..bc92feb1b53b7 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -38,4 +38,3 @@ steps: # command: echo "replace me with Control Plane specific Kibana tests" # agent: # image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" - From 4aaa82118852f668c6ab818970d8b3843f378f9a Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Thu, 24 Aug 2023 11:13:01 +0200 Subject: [PATCH 04/17] chore(quality-gates): Add quality gates for staging, add baking periods --- .../quality-gates/pipeline.tests-staging.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml index 5a0738ead7d9c..481370003a116 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml @@ -8,3 +8,15 @@ steps: command: echo "replace me with Security specific Kibana tests" agent: image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" + - label: ":pipeline::kibana::seedling: Trigger Kibana Serverless Tests for ${ENVIRONMENT}" + trigger: kibana-serverless + build: + env: + ENVIRONMENT: ${ENVIRONMENT} + message: Triggered by pipeline.tests.qa.yaml + branch: $BUILDKITE_BRANCH + commit: $BUILDKITE_COMMIT + - wait: ~ + + - label: ":cookie: Bake period of 24 hours" + command: "sleep 86400" From 15267d793249df1fe6fa809aefb38f369265cbed Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Fri, 25 Aug 2023 11:21:10 +0200 Subject: [PATCH 05/17] chore(quality-gates): move kibana-tests head file to original slot --- .../pipelines/{ => quality-gates}/pipeline.kibana-tests.yaml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .buildkite/pipelines/{ => quality-gates}/pipeline.kibana-tests.yaml (100%) diff --git a/.buildkite/pipelines/pipeline.kibana-tests.yaml b/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml similarity index 100% rename from .buildkite/pipelines/pipeline.kibana-tests.yaml rename to .buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml From 082e40bdbe60a8ed22873dede288e01a06a291e0 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Tue, 29 Aug 2023 13:20:24 +0200 Subject: [PATCH 06/17] chore(quality-gates): Remove name params from trigger steps --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index bc92feb1b53b7..4a85ff4fe1daf 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -7,7 +7,6 @@ steps: message: Triggered by pipeline.tests.qa.yaml branch: $BUILDKITE_BRANCH commit: $BUILDKITE_COMMIT - name: Serverless tests - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" trigger: appex-qa-rac-alert-load @@ -17,7 +16,6 @@ steps: message: Triggered by pipeline.tests.qa.yaml branch: $BUILDKITE_BRANCH commit: $BUILDKITE_COMMIT - name: RAC Alert load tests - wait: ~ From a7b4ebe64d9aed9100f057fb88b995cf3058eda3 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 30 Aug 2023 11:04:25 +0200 Subject: [PATCH 07/17] chore(quality-gates): add fleet test job, add build links --- .../quality-gates/pipeline.tests-qa.yaml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 4a85ff4fe1daf..41f2ed77b8125 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -1,21 +1,24 @@ steps: - label: ":pipeline::kibana::seedling: Trigger Kibana Serverless Tests for ${ENVIRONMENT}" - trigger: appex-qa-kibana-serverless-ftr-tests + trigger: appex-qa-kibana-serverless-ftr-tests # https://buildkite.com/elastic/appex-qa-kibana-serverless-ftr-tests build: env: ENVIRONMENT: ${ENVIRONMENT} message: Triggered by pipeline.tests.qa.yaml - branch: $BUILDKITE_BRANCH - commit: $BUILDKITE_COMMIT - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" - trigger: appex-qa-rac-alert-load + trigger: appex-qa-rac-alert-load # https://buildkite.com/elastic/appex-qa-rac-alert-load + build: + env: + ENVIRONMENT: ${ENVIRONMENT} + message: Triggered by pipeline.tests.qa.yaml + + - label: ":pipeline::ship::seedling: Trigger Fleet serverless smoke tests for ${ENVIRONMENT}" + trigger: fleet-smoke-tests # https://buildkite.com/elastic/fleet-smoke-tests build: env: ENVIRONMENT: ${ENVIRONMENT} message: Triggered by pipeline.tests.qa.yaml - branch: $BUILDKITE_BRANCH - commit: $BUILDKITE_COMMIT - wait: ~ From c2f2c693b6b52622421e8ae9c80937fd458e7f10 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Thu, 31 Aug 2023 16:00:32 +0200 Subject: [PATCH 08/17] chore(quality-gates): Add security solutions qg pipeline script stub --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 41f2ed77b8125..0f88b0e854e25 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -8,6 +8,14 @@ steps: - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" trigger: appex-qa-rac-alert-load # https://buildkite.com/elastic/appex-qa-rac-alert-load + build: + env: + ENVIRONMENT: ${ENVIRONMENT} + SERVERLESS_ONLY: true + message: Triggered by pipeline.tests.qa.yaml + + - label: ":pipeline::female-detective::seedling: Trigger Security Solution quality gate script" + command: .buildkite/scripts/pipelines/security_solution_quality_gate/pipeline.sh build: env: ENVIRONMENT: ${ENVIRONMENT} From 2beebb04f1ebd5e069da84048d9b701f5c783359 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Mon, 4 Sep 2023 09:56:26 +0200 Subject: [PATCH 09/17] chore(quality-gates): only run hooks when agent manager is kibana --- .buildkite/hooks/post-command | 6 +++--- .buildkite/hooks/pre-command | 8 +++----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.buildkite/hooks/post-command b/.buildkite/hooks/post-command index 123dc8be52a33..e89f08141d3df 100755 --- a/.buildkite/hooks/post-command +++ b/.buildkite/hooks/post-command @@ -1,7 +1,7 @@ #!/usr/bin/env bash -if [ "$SKIP_KIBANA_HOOKS" = "1" ]; then - echo "Pipeline file triggered with SKIP_KIBANA_HOOKS, skipping pre_command.sh" -else +if [ "$BUILDKITE_AGENT_META_DATA_AGENT_MANAGER" = "kibana" ]; then .buildkite/scripts/lifecycle/post_command.sh +else + echo "Pipeline file triggered from outside the kibana executors, skipping post_command" fi diff --git a/.buildkite/hooks/pre-command b/.buildkite/hooks/pre-command index 83b073c218c38..e6c4216da9147 100644 --- a/.buildkite/hooks/pre-command +++ b/.buildkite/hooks/pre-command @@ -1,9 +1,7 @@ #!/usr/bin/env bash -env - -if [ "$SKIP_KIBANA_HOOKS" = "1" ]; then - echo "Pipeline file triggered with SKIP_KIBANA_HOOKS, skipping pre_command.sh" -else +if [ "$BUILDKITE_AGENT_META_DATA_AGENT_MANAGER" = "kibana" ]; then source .buildkite/scripts/lifecycle/pre_command.sh +else + echo "Pipeline file triggered from outside the kibana executors, skipping pre_command" fi From 7089ff6bdb721594779d9edad04ec732ba1b0dcf Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Mon, 4 Sep 2023 13:22:00 +0200 Subject: [PATCH 10/17] chore: remove 'build' props (they don't exist on command triggers) --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 0f88b0e854e25..3f34939d8d1b2 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -16,10 +16,6 @@ steps: - label: ":pipeline::female-detective::seedling: Trigger Security Solution quality gate script" command: .buildkite/scripts/pipelines/security_solution_quality_gate/pipeline.sh - build: - env: - ENVIRONMENT: ${ENVIRONMENT} - message: Triggered by pipeline.tests.qa.yaml - label: ":pipeline::ship::seedling: Trigger Fleet serverless smoke tests for ${ENVIRONMENT}" trigger: fleet-smoke-tests # https://buildkite.com/elastic/fleet-smoke-tests From 538aa063de97fcd8beb62610fd6fbbd03f9f3675 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Mon, 4 Sep 2023 14:18:42 +0200 Subject: [PATCH 11/17] chore(quality-gates): Remove uplicate skip instruction from pre_commands --- .buildkite/scripts/lifecycle/pre_command.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.buildkite/scripts/lifecycle/pre_command.sh b/.buildkite/scripts/lifecycle/pre_command.sh index cf31fc95bcb5a..b945f08d1dfd9 100755 --- a/.buildkite/scripts/lifecycle/pre_command.sh +++ b/.buildkite/scripts/lifecycle/pre_command.sh @@ -2,11 +2,6 @@ set -euo pipefail -if [[ "$BUILDKITE_COMMAND" =~ ^"buildkite-agent pipeline upload" ]]; then - echo "Skipped pre-command when running the Upload pipeline" - exit 0 -fi - source .buildkite/scripts/common/util.sh echo '--- Setup environment vars' From b885d4f83e32b211dc109cb5098f955bbbb815e0 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Mon, 4 Sep 2023 14:47:37 +0200 Subject: [PATCH 12/17] chore(quality-gates): Remove stub triggers from QA quality-gate job --- .../quality-gates/pipeline.tests-qa.yaml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 3f34939d8d1b2..37ff128017100 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -28,18 +28,3 @@ steps: - block: ":male-mechanic: Confirm QA tests" prompt: "Do you confirm, that the QA testing is done and successful?" - -# - label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}" -# command: echo "replace me with Fleet specific Kibana tests" -# agent: -# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" -# -# - label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}" -# command: echo "replace me with Security specific Kibana tests" -# agent: -# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" -# -# - label: ":pipeline::lock::seedling: Trigger Control Plane Kibana Tests for ${ENVIRONMENT}" -# command: echo "replace me with Control Plane specific Kibana tests" -# agent: -# image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" From 6d3e8150063101794c535f2af18b1857352ea576 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Tue, 5 Sep 2023 16:26:15 +0200 Subject: [PATCH 13/17] chore(quality-gates): Prevent verification (mostly because of notifications) of non-main branches --- .../pipelines/quality-gates/pipeline.tests-production.yaml | 1 + .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 2 ++ .buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml | 1 + 3 files changed, 4 insertions(+) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml index b1022ad33d475..17522640426e2 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml @@ -15,5 +15,6 @@ steps: - label: ":judge::seedling: Trigger Manual Tests Phase" command: "make -C /agent trigger-manual-verification-phase" + if: build.branch == "main" agents: image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2" diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 19a0880fd78db..af59211b70dbe 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -26,6 +26,7 @@ steps: - label: ":judge::seedling: Trigger Manual Tests Phase" command: "make -C /agent trigger-manual-verification-phase" + if: build.branch == "main" env: TEAM_CHANNEL: "#kibana-mission-control" agents: @@ -50,5 +51,6 @@ steps: - label: ":judge::seedling: Trigger Manual Tests Phase" command: "make -C /agent trigger-manual-verification-phase" + if: build.branch == "main" agents: image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2" diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml index 2559b71789733..6430dbc23593b 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml @@ -15,5 +15,6 @@ steps: - label: ":judge::seedling: Trigger Manual Tests Phase" command: "make -C /agent trigger-manual-verification-phase" + if: build.branch == "main" agents: image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2" From f899e916713e46f258038d6c5f971700c374bf64 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 6 Sep 2023 10:01:59 +0200 Subject: [PATCH 14/17] chore(quality-gates): Add more build URLs, re-add env to message --- .buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml | 4 ++-- .../pipelines/quality-gates/pipeline.tests-production.yaml | 2 +- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 2 +- .../pipelines/quality-gates/pipeline.tests-staging.yaml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml b/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml index b9a9b2f2e0145..467df501bc9ca 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml @@ -15,10 +15,10 @@ env: ENVIRONMENT: ${ENVIRONMENT?} steps: - - label: ":pipeline::grey_question::seedling: Trigger Kibana Tests" + - label: ":pipeline::grey_question::seedling: Trigger Kibana Tests for ${ENVIRONMENT}" env: QG_PIPELINE_LOCATION: ".buildkite/pipelines/quality-gates" - command: "make -C /agent run-environment-tests" + command: "make -C /agent run-environment-tests" # will trigger https://buildkite.com/elastic/kibana-tests agents: image: "docker.elastic.co/ci-agent-images/quality-gate-seedling:0.0.2" diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml index 17522640426e2..32878e2fc09cd 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-production.yaml @@ -4,7 +4,7 @@ steps: - label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests" - trigger: "ess-k8s-production-e2e-tests" + trigger: "ess-k8s-production-e2e-tests" # https://buildkite.com/elastic/ess-k8s-production-e2e-tests build: env: REGION_ID: aws-us-east-1 diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index af59211b70dbe..99224625cd3d5 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -40,7 +40,7 @@ steps: message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)" - label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests" - trigger: "ess-k8s-qa-e2e-tests-daily" + trigger: "ess-k8s-qa-e2e-tests-daily" # https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily build: env: REGION_ID: aws-eu-west-1 diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml index 6430dbc23593b..a376ff2ff1884 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml @@ -4,7 +4,7 @@ steps: - label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests" - trigger: "ess-k8s-staging-e2e-tests" + trigger: "ess-k8s-staging-e2e-tests" # https://buildkite.com/elastic/ess-k8s-staging-e2e-tests build: env: REGION_ID: aws-us-east-1 From b075ba0ffc66e37b8fab0851bb142e68f778fcc6 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 6 Sep 2023 10:32:07 +0200 Subject: [PATCH 15/17] chore(quality-gates): Allow soft fails on some steps. We currently don't have the downstream pipelines working well, but we might want to push releases through the whole env chain --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 99224625cd3d5..641ba10c45f37 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -5,6 +5,7 @@ steps: - label: ":pipeline::kibana::seedling: Trigger Kibana Serverless Tests for ${ENVIRONMENT}" trigger: appex-qa-kibana-serverless-ftr-tests # https://buildkite.com/elastic/appex-qa-kibana-serverless-ftr-tests + soft_fail: true # Remove this before release or when tests stabilize build: env: ENVIRONMENT: ${ENVIRONMENT} @@ -12,6 +13,7 @@ steps: - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" trigger: appex-qa-rac-alert-load # https://buildkite.com/elastic/appex-qa-rac-alert-load + soft_fail: true # Remove this before release or when tests stabilize build: env: ENVIRONMENT: ${ENVIRONMENT} @@ -34,6 +36,7 @@ steps: - label: ":pipeline::ship::seedling: Trigger Fleet serverless smoke tests for ${ENVIRONMENT}" trigger: fleet-smoke-tests # https://buildkite.com/elastic/fleet-smoke-tests + soft_fail: true # Remove this before release or when tests stabilize build: env: ENVIRONMENT: ${ENVIRONMENT} @@ -41,6 +44,7 @@ steps: - label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests" trigger: "ess-k8s-qa-e2e-tests-daily" # https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily + soft_fail: true # Remove this before release or when tests stabilize build: env: REGION_ID: aws-eu-west-1 From c9e7fa7441d93cf1f58970fa766da058dd604eb6 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 6 Sep 2023 11:23:07 +0200 Subject: [PATCH 16/17] chore(quality-gates): Remove unneeded soft-fail allowances --- .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 641ba10c45f37..1e4956ed8b557 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -36,7 +36,7 @@ steps: - label: ":pipeline::ship::seedling: Trigger Fleet serverless smoke tests for ${ENVIRONMENT}" trigger: fleet-smoke-tests # https://buildkite.com/elastic/fleet-smoke-tests - soft_fail: true # Remove this before release or when tests stabilize + soft_fail: true # Remove this before release build: env: ENVIRONMENT: ${ENVIRONMENT} @@ -44,7 +44,6 @@ steps: - label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests" trigger: "ess-k8s-qa-e2e-tests-daily" # https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily - soft_fail: true # Remove this before release or when tests stabilize build: env: REGION_ID: aws-eu-west-1 From ecd6beba81fed2dea91c542475d532cdaef4b631 Mon Sep 17 00:00:00 2001 From: Alex Szabo Date: Wed, 6 Sep 2023 12:02:38 +0200 Subject: [PATCH 17/17] chore(quality-gates): Remove RAC load tests --- .../pipelines/quality-gates/pipeline.tests-qa.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml index 1e4956ed8b557..e7fbf640cf565 100644 --- a/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml +++ b/.buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml @@ -11,15 +11,6 @@ steps: ENVIRONMENT: ${ENVIRONMENT} message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)" - - label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}" - trigger: appex-qa-rac-alert-load # https://buildkite.com/elastic/appex-qa-rac-alert-load - soft_fail: true # Remove this before release or when tests stabilize - build: - env: - ENVIRONMENT: ${ENVIRONMENT} - SERVERLESS_ONLY: true - message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)" - - group: ":female-detective: Security Solution Tests" key: "security" steps: